Update downstream Autofill test to handle date validation change |
|||||||||
Issue descriptionIn the wake of https://codereview.chromium.org/2124343002, AutofillClientIOS::GetSyncService() gets called from AutofillControllerTest.CreditCardImport. That method is NOTIMPLEMENTED(), and removing that macro causes the test to hang indefinitely. AutofillControllerTest.CreditCardImport has been disabled pending a fix.
,
Jul 11 2016
,
Jul 12 2016
The NOTIMPLEMENTED() is a red herring. NOTIMPLEMENTED just produces a LOG(ERROR) and it's been getting called in this test for quite some time. The change that started causing this test to fail is https://codereview.chromium.org/2136453003 which made expiration date years > 2999 invalid. Sending the fix for review now.
,
Jul 12 2016
,
Jul 12 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/4bc5dab3af203ba5d5f5b1cdeefe256fbb155ef4 commit 4bc5dab3af203ba5d5f5b1cdeefe256fbb155ef4 Author: jdonnelly <jdonnelly@google.com> Date: Tue Jul 12 16:40:41 2016
,
Jul 12 2016
,
Jul 19 2016
Issue 629623 has been merged into this issue.
,
Jul 19 2016
I failed to notice that the CL that caused this issue was merged to M53. I'll need to merge the fix as well. Just the second CL (comment 5).
,
Jul 19 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 20 2016
Issue 629802 has been merged into this issue.
,
Jul 20 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/115ea217ee340b2af31c1d2838f89b34cde04a67 commit 115ea217ee340b2af31c1d2838f89b34cde04a67 Author: Justin Donnelly <jdonnelly@google.com> Date: Wed Jul 20 18:28:54 2016
,
Jul 20 2016
,
Jan 24 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 11 2016