New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627096 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
OOO Dec 22 - Jan 8
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

frames > 0 in audio_bus.cc

Project Member Reported by ClusterFuzz, Jul 11 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5082153218211840

Fuzzer: phoglund_webrtc_peerconnection
Job Type: linux_asan_chrome_chromeos
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  frames > 0 in audio_bus.cc
  media::ValidateConfig
  media::AudioBus::AudioBus
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_chromeos&range=403894:403906

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv95-TWTr9zItUVwaDf19gt0_syYHpL-tUXDQXrAlvluIb5NmSlOnuXg3ONRCigNUpsm_TSKNKXVY1KvmyapjCT_CVY5mW-E5SHj5lUxivwHIY3ES8l2OMKCoKxV81JliBhQuq4NsvI43gsRPNxmVhHb3lXDsevl9zDeVrHRsRKlC4zeh-EI?testcase_id=5082153218211840


Additional requirements: Requires Gestures

Additional requirements: Requires HTTP

Filer: kavvaru

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Tools>Test>FindIt>NoResult Internals>Media
Labels: Te-Logged M-53
Owner: perkj@chromium.org
Status: Assigned (was: Available)
Regression CL ::
================
https://chromium.googlesource.com/chromium/src/+log/53adfa415fbf9bcb34a1e988b83da7d42a1b4cf9..1c88977a803343e486b591443e8edc65b90c25fa?pretty=fuller

Possible suspect 
https://codereview.chromium.org/2122153002

perkj@ Could you please look into this issue if it is related to your change,else please route this to an appropriate owner for this issue.

Thanks,

Comment 2 by perkj@chromium.org, Jul 11 2016

Cc: perkj@chromium.org
Owner: olka@chromium.org
I have only changed test files so its not me in that range. 
Olga, do you know anything about this? I can't see anything that sticks out in that range.

Comment 3 by olka@chromium.org, Jul 12 2016

Looks like we are getting zero as hardware buffer size here https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/audio/AudioDestination.cpp?sq=package:chromium&dr=CSs&rcl=1468293534&l=70

I don't know of any recent change that could cause it though, and have not found any place where it can be set to 0 so far. The value is obtained from browser side (audio manager) via synchronous IPC.

"Unable to reproduce crash reliably" sounds suspicious.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 12 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Generally when we see 0 values it's because there's no audio hardware. Previously we had checks in place for 0 value sample rates that may have been lost in recent refactorings.

Comment 6 by olka@chromium.org, Jul 12 2016

There is no hardware on those VMs. Tried to track down recent changes, but have not found checks. Should we CHECK in AudioHardwareConfig?
No, clients need to check that the config given to them is valid before trying to use it. When this happens on media we fallback to a fake audio renderer.
Project Member

Comment 8 by ClusterFuzz, Jul 13 2016

ClusterFuzz has detected this issue as fixed in range 404886:404895.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5082153218211840

Fuzzer: phoglund_webrtc_peerconnection
Job Type: linux_asan_chrome_chromeos
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  frames > 0 in audio_bus.cc
  media::ValidateConfig
  media::AudioBus::AudioBus
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_chromeos&range=403894:403906
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_chromeos&range=404886:404895

Unminimized Testcase: https://cluster-fuzz.appspot.com/download/AMIfv95-TWTr9zItUVwaDf19gt0_syYHpL-tUXDQXrAlvluIb5NmSlOnuXg3ONRCigNUpsm_TSKNKXVY1KvmyapjCT_CVY5mW-E5SHj5lUxivwHIY3ES8l2OMKCoKxV81JliBhQuq4NsvI43gsRPNxmVhHb3lXDsevl9zDeVrHRsRKlC4zeh-EI?testcase_id=5082153218211840


Additional requirements: Requires Gestures

Additional requirements: Requires HTTP

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jul 13 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Comment 10 by olka@chromium.org, Jul 13 2016

Checking for no device is being tracked in  Issue 549125 .
Components: -Tools>Test>FindIt>NoResult
Project Member

Comment 12 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment