Switcher icon color changes as the toolbar hides for dark theme color toolbars |
|||
Issue descriptionChrome Dev 53.0.2782.9, Nexus 6P When theme colors are dark (ex: m.facebook, theguardian), the switcher icon changes from white to gray as the toolbar scrolls off the top edge of the screen.
,
Jul 11 2016
I'm not able to reproduce this issue on my nexus 5 or 6P with 53.0.2782.9 (or ToT 54.0.2794.0). Are there any other steps to reproduce?
,
Jul 11 2016
1. open chrome, visit m.facebook.com 2. leave that tab focused 3. open overview, and swipe Chrome away 4. re-launch chrome, let m.facebook.com load again 5. scroll toolbar slowly Maybe it's specific to cold start toolbars?
,
Jul 12 2016
Yeah, I know what's wrong. Thanks for updating!
,
Jul 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34000a697fcb9652726b4169bd15fdd7dc22206b commit 34000a697fcb9652726b4169bd15fdd7dc22206b Author: mdjones <mdjones@chromium.org> Date: Tue Jul 12 20:23:30 2016 Check theme color when updating toolbar assets Since tabs can now be restored with a theme color in use, that color should be considered when initializing the tab switcher icon. BUG= 627091 Review-Url: https://codereview.chromium.org/2139133002 Cr-Commit-Position: refs/heads/master@{#404828} [modify] https://crrev.com/34000a697fcb9652726b4169bd15fdd7dc22206b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
,
Jul 13 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tedc...@chromium.org
, Jul 11 2016