New issue
Advanced search Search tips

Issue 627046 link

Starred by 2 users
Status: Fixed
Owner:
yhirano@chromium.org
Closed: Jul 2016
Cc:
domenic@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Relay body stream error from a ServiceWorker script to the page

Project Member Reported by yhirano@chromium.org, Jul 11 2016 
When transferring a Response made from a ReadableStream from a ServiceWorker to the page, It's possible that stream becomes errored after calling respondWith.

Currently Chrome doesn't recognize such errors and as a result the page gets a hanging connection. It should be fixed.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ecb30baac7eed72a9729e0f7cdf84fe8cd7178d

commit 2ecb30baac7eed72a9729e0f7cdf84fe8cd7178d
Author: yhirano <yhirano@chromium.org>
Date: Wed Jul 20 14:46:48 2016

[Stream] Notify ReadObserver of Stream abortion

Currently there is no means to get notified when a content::Stream is aborted.
As a result, when a fetch body stream created in a ServiceWorker is get
errored, that error is not notified to the page. This CL fixes that problem by
calling ReadObserver::OnDataAvailable when a content::Stream is aborted.

BUG= 627046 

Review-Url: https://codereview.chromium.org/2146773002
Cr-Commit-Position: refs/heads/master@{#406553}

[modify] https://crrev.com/2ecb30baac7eed72a9729e0f7cdf84fe8cd7178d/content/browser/streams/stream.cc
[modify] https://crrev.com/2ecb30baac7eed72a9729e0f7cdf84fe8cd7178d/content/browser/streams/stream_unittest.cc
[add] https://crrev.com/2ecb30baac7eed72a9729e0f7cdf84fe8cd7178d/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/respond-with-response-body-with-invalid-chunk-iframe.html
[add] https://crrev.com/2ecb30baac7eed72a9729e0f7cdf84fe8cd7178d/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/respond-with-response-body-with-invalid-chunk-worker.js
[add] https://crrev.com/2ecb30baac7eed72a9729e0f7cdf84fe8cd7178d/third_party/WebKit/LayoutTests/http/tests/serviceworker/respond-with-response-body-with-invalid-chunk.html

Comment 2 by yhirano@chromium.org, Jul 21 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment