New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627040 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird overlapping of shelf options are seen while creating supervised user

Project Member Reported by sc00335...@techmahindra.com, Jul 11 2016

Issue description

Version: 54.0.2792.0/8573.0.0 (Official Build) dev-channel Gnawty, Peppy, Daisy
OS: Chrome

What steps will reproduce the problem?
(1) Sign in to user[Say User1] >> Change shelf alignment as left/right >> Sign out of profile
(2) Click on 3 dot menu >> Add supervised user >> Click create supervised user >> Now sign in with previous profile[here User1] >> Now observe shelf position and items in suoervised user creation page
(3) Now hit ctrl+shift+reload to rotate the screen >> Repeat it 3 more times to bring it back to normal position and observe shelf items

Expected: No overlapping of shelf items should be seen.
Actual: Instead weird overlapping is seen when user changes shelf alignment in main profile.

This is a regression issue.

Suspecting https://codereview.chromium.org/2129013002 -- Please refer https://bugs.chromium.org/p/chromium/issues/detail?id=606264#c13

@warx: Please confirm the issue
 
Actual_when left.png
1.0 MB View Download
Actual_when right shelf position.png
1017 KB View Download
Able to reproduce the issue on chrome(Peppy) using Version: 54.0.2792.0/8573.0.0 . Observed the shelf is getting overlapped by following steps provided in the original comment.

Comment 2 by warx@chromium.org, Jul 11 2016

Status: Started (was: Assigned)
Yes, observe it. Will start to fix this.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdf7241b6babfab7e3c1970c508ba43a306a3b47

commit bdf7241b6babfab7e3c1970c508ba43a306a3b47
Author: warx <warx@chromium.org>
Date: Wed Jul 13 05:27:13 2016

Fix overlapping of shelf options on supervised user creation page when rotating screen

BUG= 627040 
TEST=manual test saw bug fixed

Review-Url: https://codereview.chromium.org/2137083004
Cr-Commit-Position: refs/heads/master@{#405045}

[modify] https://crrev.com/bdf7241b6babfab7e3c1970c508ba43a306a3b47/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc

Comment 4 by warx@chromium.org, Jul 13 2016

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdf7241b6babfab7e3c1970c508ba43a306a3b47

commit bdf7241b6babfab7e3c1970c508ba43a306a3b47
Author: warx <warx@chromium.org>
Date: Wed Jul 13 05:27:13 2016

Fix overlapping of shelf options on supervised user creation page when rotating screen

BUG= 627040 
TEST=manual test saw bug fixed

Review-Url: https://codereview.chromium.org/2137083004
Cr-Commit-Position: refs/heads/master@{#405045}

[modify] https://crrev.com/bdf7241b6babfab7e3c1970c508ba43a306a3b47/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc

Status: Verified (was: Fixed)
Chrome Os 54.0.2826.0/8697.0.0 samus

Sign in to add a comment