webkit tests in WebKit Win7 are failing since skia roll in builds/43981 |
|||||||
Issue descriptionThe CL that broke this is https://codereview.chromium.org/2132913005 (Revision 999b9be76daa36be3be485ee13ba09cf484ffd16 on master) On WebKit Win7 webkit_tests: virtual/gpu-rasterization/fast/images/jpeg-with-color-profile.html is failing since https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43981 Same on WebKit Win10 since https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/12260 Same on WebKit Mac https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/3084 Same on WebKit Mac 10.11 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/3084 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/6817 Same on WebKit Mac 10.10 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/20344 Same on WebKit Mac 10.9 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/34254
,
Jul 11 2016
Start Reverting all skia rolls until https://codereview.chromium.org/2132913005 (including this one)
,
Jul 11 2016
,
Jul 11 2016
,
Jul 11 2016
,
Jul 11 2016
,
Jul 11 2016
I stopped the reverting madness after talking to Matt Sarett. A fix for the layout tests should be in soon.
,
Jul 11 2016
Florin is landing a rebaseline. Should turn the tree green and the next roll should succeed.
,
Jul 11 2016
Issue 627000 has been merged into this issue.
,
Jul 11 2016
Suppressions landed: https://codereview.chromium.org/2140593002/ @markusheintz AFAIK layout tests are not tree-closing, and minor diffs used to be handled via suppression + bug. Has this changed/why revert the Skia roll?
,
Jul 11 2016
Sorry I was a bit unsure Since it was clear which CL caused this I decided revert the CL. No other particular reason
,
Jul 11 2016
Thanks. No worries, I just wanted to make sure we're not missing some change in layout tests failure handling. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by markusheintz@chromium.org
, Jul 11 2016