Merge to M53: Poor bandwidth when switching from video to screen sharing |
|||
Issue descriptionMin transmit bitrate, needed for good bandwidth estimates when screen sharing, got broken in a refactoring. This fix needs to be merged to the 53 branch. Fix was landed in tot here: https://chromium.googlesource.com/external/webrtc/+/9c0b55142533ebfa20836609777aa7f3681cadbe Verified in Canary (54.0.2790.0)
,
Jul 15 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 15 2016
Sorry, probably missed the chromium: prefix when referring to this bug. Merge has landed: The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/fdc2e3d5e7cae51920159b4e11410b8a92687623 commit fdc2e3d5e7cae51920159b4e11410b8a92687623 Author: Erik Språng Date: Tue Jul 12 08:00:55 2016 Merge to 53 branch: Fix bug where min transmit bitrate wasn't working A recent refactoring (r13192) introduced a bug where the min transmit config wasn't being respected. Specifically, if a VideoSendStream was created without it and the reconfigured, the min transmit bitrate would not take effect. Probably the other way around as well. TBR=tommi@webrtc.org BUG= webrtc:5687 , webrtc:6080 , 627017 patch from issue 2106183002 (http://crrev.com/2106183002) Review URL: https://codereview.webrtc.org/2123203002 . Cr-Commit-Position: refs/branch-heads/53@{#2} Cr-Branched-From: 65f47275cbb5ad3aa5146b9e75afa9894467daff-refs/heads/master@{#13317} [modify] https://crrev.com/fdc2e3d5e7cae51920159b4e11410b8a92687623/webrtc/call.h [modify] https://crrev.com/fdc2e3d5e7cae51920159b4e11410b8a92687623/webrtc/call/call.cc [modify] https://crrev.com/fdc2e3d5e7cae51920159b4e11410b8a92687623/webrtc/video/video_send_stream.cc [modify] https://crrev.com/fdc2e3d5e7cae51920159b4e11410b8a92687623/webrtc/video/video_send_stream_tests.cc
,
Jul 15 2016
Please merge your change to M53 branch 2785 ASAP (latest by 4:00 PM PST on Monday, 07/18) in order to make it to M53 dev release next week before Beta promotion.
,
Jul 15 2016
Per comment #3, this is already merged to M53 branch, So removing "Merge-Approved-53" label. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dimu@google.com
, Jul 12 2016