New issue
Advanced search Search tips

Issue 627008 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 508734
issue 618366
issue 625836



Sign in to add a comment

wpt_automation doesn't work with WPTServe

Project Member Reported by falken@chromium.org, Jul 11 2016

Issue description

Comment 1 by falken@chromium.org, Jul 11 2016

Blocking: 612924
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/762c2ebcfc987fd8e74d06b695ed60c1e8187d37

commit 762c2ebcfc987fd8e74d06b695ed60c1e8187d37
Author: falken <falken@chromium.org>
Date: Mon Jul 11 09:00:38 2016

WPTServeExpectations: Add failing pointerevents tests.

BUG= 627008 
TBR=nzolghadr

Review-Url: https://codereview.chromium.org/2137923002
Cr-Commit-Position: refs/heads/master@{#404618}

[modify] https://crrev.com/762c2ebcfc987fd8e74d06b695ed60c1e8187d37/third_party/WebKit/LayoutTests/WPTServeExpectations

falken@ can you me a little background here. What is --enable-wptserver suppose to do? I seem to be able to get the tests pass on my Linux when I run run-webkit-tests script with --enable-wptserver without timeout. Is that any other way to run this option or something else?

Comment 4 by falken@chromium.org, Jul 12 2016

Blocking: 508734
The flag is --enable-wptserve (not server). See  issue 618366  for more info. This runs the WPT HTTP server rather than Blink's Apache server. The goal is eventually make --enable-wptserve the default flag.

Of course, this is just an FYI bot for now though.


Blocking: -612924 625836
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84f2e1094a5c68772871d4a15e4609d2a1ede90e

commit 84f2e1094a5c68772871d4a15e4609d2a1ede90e
Author: qyearsley <qyearsley@chromium.org>
Date: Mon Jul 25 22:33:59 2016

Update WPTServeExpectations to reflect current failures and timeouts.

BUG= 508725 , 627008 

Review-Url: https://codereview.chromium.org/2175383002
Cr-Commit-Position: refs/heads/master@{#407617}

[modify] https://crrev.com/84f2e1094a5c68772871d4a15e4609d2a1ede90e/third_party/WebKit/LayoutTests/WPTServeExpectations

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e545801f65331c0f1481dd8cc9e567d2380b84ba

commit e545801f65331c0f1481dd8cc9e567d2380b84ba
Author: falken <falken@chromium.org>
Date: Fri Sep 09 06:33:56 2016

WPTServeExpectations: Add failing pointerevents tests

BUG= 627008 
TBR=jsbell

Review-Url: https://codereview.chromium.org/2320963003
Cr-Commit-Position: refs/heads/master@{#417519}

[modify] https://crrev.com/e545801f65331c0f1481dd8cc9e567d2380b84ba/third_party/WebKit/LayoutTests/WPTServeExpectations

Cc: falken@chromium.org jsb...@chromium.org rbyers@chromium.org
falken@
We did some script injection in testharnessreport.js with some absolute paths. How should we change that to fix serving those with wptserve option? Note that the path to the automation scripts is also out of wpt folder.
Here is the CL that added it:
https://codereview.chromium.org/1994683004/


Comment 9 by falken@chromium.org, Sep 12 2016

nzolghadr@: I'm afraid I don't know (I'm not a wptserve expert, but am interested in keeping the bot green because service worker tests will run on this FYI bot).
Cc: tkent@chromium.org
tkent@ do you know how we can achieve this use case I mentioned in comment #8 via wptserve or do you know someone who might know?

Comment 11 by tkent@chromium.org, Sep 13 2016

I think with wptserve a test URL is something like "https?://hostname/pointerevents/...".  We need two different handling for "file:///..../imported/wpt/pointerevents/..." and "https?://hostname/pointerevents/...".

Labels: Hotlist-Input-Dev
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16ae64988afdf04a385075df956ce538b56f0754

commit 16ae64988afdf04a385075df956ce538b56f0754
Author: tkent <tkent@chromium.org>
Date: Fri Oct 07 12:50:47 2016

Update WPTServeExpectations.

This CL has no behaivor changes.

BUG= 653859 ,  508728 ,  627008 ,  508725 
TBR=kojii@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2399363002
Cr-Commit-Position: refs/heads/master@{#423841}

[modify] https://crrev.com/16ae64988afdf04a385075df956ce538b56f0754/third_party/WebKit/LayoutTests/WPTServeExpectations

Comment 14 by tkent@chromium.org, Oct 13 2016

Blocking: 618366
I did some investigation.

If a test is served via http://, we can't use file:/// for wpt_automation scripts.  This restriction is implemented in both of Blink and Chromium.  So bypassing the restriction isn't easy.

We need to serve wpt_automation scripts via http. "serve" command of WPTServe doesn't have a flag / configuration to add URL:directory mapping for now.

A) Call RoutesBuilder.add_mount_point() in serve.py somehow.
B) Run another http server for wpt_automation


Comment 15 by tkent@chromium.org, Oct 18 2016

Summary: wpt_automation doesn't work with WPTServe (was: Many imported/wpt/pointerevents test timeout under WPTServe)

Comment 16 by tkent@chromium.org, Oct 20 2016

Components: Blink>Infra
I'm trying approach A in #c14.
https://github.com/w3c/wpt-tools/pull/128

Comment 17 by tkent@chromium.org, Oct 25 2016

Cc: nzolghadr@chromium.org
Owner: tkent@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9

commit a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9
Author: tkent <tkent@chromium.org>
Date: Tue Oct 25 20:52:04 2016

wptserve: Import the latest revision of wptserve-related files.

This revision of 'serve' command has an 'alias' feature, which helps to inject
imported/wpt_automation/.
https://github.com/w3c/wpt-tools/commit/9dc91ab4e181595e074a1dbb1408c84f80367896

This CL doesn't affect production, and doesn't affect main layout test bots.

BUG= 627008 

Review-Url: https://codereview.chromium.org/2448913002
Cr-Commit-Position: refs/heads/master@{#427461}

[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/README.chromium
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTHeads
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/.gitignore
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/__init__.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/localpaths.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/serve.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/sslutils/openssl.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/README.md
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/__init__.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/constants.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/handlers.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/pipes.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/ranges.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/request.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/response.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/router.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/routes.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/server.py
[modify] https://crrev.com/a4ea25c8efbc8157fca7a36f4c4f031ce73bc0d9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/stash.py

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4c1192626a5d180457403d2c97ebf5232ddfb81

commit b4c1192626a5d180457403d2c97ebf5232ddfb81
Author: tkent <tkent@chromium.org>
Date: Fri Nov 04 00:00:49 2016

wptserve: Import the latest revision of wptserve-related files.

This revision contains fixes for the 'alias' feature.

* Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
  - Show the HEAD revision.  It is helpful if WPTHeads contains "master"s to
    check out.
  - Add a workaround of a bug of xargs on macOS.

This CL doesn't affect production, and doesn't affect main layout test bots.

BUG= 627008 

Review-Url: https://codereview.chromium.org/2476653002
Cr-Commit-Position: refs/heads/master@{#429733}

[modify] https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/README.chromium
[modify] https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTHeads
[modify] https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
[modify] https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/config.default.json
[modify] https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/serve.py
[modify] https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/serve.py
[modify] https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/handlers.py
[modify] https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/pipes.py
[modify] https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/request.py
[modify] https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/server.py

Project Member

Comment 21 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35e60781345021466f84a7a80ac928fd48c90441

commit 35e60781345021466f84a7a80ac928fd48c90441
Author: tkent <tkent@chromium.org>
Date: Fri Nov 04 07:49:23 2016

Revert of wptserve: Import the latest revision of wptserve-related files. (patchset #1 id:1 of https://codereview.chromium.org/2476653002/ )

Reason for revert:
Broke WPTServe bots on Linux and Windows

Original issue's description:
> wptserve: Import the latest revision of wptserve-related files.
>
> This revision contains fixes for the 'alias' feature.
>
> * Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
>   - Show the HEAD revision.  It is helpful if WPTHeads contains "master"s to
>     check out.
>   - Add a workaround of a bug of xargs on macOS.
>
> This CL doesn't affect production, and doesn't affect main layout test bots.
>
> BUG= 627008 
>
> Committed: https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81
> Cr-Commit-Position: refs/heads/master@{#429733}

TBR=qyearsley@chromium.org,jsbell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 627008 

Review-Url: https://codereview.chromium.org/2478073002
Cr-Commit-Position: refs/heads/master@{#429826}

[modify] https://crrev.com/35e60781345021466f84a7a80ac928fd48c90441/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/README.chromium
[modify] https://crrev.com/35e60781345021466f84a7a80ac928fd48c90441/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTHeads
[modify] https://crrev.com/35e60781345021466f84a7a80ac928fd48c90441/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
[modify] https://crrev.com/35e60781345021466f84a7a80ac928fd48c90441/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/config.default.json
[modify] https://crrev.com/35e60781345021466f84a7a80ac928fd48c90441/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/serve.py
[modify] https://crrev.com/35e60781345021466f84a7a80ac928fd48c90441/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/serve.py
[modify] https://crrev.com/35e60781345021466f84a7a80ac928fd48c90441/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/handlers.py
[modify] https://crrev.com/35e60781345021466f84a7a80ac928fd48c90441/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/pipes.py
[modify] https://crrev.com/35e60781345021466f84a7a80ac928fd48c90441/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/request.py
[modify] https://crrev.com/35e60781345021466f84a7a80ac928fd48c90441/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/server.py

Project Member

Comment 22 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d7e23486505195a285779acc74af898a17c97d2

commit 6d7e23486505195a285779acc74af898a17c97d2
Author: falken <falken@chromium.org>
Date: Fri Nov 04 10:50:46 2016

Gardening: update WPTServeExpectations

BUG= 508728 , 508725 , 627008 

Review-Url: https://codereview.chromium.org/2475263002
Cr-Commit-Position: refs/heads/master@{#429851}

[modify] https://crrev.com/6d7e23486505195a285779acc74af898a17c97d2/third_party/WebKit/LayoutTests/WPTServeExpectations

Project Member

Comment 23 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e

commit e6af5663ca3c637cc6b0ff9577fc53862d24bf5e
Author: tkent <tkent@chromium.org>
Date: Sat Nov 05 18:25:21 2016

wptserve: Import the latest revision of wptserve-related files.

This revision contains fixes for the 'alias' feature.

* Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/six/
  New third-party code. WPTServe depends on it.

* Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
  - Show the HEAD revision.  It is helpful if WPTHeads contains "master"s to
    check out.
  - Add a workaround of a bug of xargs on macOS.

This CL doesn't affect production, and doesn't affect main layout test bots.

BUG= 627008 

Committed: https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81
Review-Url: https://codereview.chromium.org/2476653002
Cr-Original-Commit-Position: refs/heads/master@{#429733}
Cr-Commit-Position: refs/heads/master@{#430172}

[modify] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/README.chromium
[modify] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTHeads
[modify] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList
[modify] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
[modify] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/config.default.json
[modify] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/serve.py
[modify] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/serve.py
[add] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/six/CHANGES
[add] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/six/CONTRIBUTORS
[add] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/six/LICENSE
[add] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/six/README
[add] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/six/six.py
[modify] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/handlers.py
[modify] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/pipes.py
[modify] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/request.py
[modify] https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/server.py

Project Member

Comment 24 by bugdroid1@chromium.org, Nov 6 2016

Status: Fixed (was: Started)

Sign in to add a comment