New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 626996 link

Starred by 3 users
Status: Fixed
Owner:
█ lshang@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [MD-History] Forward slash key is not working in ‘chrome://history/' search field.

Reported by dmascare...@etouch.net, Jul 11 2016 
Chrome Version: 54.0.2793.0 (Official Build) 6667812b2dffe3f6bf794b2b040504e5a3ad7cb7-refs/heads/master@{#404564} (32/64 bit)
OS :Windows (7,8,8.1,10), Linux(14.04 LTS) and Mac(10.10.5, 10.11.4)

Pr-condition: 1. Enable Material Design history flag from chrome://flags. 

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://history page.
2. Click on Search field and press ‘Forward slash’ key from keyboard,observe.

Actual: Forward slash key is not workable on search field.
Expected: Forward slash key should work on search field.

This is regression issue, broken in ‘M 54’ and will soon update the bisect info.

Good build:54.0.2791.0
Bad build:54.0.2793.0

Comment 1 by dmascare...@etouch.net, Jul 11 2016

Labels: hasbisect
Owner: lshang@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/2dfd4ba707f617a44641c4e732ec986a331b4618..9c9a2b8dde4e141db7fb814f9ff338927741e7c1?pretty=fuller&n=1000

Suspecting: r404329

Note: ‘Ctrl-f’ and ‘Cmd-f’ both shortcuts keys are giving same end result (i.e. redirecting search field) for Mac OS.
Actual_history.mov
1.3 MB Download
exp_history.mov
1.8 MB Download

Comment 2 by msrchandra@chromium.org, Jul 11 2016

Labels: ReleaseBlock-Stable
Able to reproduce the issue on Windows, Mac and Linux. So adding RB Label as this is a Recent Regression. Please remove if not required.
Thank You.

Comment 3 by tsergeant@chromium.org, Jul 12 2016

Labels: -ReleaseBlock-Stable Proj-MaterialDesign-WebUI
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f503cf604552d4a7e1e184575609bf632f40dd22

commit f503cf604552d4a7e1e184575609bf632f40dd22
Author: lshang <lshang@chromium.org>
Date: Wed Jul 20 00:18:11 2016

MD History: Fix forward slash key not working in search field

We previously added a shortcut of forward slash key to open and focus the search
field, but in this way when user inputs slash again it will be regarded as a
shortcut, not a normal input.

This CL fixes this by adding a check in onCanExecute(), if the search field is
already opened, then the shortcut command can not be executed so that the
forward slash key is regarded as normal input as search term.

BUG= 626996 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2152753003
Cr-Commit-Position: refs/heads/master@{#406425}

[modify] https://crrev.com/f503cf604552d4a7e1e184575609bf632f40dd22/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/f503cf604552d4a7e1e184575609bf632f40dd22/chrome/browser/resources/md_history/history.html
[modify] https://crrev.com/f503cf604552d4a7e1e184575609bf632f40dd22/chrome/browser/resources/md_history/history_toolbar.js
[modify] https://crrev.com/f503cf604552d4a7e1e184575609bf632f40dd22/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js
[modify] https://crrev.com/f503cf604552d4a7e1e184575609bf632f40dd22/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

Comment 5 by lshang@chromium.org, Jul 21 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment