New issue
Advanced search Search tips

Issue 626995 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Crash in chromeos::SystemTrayDelegateChromeOS::GetBluetoothAvailable

Project Member Reported by ClusterFuzz, Jul 11 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4606728557821952

Fuzzer: meacer_chromebot_extensions
Job Type: linux_asan_chrome_chromeos
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  chromeos::SystemTrayDelegateChromeOS::GetBluetoothAvailable
  ash::tray::BluetoothDefaultView::UpdateLabel
  ash::TrayBluetooth::CreateDefaultView
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_chromeos&range=400508:400530

Minimized Testcase (59.87 Kb): https://cluster-fuzz.appspot.com/download/AMIfv973CYNHsisFUMt821J0qY3rmw6i2jqzqhTtx8FsYRvI6wSs6KMFSBwVc3jnU6bSQsWdwzWtKT1TUr9yHe9FLhZQCTv14VlNfZISshJsLoXAVKGuZyZlXuOX_IxXc8C45dJaMdZCsZWM_uNYxZGTUSz156tQa1-w7YjRo42ZXvbhkcNUnC4?testcase_id=4606728557821952

Additional requirements: Requires Gestures

Filer: nyerramilli

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: nyerramilli@chromium.org
Components: Tools>Test>FindIt>WrongResult
Labels: findit-wrong Te-Logged
Owner: msw@chromium.org
Status: Assigned (was: Available)
providing findit results for internal purpose:

Suspected CLs	No CL in the regression range changes the crashed files. The result is the blame information.

Author: alemate@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/be0d312bf397dfd4e3ca89e39a234cf3c1af7657
Time: Mon Feb 10 15:29:42 2014
The CL last changed line 760 of file system_tray_delegate_chromeos.cc, which is stack frame 0.

Author: alemate@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/be0d312bf397dfd4e3ca89e39a234cf3c1af7657
Time: Mon Feb 10 15:29:42 2014
The CL last changed line 759 of file system_tray_delegate_chromeos.cc, which is stack frame 1.

Author: jennyz@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/c97392324c949f2860d4427e9e6bf7eed529845f
Time: Fri Apr 27 00:16:16 2012
The CL last changed line 79 of file tray_bluetooth.cc, which is stack frame 2.

Author: sadrul@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/8d78ad0e7d7ffbc78b7d18626f005e6ac9bc8c54
Time: Wed Mar 21 18:10:47 2012
The CL last changed line 72 of file tray_bluetooth.cc, which is stack frame 3.

Author: sky
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/e79274a529e13ea233610f6359fbbbf8cb361db6
Time: Wed Jun 08 05:39:02 2016
The CL last changed line 412 of file tray_bluetooth.cc, which is stack frame 4.

Author: jennyz@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/920746f79e174896f8cc183e83d022376697c961
Time: Thu Dec 06 06:36:03 2012
The CL last changed line 291 of file system_tray_bubble.cc, which is stack frame 5.

Author: stevenjb@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/3aa2af1405080fe877fac76540f3a4f522302d19
Time: Wed Aug 01 18:06:53 2012
The CL last changed line 194 of file system_tray_bubble.cc, which is stack frame 6.

Suspected Project: chromium

using codesearch, seeing some changes to 'system_tray_delegate_chromeos.cc' in https://chromium.googlesource.com/chromium/src/+/0414d41295a36b35a9fca54a993b0b56a60ddacf

msw@, Could you please take a look at the issue and assign it to concerned developer if your changes are not responsible?

Comment 2 by msw@chromium.org, Jul 11 2016

Owner: infe...@chromium.org
My changed cited above seems completely irrelevant to this crash.
Also, I can't access the 'Minimized Testcase' link; instead I get:

You () are not authorized to access this page!

For access, please contact Abhishek Arya (inferno [at] chromium [dot] org). If you are trying to access the testcase for a bug, make sure that you are marked as Owner.

If you see this error while trying to download a test case for a bug that you are the owner of, please download it from the test case details page.


... I was the owner, and I don't know how to access the "test case details page" ...
Owner: msw@chromium.org
Try going to cluster-fuzz.appspot.com first, sign on with your @chromium.org account and then try https://cluster-fuzz.appspot.com/testcase?key=4606728557821952
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90f0ec2148047357ea4f846d2bdb4496accaa61d

commit 90f0ec2148047357ea4f846d2bdb4496accaa61d
Author: msw <msw@chromium.org>
Date: Wed Jul 20 04:34:10 2016

Fix bluetooth adapter access in SystemTrayDelegateChromeOS.

Check for null adapter in SystemTrayDelegateChromeOS.
Add a SystemTrayDelegateChromeOS unit test.
(the test fails without the new null checks)

Add BrowserProcessPlatformPart::DestroySystemClock.
(needed to destroy CrosSettings::ObserverSubscription)

BUG= 626995 
TEST=New unit test; fewer crashes; no behavior changes.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2166503003
Cr-Commit-Position: refs/heads/master@{#406490}

[modify] https://crrev.com/90f0ec2148047357ea4f846d2bdb4496accaa61d/chrome/browser/browser_process_platform_part_chromeos.cc
[modify] https://crrev.com/90f0ec2148047357ea4f846d2bdb4496accaa61d/chrome/browser/browser_process_platform_part_chromeos.h
[modify] https://crrev.com/90f0ec2148047357ea4f846d2bdb4496accaa61d/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/90f0ec2148047357ea4f846d2bdb4496accaa61d/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
[add] https://crrev.com/90f0ec2148047357ea4f846d2bdb4496accaa61d/chrome/browser/ui/ash/system_tray_delegate_chromeos_unittest.cc
[modify] https://crrev.com/90f0ec2148047357ea4f846d2bdb4496accaa61d/chrome/chrome_tests_unit.gypi

Comment 5 by msw@chromium.org, Jul 20 2016

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e64f73149ae4f997113777bc9cf3de8f5ab00e56

commit e64f73149ae4f997113777bc9cf3de8f5ab00e56
Author: msw <msw@chromium.org>
Date: Wed Jul 20 20:21:08 2016

Remove redundant SystemTrayDelegateChromeOSTest.BluetoothStatus test.

Remove the browser test added in codereview.chromium.org/2166503003
That CL also adds a unit test with the same exact checks.

BUG= 626995 
TEST=NONE
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2171483002
Cr-Commit-Position: refs/heads/master@{#406653}

[modify] https://crrev.com/e64f73149ae4f997113777bc9cf3de8f5ab00e56/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc

Project Member

Comment 7 by ClusterFuzz, Jul 21 2016

ClusterFuzz has detected this issue as fixed in range 406477:406549.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4606728557821952

Fuzzer: meacer_chromebot_extensions
Job Type: linux_asan_chrome_chromeos
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  chromeos::SystemTrayDelegateChromeOS::GetBluetoothAvailable
  ash::tray::BluetoothDefaultView::UpdateLabel
  ash::TrayBluetooth::CreateDefaultView
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_chromeos&range=400508:400530
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_chromeos&range=406477:406549

Minimized Testcase (59.87 Kb): https://cluster-fuzz.appspot.com/download/AMIfv973CYNHsisFUMt821J0qY3rmw6i2jqzqhTtx8FsYRvI6wSs6KMFSBwVc3jnU6bSQsWdwzWtKT1TUr9yHe9FLhZQCTv14VlNfZISshJsLoXAVKGuZyZlXuOX_IxXc8C45dJaMdZCsZWM_uNYxZGTUSz156tQa1-w7YjRo42ZXvbhkcNUnC4?testcase_id=4606728557821952

Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Components: -Tools>Test>FindIt>WrongResult
Labels: Test-Predator-Wrong
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment