MD Settings: Ensure all drop-down options are selectable using "Enter" key.
Reported by
yfulgaon...@etouch.net,
Jul 11 2016
|
||||||||
Issue descriptionChrome version : 54.0.2793.0 (Official Build) 6667812b2dffe3f6bf794b2b040504e5a3ad7cb7-refs/heads/master@{#404564} (32/64 bit) OS : Windows (7,8,8.1,10), Linux(14.04 LTS) and Mac(10.10.5, 10.11.4) What steps will reproduce the problem? 1) Launch chrome and go to chrome://md-settings. 2) Click on 'Font size' drop down list and press down arrow key to highlight the next item in drop down list. 3) Hit Enter key and observe. Actual : Unable to select an option from drop down list using Enter key. Expected : User should be able to select an option from drop down list using Enter key. This is a regression issue broken in 'M-53', below is the Manual regression and Narrow Bisect info: Good Build : 53.0.2784.0 Bad Build : 53.0.2785.0 Narrow Bisect : https://chromium.googlesource.com/chromium/src/+log/840bb0f5eda052f9d0da148ced3a04610c4dc02d..084aec7f79d92169449f435c51aa6f562413b323?pretty=fuller&n=10000 Suspecting : r403366 ? from Narrow Bisect. Note : 1) The same issue is also seen for 'Page zoom' and 'Search Engine' drop down list in chrome://md-settings.
,
Jul 11 2016
This is indeed caused by https://chromium.googlesource.com/chromium/src/+/d516b7a2c3b7c11aedd23522b34e6cfbb7916df5. @michaelpg: The change from <paper-item> to <div> inside the <paper-dropdown-menu> caused the selection to not change when hitting the "Enter" key. Do you have any suggestions on how to fix (while still using <div>s)?
,
Jul 11 2016
,
Jul 12 2016
,
Jul 12 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12 2016
@michaelpg: This regression can be fixed by changing <div class="dropdown-item"> with <button> (and tweaking the style a bit), see https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/controls/settings_dropdown_menu.html?l=21,23. I recall you also had a PR that was adding the paper-item CSS class, which was meant to land soon. What do you think about going forward with the proposed fix? Should we wait until your paper-item PR lands instead?
,
Jul 12 2016
Looking at my PR to see if we can land a fix that works for everyone.
,
Jul 12 2016
I've commented on the paper-item issue: https://github.com/PolymerElements/paper-item/issues/85#issuecomment-232207944 I do not know why a fix that used to work now *hides the focused item* in shady DOM, and frankly it doesn't seem like our job to investigate.
,
Jul 13 2016
,
Jul 14 2016
r405374 fixes the issue for <settings-dropdown-menu> (somehow the bug was not automatically updated). I am going to re-purpose this bug to be slightly more generic.
,
Jul 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ada53fa9511af7324edad932dacd5157a70891b9 commit ada53fa9511af7324edad932dacd5157a70891b9 Author: dpapad <dpapad@chromium.org> Date: Fri Jul 15 18:01:02 2016 MD Settings: Fix search engines drop-down menu. The same change fixes two issues. 1) No more showing of unnecessary horizontal scrollbar. 2) Allow using "Enter" key to change dropdown selection. BUG= 628499 , 626989 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2148793007 Cr-Commit-Position: refs/heads/master@{#405789} [modify] https://crrev.com/ada53fa9511af7324edad932dacd5157a70891b9/chrome/browser/resources/settings/search_page/search_page.html
,
Jul 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb3837ca9b2cf9f46f0559f4782743ea5cb384d0 commit bb3837ca9b2cf9f46f0559f4782743ea5cb384d0 Author: dpapad <dpapad@chromium.org> Date: Fri Jul 15 21:51:53 2016 MD Settings: Use <button class="dropdown-item"> for drop-down options. BUG= 626989 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2151383002 Cr-Commit-Position: refs/heads/master@{#405869} [modify] https://crrev.com/bb3837ca9b2cf9f46f0559f4782743ea5cb384d0/chrome/browser/resources/settings/device_page/display.html [modify] https://crrev.com/bb3837ca9b2cf9f46f0559f4782743ea5cb384d0/chrome/browser/resources/settings/site_settings/media_picker.html [modify] https://crrev.com/bb3837ca9b2cf9f46f0559f4782743ea5cb384d0/chrome/browser/resources/settings/site_settings/site_data_details_dialog.html [modify] https://crrev.com/bb3837ca9b2cf9f46f0559f4782743ea5cb384d0/chrome/browser/resources/settings/site_settings/site_details_permission.html
,
Jul 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2455d1b15817d96a2d1b673ef01f945565ccf0e5 commit 2455d1b15817d96a2d1b673ef01f945565ccf0e5 Author: dpapad <dpapad@chromium.org> Date: Sat Jul 16 02:37:05 2016 MD Settings: Replace paper-item with button under passwords_and_forms_page/. BUG= 626989 , 602896 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2153243002 Cr-Commit-Position: refs/heads/master@{#405924} [modify] https://crrev.com/2455d1b15817d96a2d1b673ef01f945565ccf0e5/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html [modify] https://crrev.com/2455d1b15817d96a2d1b673ef01f945565ccf0e5/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html [modify] https://crrev.com/2455d1b15817d96a2d1b673ef01f945565ccf0e5/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js [modify] https://crrev.com/2455d1b15817d96a2d1b673ef01f945565ccf0e5/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
,
Jul 19 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by msrchandra@chromium.org
, Jul 11 2016