New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626980 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 623669
Owner:
Email to this user bounced
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Crash in SkPixelRef::SkPixelRef

Project Member Reported by ClusterFuzz, Jul 11 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6106013157818368

Fuzzer: sugoi_filter_fuzzer
Job Type: linux_asan_filter_fuzz_stub_32bit
Platform Id: linux

Crash Type: UNKNOWN WRITE
Crash Address: 0x00000004
Crash State:
  SkPixelRef::SkPixelRef
  SkMallocPixelRef::NewAllocate
  SkMallocPixelRef::PRFactory::create
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_filter_fuzz_stub_32bit&range=344473:344607

Minimized Testcase (0.30 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95izSHXzX6ievRBq4kRsUZNSc18ossarmH2IVWYtirGAj5XgQypBkKl3Hcd9DCGtRXHdLeTWkDL9udkWDP427oL84iF6AmaiX7-ws16oMTnYARp88bj0oxbbJCZ6X0WkkPuf0QCzLU1SzgTbumjlNIytf_ozA?testcase_id=6106013157818368

Filer: nyerramilli

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: nyerramilli@chromium.org bsalomon@chromium.org
Components: Tools>Test>FindIt>WrongResult
Labels: findit-wrong Te-Logged M-52
Owner: reed@chromium.org
Status: Assigned (was: Available)
logging this for tracking purpose -

providing findit results for internal purpose:
Suspected CLs	No CL in the regression range changes the crashed files. The result is the blame information.

Author: scroggo
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/f3ca41c723f3a33a766de64a1cda9a01bab20142
Time: Tue Nov 25 21:42:12 2014
The CL last changed line 49 of file SkPixelRef.cpp, which is stack frame 0.

Author: halcanary@google.com
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/1bed687f6b8fc67336f0f5d6fb5a5b38dd0fdff9
Time: Thu Jan 02 17:29:28 2014
The CL last changed line 170 of file SkMallocPixelRef.cpp, which is stack frame 1.

Author: halcanary
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/96fcdcc219d2a0d3579719b84b28bede76efba64
Time: Thu Aug 27 14:41:13 2015
The CL last changed line 87 of file SkMallocPixelRef.cpp, which is stack frame 2.

Author: mtklein
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/cd4954152490c7492284a7914571531ba8c75b4a
Time: Thu Nov 05 17:46:23 2015
The CL last changed line 94 of file SkMallocPixelRef.cpp, which is stack frame 3.

Author: reed
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/f0aed97aec3fa1c7f6460d8d6327358f3dcbabe6
Time: Tue Jul 01 19:48:11 2014
The CL last changed line 216 of file SkMallocPixelRef.cpp, which is stack frame 4.

Author: halcanary
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/96fcdcc219d2a0d3579719b84b28bede76efba64
Time: Thu Aug 27 14:41:13 2015
The CL last changed line 302 of file SkBitmap.cpp, which is stack frame 5.

Author: reed
Project: chromium-skia
Changelist: https://chromium.googlesource.com/skia.git/+/848250415eddc54075f7eb8795e8db79e749c6ab
Time: Tue Sep 02 19:50:45 2014
The CL last changed line 268 of file SkBitmap.h, which is stack frame 6.

Suspected Project: chromium-skia
Suspected Component: Internals>Skia

assigning to skia owners, reed@; bsalomon@ - Could you please take a look at the issue and assign it to concerned developer if your changes are not responsible?

Comment 2 by reed@google.com, Jul 11 2016

Cc: fmalita@chromium.org
Cc: mtklein@chromium.org
Seems related to  issue 623669  - new allocation returning nullptr?
Cc: mtkl...@google.com
Agreed.  Definitely looks like new isn't failing immediately.

Just in case this comes up, the problem does _not_ appear to be the non-throwing malloc call we made just before this... it's the new for the small pixel-ref struct managing that memory.
Mergedinto: 623669
Status: Duplicate (was: Assigned)
Let's merge these to track together.
Project Member

Comment 7 by ClusterFuzz, Aug 24 2016

ClusterFuzz has detected this issue as fixed in range 413737:413791.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6106013157818368

Fuzzer: sugoi_filter_fuzzer
Job Type: linux_asan_filter_fuzz_stub_32bit
Platform Id: linux

Crash Type: UNKNOWN WRITE
Crash Address: 0x00000004
Crash State:
  SkPixelRef::SkPixelRef
  SkMallocPixelRef::NewAllocate
  SkMallocPixelRef::PRFactory::create
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_filter_fuzz_stub_32bit&range=344473:344607
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_filter_fuzz_stub_32bit&range=413737:413791

Minimized Testcase (0.30 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95izSHXzX6ievRBq4kRsUZNSc18ossarmH2IVWYtirGAj5XgQypBkKl3Hcd9DCGtRXHdLeTWkDL9udkWDP427oL84iF6AmaiX7-ws16oMTnYARp88bj0oxbbJCZ6X0WkkPuf0QCzLU1SzgTbumjlNIytf_ozA?testcase_id=6106013157818368

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Components: -Tools>Test>FindIt>WrongResult
Labels: Test-Predator-Wrong
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment