New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626972 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 631145



Sign in to add a comment

Saving page on Linux always DCHECKS

Project Member Reported by dcheng@chromium.org, Jul 11 2016

Issue description

When trying to save http://www.androidauthority.com/google-photos-worried-privacy-616339/, I get this DCHECK:

[64915:64915:0711/125851:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO!  If this thread really should be allowed to make IO calls, a
djust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup.
#0 0x7fc223ee755e base::debug::StackTrace::StackTrace()
#1 0x7fc223f086ab logging::LogMessage::~LogMessage()
#2 0x7fc223f79220 base::ThreadRestrictions::AssertIOAllowed()
#3 0x7fc223f30512 base::nix::GetFileMimeType()
#4 0x7fc2237c2f80 net::PlatformMimeUtil::GetPlatformMimeTypeFromExtension()
#5 0x7fc2237b5078 net::MimeUtil::GetMimeTypeFromExtensionHelper()
#6 0x7fc2218b5a33 content::SavePackage::EnsureMimeExtension()
#7 0x7fc2218b576d content::SavePackage::GetSuggestedNameForSaveAs()
#8 0x7fc2218b609c content::SavePackage::GetSaveInfo()
#9 0x7fc221bc49e4 content::WebContentsImpl::OnSavePage()
#10 0x7fc225a89881 chrome::SavePage()
#11 0x7fc225a8699e chrome::BrowserCommandController::ExecuteCommandWithDisposition()
#12 0x7fc22610b26f CommandUpdater::ExecuteCommand()
#13 0x7fc225b26cee BrowserView::AcceleratorPressed()
#14 0x7fc222e7a8ba ui::AcceleratorManager::Process()
#15 0x7fc21f619603 views::FocusManager::ProcessAccelerator()
#16 0x7fc21f41f03b views::UnhandledKeyboardEventHandler::HandleKeyboardEvent()
#17 0x7fc221a49d05 content::InputRouterImpl::ProcessKeyboardAck()
#18 0x7fc221a49882 content::InputRouterImpl::ProcessInputEventAck()
#19 0x7fc221a485e1 content::InputRouterImpl::OnInputEventAck()
#20 0x7fc221a4839e _ZN3IPC8MessageTI38InputHostMsg_HandleInputEvent_ACK_MetaSt5tupleIJN7content13InputEventAckEEEvE8DispatchINS3_15InputRouterImplES8_vMS8_FvRKS4_EEEbPKNS_7MessageEPT_PT0_PT1
_T2_
#21 0x7fc221a48035 content::InputRouterImpl::OnMessageReceived()
#22 0x7fc221abc916 content::RenderWidgetHostImpl::OnMessageReceived()
#23 0x7fc221aab60f content::RenderProcessHostImpl::OnMessageReceived()
#24 0x7fc220c37895 IPC::ChannelProxy::Context::OnDispatchMessage()
#25 0x7fc223ee8749 base::debug::TaskAnnotator::RunTask()
#26 0x7fc223f13025 base::MessageLoop::RunTask()
#27 0x7fc223f13358 base::MessageLoop::DeferOrRunPendingTask()
#28 0x7fc223f1370b base::MessageLoop::DoWork()
#29 0x7fc223f156ea base::(anonymous namespace)::WorkSourceDispatch()
#30 0x7fc21dba8e04 g_main_context_dispatch
#31 0x7fc21dba9048 <unknown>
#32 0x7fc21dba90ec g_main_context_iteration
#33 0x7fc223f15436 base::MessagePumpGlib::Run()
#34 0x7fc223f12b21 base::MessageLoop::RunHandler()
#35 0x7fc223f41cd0 base::RunLoop::Run()
#36 0x7fc22539e02a ChromeBrowserMainParts::MainMessageLoopRun()
#37 0x7fc2217f74d9 content::BrowserMainLoop::RunMainMessageLoopParts()
#38 0x7fc2217fa7b8 content::BrowserMainRunnerImpl::Run()
#39 0x7fc2217f2fcc content::BrowserMain()
#40 0x7fc22216f3ab content::RunNamedProcessTypeMain()
#41 0x7fc22216fe23 content::ContentMainRunnerImpl::Run()
#42 0x7fc22216e6f0 content::ContentMain()
#43 0x7fc22494d91b ChromeMain
#44 0x7fc21af9af45 __libc_start_main
#45 0x7fc22494d7f9 <unknown>

 
Cc: asanka@chromium.org abw@chromium.org
+asanka@ and abw@ as they have discussed a similar FILE-IO-on-non-FILE-thread issue when talking about https://crbug.com/596953 (also - this is related to  issue 61827  and the TODO here: https://cs.chromium.org/chromium/src/content/browser/download/save_package.cc?rcl=0&l=1435 ).
Status: Started (was: Assigned)
3 CLs in-progress:
- fix proposal for this specific bug: https://crrev.com/2168403003/
- trying to enable io asserts for all content_browsertests: https://crrev.com/2175933002/
- trying to enable io asserts for all browser_tests: https://crrev.com/2178683002/

Comment 3 by dcheng@chromium.org, Jul 25 2016

 Issue 630948  has been merged into this issue.
Blocking: 631145
Status: fixed (was: Started)

Sign in to add a comment