New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626968 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

ec: consider addressing signed/unsigned warning comparison.

Project Member Reported by gwendal@chromium.org, Jul 11 2016

Issue description

Adding -Wsign-compare add a lot of warning.
They are mostly useless, but it would have help locate an issue where motion task period calculation was wrong, the task taking more time than the allowed.

Looking in the warning, using size_t in for index loop, adding U to constants (to fix errors in MIN and MAX) and other small changes would fix most of the warnings. Other needs more work.

Adding -Wsign-compare in final CFLAGS in Makefile.toolchain and using make -k to get all warnings.
-CFLAGS+= -fno-delete-null-pointer-checks -fconserve-stack
+CFLAGS+= -fno-delete-null-pointer-checks -fconserve-stack -Wsign-compare
 
error2
131 KB View Download
Owner: nvaccaro@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment