New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626950 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 609258



Sign in to add a comment

Figure out whether we should generate non-WebAPK web app when generating WebAPK fails

Project Member Reported by pkotw...@chromium.org, Jul 10 2016

Issue description

It is possible that generating a WebAPK fails. Some possible reasons why:
- User is offline
- Firewall blocks user's access to WebAPK server
- Bug in WebAPK server

When a user selects "Add to Homescreen" from app menu, the user is on a WebAPK compatible site and generating the WebAPK fails should we
- fall back to generating a non-WebAPK homescreen shortcut
- fail and display an infobar to alert the user
 
Cc: sbirch@chromium.org
according to Sam, you get a notification that it failed to add: https://docs.google.com/presentation/d/1QbHDigLFR1oucsnlXQ9f6AxQYYI6Ka0Gl0A_vWpFjSA/edit#slide=id.g151ff6cd34_0_323 (internal-only)
Blocking: 609258
I think that Sam's proposal is inconsistent with what we currently do with web apps. If we cannot add a "fullscreen home screen shortcut" we fall back to creating a "tabbed browser home screen shortcut"

If we cannot add a "WebAPK home screen shortcut" we should fall back to either a "fullscreen home screen shortcut" or a "tabbed browser home screen shortcut".

Comment 4 by sbirch@chromium.org, Jul 20 2016

I actually didn't realize that adding an A2HS locally could fail! But noted.

I looked into the data a little bit; I've summarized in this internal slide: https://docs.google.com/presentation/d/1QbHDigLFR1oucsnlXQ9f6AxQYYI6Ka0Gl0A_vWpFjSA/edit#slide=id.g151ff6cd34_0_323

Comment 5 by sbirch@chromium.org, Jul 20 2016

Aaand just realized that was the same slide Yaron linked to originally :)

I think the inconsistency is OK here -- users' mental model of apps is that you have to be online to install them. So in my mind failing with that explanation is clearer than silently adding a bookmark to your home screen.
Sam, will A2HS be able to create all three:
- A WebAPK
- A fullscreen non-WebAPK webapp
- A homescreen tabbed browser shortcut

The app banner only shows if the Web Manifest has a sufficiently large app icon. Currently A2HS generates a WebAPK if the Web Manifest does not have any app icon at all. Should A2HS keep on generating WebAPKs in this case? Should A2HS generate a "fullscreen non-WebAPK webapp instead?"

Currently A2HS creates "fullscreen non-WebAPK webapps" for sites which have <meta name="application-name">. However, the app banner does not show for sites which use <meta name="application-name">. Will we continue doing this or will these sites be downgraded to "tabbed browser shortcuts"?
Cc: dominickn@chromium.org
FYI: dominickn@

Sign in to add a comment