New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626945 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add NavigationToFirstContentfulPaint for DocWrite.Block

Project Member Reported by bmcquade@chromium.org, Jul 10 2016

Issue description

We have ParseStartToFirstContentfulPaint for DocWrite.Block, which is useful for understanding the exact impact of the change on the perios from parse start to FCP, but it's also important to measure the overall time from navigation to FCP. We should add a second metric to track this overall time.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10ff30f72b8ac4d842ea154f29420a946a463b66

commit 10ff30f72b8ac4d842ea154f29420a946a463b66
Author: bmcquade <bmcquade@chromium.org>
Date: Mon Jul 11 15:16:49 2016

Add DocWrite.Block metric for NavigationToFirstContentfulPaint.

We have ParseStartToFirstContentfulPaint for DocWrite.Block, which is
useful for understanding the exact impact of the change on the period
from parse start to FCP, but it's also important to measure the overall
time from navigation to FCP. This change adds a metric to track this
overall time.

BUG= 626945 

Review-Url: https://codereview.chromium.org/2140443002
Cr-Commit-Position: refs/heads/master@{#404660}

[modify] https://crrev.com/10ff30f72b8ac4d842ea154f29420a946a463b66/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

Labels: Merge-Request-53

Comment 3 by dimu@google.com, Jul 12 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 16 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 16 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7169ff247b58da0b76dd8cc590107e02606f19d4

commit 7169ff247b58da0b76dd8cc590107e02606f19d4
Author: bmcquade <bmcquade@chromium.org>
Date: Sat Jul 16 17:10:17 2016

Add DocWrite.Block metric for NavigationToFirstContentfulPaint.

We have ParseStartToFirstContentfulPaint for DocWrite.Block, which is
useful for understanding the exact impact of the change on the period
from parse start to FCP, but it's also important to measure the overall
time from navigation to FCP. This change adds a metric to track this
overall time.

BUG= 626945 
TBR=shivanisha
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2140443002
Cr-Commit-Position: refs/heads/master@{#404660}
(cherry picked from commit 10ff30f72b8ac4d842ea154f29420a946a463b66)

Review-Url: https://codereview.chromium.org/2158603003
Cr-Commit-Position: refs/branch-heads/2785@{#170}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/7169ff247b58da0b76dd8cc590107e02606f19d4/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc

Status: Fixed (was: Assigned)

Sign in to add a comment