New issue
Advanced search Search tips

Issue 626919 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

RTL scrollbar is misplaced on Mac

Project Member Reported by ebra...@gnu.org, Jul 9 2016

Issue description

Version: 51, 54
OS: OS X 10.11.5

What steps will reproduce the problem?
data:text/html;charset=utf8,<div dir="rtl" style="height: 100px; width: 300px; background: aliceblue; overflow: scroll"><div style="height: 600px;">
Scroll on box

What is the expected output?
Scroll shouldn't have unnecessary right padding

What do you see instead?
It has right padding that you can't see on Firefox for example.
 

Comment 1 by tkent@chromium.org, Jul 10 2016

Cc: -tkent@chromium.org
Components: -Blink Blink>Layout Blink>Scroll
Components: -Blink>Scroll
Position of scrollbars is solely a layout thing; removing Blink>Scroll tag.

Comment 3 by e...@chromium.org, Jul 12 2016

Cc: -e...@chromium.org szager@chromium.org
Status: Available (was: Untriaged)
Szager loves RTL scrollbar bugs. True story.

Comment 4 by szager@chromium.org, Jul 12 2016

Status: Unconfirmed (was: Available)
I tried this on a Mac running Chrome version 51.0.2704.106, and it looks fine to me:

http://imgur.com/Kur031C

Can you post a screenshot showing the bug?

Comment 5 by e...@chromium.org, Jul 12 2016

Labels: Needs-Feedback

Comment 6 by ebra...@gnu.org, Jul 12 2016

Labels: -Needs-Feedback
Weird, why your scroll differs that much from mine? Using latest Canary without any experimental flag (/Applications/Google Chrome Canary.app/Contents/MacOS/Google Chrome Canary --flag-switches-begin --flag-switches-end) I see the attachment
Untitled.png
22.2 KB View Download

Comment 7 by ebra...@gnu.org, Jul 12 2016

Expected result (but on LTR attached). I remember on other OSes there was a flag called overlay scrollbar or something and it seems you've enabled it by default on Mac at least as I can't see any option on about:flags to disable it even.
Expected.png
23.9 KB View Download

Comment 8 by e...@chromium.org, Jul 13 2016

Components: -Blink>Layout Blink>Layout>Scrollbars
Status: Available (was: Unconfirmed)

Comment 9 by ebra...@gnu.org, Aug 12 2016

Cc: tkent@chromium.org
Labels: -rtl -Pri-3 RTl Pri-2
Increasing its priority a bit.
Cc: bokan@chromium.org
ebrahim@: does your Mac have a Retina screen? The presence of a Retina can affect compositing decisions and could help narrow down where the problem lies. 

Comment 11 by ebra...@gnu.org, Nov 1 2016

It is an old one without a retina screen
Got it, I suspect szager@ had a retina screen. Could you try starting Chrome with the --enable-prefer-compositing-to-lcd-text flag and see if the issue still reproduces? 
Alternatively, you can force the scroller to be composited by adding "transform: translateZ(0)" to its style.

Comment 14 by ebra...@gnu.org, Nov 1 2016

It makes it more funny but no different. Actually I think this is a place someone should have look https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/scroll/ScrollbarTheme.cpp?sq=package:chromium&dr=CSs&l=323 "thumbPos + thumbRect.width() / 2,"
Labels: -RTL -Pri-2 Hotlist-Input-Dev Pri-3
Owner: sahel@chromium.org
Interesting. Sahel is currently looking at RTL scrollbar positioning for ChromeOS but we can take a look at this after that.

Comment 16 by ebra...@gnu.org, Nov 2 2016

c#14 is perhaps less related, interesting that overlay scrollbar that enables similar scrollbar on the rest of the platform doesn't have the issue.
Status: Started (was: Available)
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94a2767135371369605eda754487ea11ff7213b2

commit 94a2767135371369605eda754487ea11ff7213b2
Author: sahel <sahel@chromium.org>
Date: Wed Nov 23 20:30:54 2016

RTL overlay scrollbar on Mac is left aligned.

BUG= 626919 

Review-Url: https://codereview.chromium.org/2512033002
Cr-Commit-Position: refs/heads/master@{#434239}

[modify] https://crrev.com/94a2767135371369605eda754487ea11ff7213b2/third_party/WebKit/Source/platform/scroll/ScrollbarThemeMac.mm

Comment 19 by sahel@chromium.org, Nov 23 2016

Status: Fixed (was: Started)
Before and after screenshots are attached.
Mac_MD_leftside_vertical_scrollbar_before.png
141 KB View Download
Mac_MD_leftside_vertical_scrollbar_after.png
130 KB View Download

Sign in to add a comment