New issue
Advanced search Search tips

Issue 626915 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Upgrade notification icons differ between toolbar and Chrome menu

Project Member Reported by pkasting@chromium.org, Jul 9 2016

Issue description

Chrome Version       : 53.0.2783.4
OS Version: 10.0

On  bug 584342 , the upgrade notification icons for MD were changed.  Now the green "upgrade available" icon is a circle.

But if you open the menu, the corresponding icon inside the menu itself is square.  Comparison pic attached.

These icon sets should match.
 
Untitled.png
1.8 KB View Download
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 10 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/721482c78489c2053013cad2043164d72b120aca

commit 721482c78489c2053013cad2043164d72b120aca
Author: kylixrd <kylixrd@chromium.org>
Date: Wed Jul 13 19:38:55 2016

The app-menu button upgrade icon is a circle, while the menu item used a rounded rectangle. This ensures the menu image/icon is consistent with the button icon.

BUG= 626915 

Review-Url: https://codereview.chromium.org/2138103002
Cr-Commit-Position: refs/heads/master@{#405224}

[modify] https://crrev.com/721482c78489c2053013cad2043164d72b120aca/chrome/browser/upgrade_detector.cc
[delete] https://crrev.com/948c97f9e065bfb4cd9c7d4da5bb942f0a154455/ui/gfx/vector_icons/upgrade_menu_item.icon
[modify] https://crrev.com/721482c78489c2053013cad2043164d72b120aca/ui/gfx/vector_icons_sources.gypi

Status: Fixed (was: Assigned)

Sign in to add a comment