New issue
Advanced search Search tips

Issue 626882 link

Starred by 3 users
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Apr 2017
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: 2017-01-26
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 603620
issue 671375



Sign in to add a comment

[a11y] associate "Google, edit text" control w/ "Search Engine" label

Project Member Reported by chaok@google.com, Jul 9 2016 
features: what does it do? why do we need it?
Tabbing through chrome://md-settings will focus "Google, edit text", but purpose of control isn't clear to visually impaired ChromeVOx Next users.

bugs: repro steps (I did X and expected Y but Z happened!)
1. ctrl+alt+z to enable ChromeVox > search+shift+q+q to switch to Next
2. chrome://md-settings
3. TAB to "Google, edit text"

Observed:
GOogle, edit text

Expected:
Search engine when searching from the omnibox: Google, edit text
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 9 2016

Labels: Hotlist-Google

Comment 2 by ranjitkan@chromium.org, Jul 11 2016

Status: Untriaged (was: Unconfirmed)
Untriaging it so that it gets addressed.

Comment 3 by tbuck...@chromium.org, Jul 12 2016

Blocking: 603620
Labels: Hotlist-MD-Settings-PageA11y
Status: Available (was: Untriaged)

Comment 4 by chaok@google.com, Dec 13 2016 

Any update? How can we help to ensure that these accessibility items are fixed for md-settings?

Thanks!

Comment 5 by tbuck...@chromium.org, Jan 6 2017

Blockedon: 671375

Comment 6 by tbuck...@chromium.org, Jan 6 2017

Blockedon: -671375
Blocking: 671375

Comment 7 by chaok@google.com, Jan 26 2017

NextAction: 2017-01-26

Comment 8 by tbuck...@chromium.org, Mar 17 2017

Owner: hcarmona@chromium.org
Status: Assigned (was: Available)

Comment 9 by hcarmona@chromium.org, Apr 12 2017

Status: Started (was: Assigned)
https://codereview.chromium.org/2810003003/ will fix this.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff2e5c72ba330412f724b23e2b79d302460060ef

commit ff2e5c72ba330412f724b23e2b79d302460060ef
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Apr 13 04:16:31 2017

MD-Settings: A11y - Label drop down menus.

R=stevenjb@chromium.org
BUG= 603620 , 626882 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2810003003
Cr-Commit-Position: refs/heads/master@{#464293}

[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/app/settings_strings.grdp
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/people_page/import_data_dialog.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/site_settings/media_picker.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/site_settings/media_picker.js
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/resources/settings/site_settings/site_details_permission.html
[modify] https://crrev.com/ff2e5c72ba330412f724b23e2b79d302460060ef/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Comment 11 by hcarmona@chromium.org, Apr 13 2017

Status: Fixed (was: Started)
►

Sign in to add a comment