[a11y] advanced should be <button> tabindex="0" aria-expanded |
|||||||
Issue descriptionfeatures: what does it do? why do we need it? Advanced button isn't in taborderAdvanced element should be in tab-order, role="button, and aria-expanded so it's keyboard accessible and has ARIA attributes to convey purpose to visually impaired ChromeVOx users bugs: repro steps (I did X and expected Y but Z happened!) 1. ctrl=alt+z to enable ChromeVOx > search+shift+q+q to switch to Next 2. chrome://md-settings 3. search=ctrl+right arrow > search+left arrow until "Advanced" Observed: Advanced Expected: Advanced, button, collapsed
,
Jul 11 2016
Team, could you please look into this issue. Thank you.
,
Jul 12 2016
,
Aug 31 2016
,
Sep 1 2016
,
Sep 1 2016
Issue 629423 has been merged into this issue.
,
Sep 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/305ffc4f4518e097789f478cad137100fd938d5a commit 305ffc4f4518e097789f478cad137100fd938d5a Author: hcarmona <hcarmona@chromium.org> Date: Sat Sep 03 03:41:16 2016 [MD-Settings] Make the Advanced button into an actual button. This change enables keyboard focus, as well as making the button show as a button on screen readers. No UI change, except that the button has a ripple now. The ripple was missing. BUG= 626879 , 643309 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2305973002 Cr-Commit-Position: refs/heads/master@{#416440} [modify] https://crrev.com/305ffc4f4518e097789f478cad137100fd938d5a/chrome/browser/resources/settings/settings_main/settings_main.html
,
Sep 13 2016
1. aria-expanded is missing 2. ENTER/SPACEBAR doesn't respond for expanding/collapsing.
,
Oct 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9760089f786eba7bcdfe7165d6cb012af41214f3 commit 9760089f786eba7bcdfe7165d6cb012af41214f3 Author: hcarmona <hcarmona@chromium.org> Date: Tue Oct 11 18:58:11 2016 Allow the 'Advanced' button to act as an expandable toggle for a11y. BUG= 626879 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2408933002 Cr-Commit-Position: refs/heads/master@{#424499} [modify] https://crrev.com/9760089f786eba7bcdfe7165d6cb012af41214f3/chrome/browser/resources/settings/settings_main/settings_main.html
,
Oct 12 2016
,
Oct 19 2016
Fixed in: 56.0.2894.0 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sheriffbot@chromium.org
, Jul 9 2016