[a11y] sections should be headings <h2> |
||||||||||
Issue descriptionfeatures: what does it do? why do we need it? Sections should be <h2>, so it matches Old Settings, and provides for semantic structure and jump navigation for visually impaired ChromeVOx users bugs: repro steps (I did X and expected Y but Z happened!) 1. ctrl=alt+z to enable ChromeVOx > search+shift+q+q to switch to Next 2. chrome://md-settings 3. search+h multiple times Observed: Settings, h1 Please read: A personal appeal from the Chrome Team, h1Expected: Expected: Internet connection, h2 People, h2 Sync, h2 Personalize GOogle Service, h2 SmartLock Beta, h2 Appearance, h2 Themes, h2 Font size, h2 Page Zoom, h2 Device, h2 Keyboard Settings, h2 Search Engine, h2 Advanced, h2
,
Jul 11 2016
Team, could you please look into this issue. Thank you.
,
Jul 12 2016
,
Aug 30 2016
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8809c442c911cc26f3191bcda559cf85e16c05df commit 8809c442c911cc26f3191bcda559cf85e16c05df Author: hcarmona <hcarmona@chromium.org> Date: Wed Aug 31 21:04:30 2016 [MD-Settings] Make section titles into <h2> headings for a11y. UI remains the same. BUG= 626878 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2300433002 Cr-Commit-Position: refs/heads/master@{#415751} [modify] https://crrev.com/8809c442c911cc26f3191bcda559cf85e16c05df/chrome/browser/resources/settings/settings_page/settings_section.html
,
Sep 13 2016
,
Sep 13 2016
The original bug also mentions the Advanced button as also needing to be a heading, is that not needed anymore?
,
Sep 13 2016
I wasn't able to verify the "advanced" sections, as I'm unable to expand it using ChromeVox Next
,
Oct 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1be31b3cc02699adb840bd1c1d4fcdbb3d3c9dec commit 1be31b3cc02699adb840bd1c1d4fcdbb3d3c9dec Author: hcarmona <hcarmona@chromium.org> Date: Thu Oct 06 00:00:09 2016 Make the 'Advanced' button into an h2 for easier a11y navigation. No UI change. BUG= 626878 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2393583002 Cr-Commit-Position: refs/heads/master@{#423346} [modify] https://crrev.com/1be31b3cc02699adb840bd1c1d4fcdbb3d3c9dec/chrome/browser/resources/settings/settings_main/settings_main.html
,
Oct 6 2016
All headings + the advanced buttons are now h2.
,
Oct 8 2016
Fixed in: 55.0.2882.0
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1be31b3cc02699adb840bd1c1d4fcdbb3d3c9dec commit 1be31b3cc02699adb840bd1c1d4fcdbb3d3c9dec Author: hcarmona <hcarmona@chromium.org> Date: Thu Oct 06 00:00:09 2016 Make the 'Advanced' button into an h2 for easier a11y navigation. No UI change. BUG= 626878 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2393583002 Cr-Commit-Position: refs/heads/master@{#423346} [modify] https://crrev.com/1be31b3cc02699adb840bd1c1d4fcdbb3d3c9dec/chrome/browser/resources/settings/settings_main/settings_main.html
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by sheriffbot@chromium.org
, Jul 9 2016