New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626877 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-01-26
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 603620
issue 671375



Sign in to add a comment

[a11y] Search settings 3x

Project Member Reported by chaok@google.com, Jul 9 2016

Issue description

features: what does it do? why do we need it?
Duplicate/redundant elements that makes for confusing a11y-ux for visually impaired ChromeVOx users

bugs: repro steps (I did X and expected Y but Z happened!)
1. ctrl=alt+z to enable ChromeVOx > search+shift+q+q to switch to Next
2. chrome://md-settings
3. search+shift+left arrow > search+right arrow 4x

Observed:
Search Settings, button
Search Settings
Search settings, edit text

Expected:
Search Settings, edit text, search entry
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 9 2016

Labels: Hotlist-Google
Status: Untriaged (was: Unconfirmed)
Team, could you please look into this issue. 

Thank you.
Blocking: 603620
Labels: Hotlist-MD-Settings-PageA11y
Status: Available (was: Untriaged)

Comment 4 by chaok@google.com, Dec 13 2016

Any update? How can we help to ensure that these accessibility items are fixed for md-settings?

Thanks!
Blockedon: 671375
Blockedon: -671375
Blocking: 671375

Comment 7 by chaok@google.com, Jan 26 2017

NextAction: 2017-01-26

Comment 8 by dbeam@chromium.org, Mar 17 2017

Cc: tsergeant@chromium.org
Cc: -tsergeant@chromium.org
Owner: tsergeant@chromium.org
Status: Started (was: Available)
Getting rid of the middle text is easy: we just need to set aria-hidden="true" on the label element (which is what paper-input does).

Getting rid of the first announcement is a bit trickier, but I think setting aria-hidden="true" on that element when the toolbar is in wide mode would work.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16b08645940137900070a7c93cbb489526e63f4b

commit 16b08645940137900070a7c93cbb489526e63f4b
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Mar 21 03:21:12 2017

MD Webui: Improve accessibility of toolbar search field

This hides the static label text from screen readers, and similarly
hides the search icon button when the toolbar is in wide mode and
the button is purely decorative.

The result is that screen readers moving through the toolbar will
go straight to the search field, rather than needing to move through
two redundant search-related elements.

BUG= 626877 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2759073002
Cr-Commit-Position: refs/heads/master@{#458293}

[modify] https://crrev.com/16b08645940137900070a7c93cbb489526e63f4b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
[modify] https://crrev.com/16b08645940137900070a7c93cbb489526e63f4b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js

Status: Fixed (was: Started)

Sign in to add a comment