New issue
Advanced search Search tips

Issue 626875 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-01-26
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 603620
issue 671375



Sign in to add a comment

[a11y] unlabeled buttons

Project Member Reported by chaok@google.com, Jul 9 2016

Issue description

features: what does it do? why do we need it?
a11y-label for ChromeVOx Next, so visually impaired knows purpose of controls (first, third, and fourth)

bugs: repro steps (I did X and expected Y but Z happened!)
1. ctrl+alt+z to enable ChromeVOx > search+shift+q+q to toggle to Next
2. chrome://md-settings
3. ctrL=search+left arrow > Search+b 3x

Observed:
button
button, pressed
button, not pressed

ExpExpected:
Meaningful/concise a11y-labels for these 3 controls, so purpose is accessible to ChromeVOx Next users
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 9 2016

Labels: Hotlist-Google
Status: Untriaged (was: Unconfirmed)
Team, could you please look into this issue. 

Thank you.
Blocking: 603620
Labels: Hotlist-MD-Settings-PageA11y
Status: Available (was: Untriaged)
Cc: bettes@chromium.org
Owner: hcarmona@chromium.org
Status: Started (was: Available)
I've created go/gfiwl that has a list of buttons with missing labels and a proposed label for a11y. I'll be adding to this list. It's initially populated with the expanding section buttons.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c44d1f694586450babe23c8346e5a51a23b201e

commit 0c44d1f694586450babe23c8346e5a51a23b201e
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Sep 22 16:14:27 2016

[MD-Settings A11y] Set alt text for expandable buttons.

No UI change, this only affects the alt-label for the buttons.

BUG= 626875 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2348363002
Cr-Commit-Position: refs/heads/master@{#420364}

[modify] https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e/chrome/app/settings_strings.grdp
[modify] https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e/chrome/browser/resources/settings/certificate_manager_page/certificate_entry.html
[modify] https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e/chrome/browser/resources/settings/internet_page/internet_detail_page.html
[modify] https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e/chrome/browser/resources/settings/internet_page/internet_page.html
[modify] https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e/chrome/browser/resources/settings/printing_page/cups_printer_details_page.html
[modify] https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html
[modify] https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.js
[modify] https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e/ui/webui/resources/cr_elements/network/cr_network_select.html
[modify] https://crrev.com/0c44d1f694586450babe23c8346e5a51a23b201e/ui/webui/resources/cr_elements/network/cr_network_select.js

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e69885a473fcaf0f6c22664a3ae5fc2b4d38425

commit 8e69885a473fcaf0f6c22664a3ae5fc2b4d38425
Author: hcarmona <hcarmona@chromium.org>
Date: Tue Sep 27 21:46:37 2016

[MD-Settings-A11y] cr-expand-button should communicate that it expanded.

Default in paper-icon-button is to aria-pressed, changing to
aria-expanded because it makes more sense for expand buttons to expand.

BUG= 626875 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2318873002
Cr-Commit-Position: refs/heads/master@{#421346}

[modify] https://crrev.com/8e69885a473fcaf0f6c22664a3ae5fc2b4d38425/chrome/test/data/chromeos/oobe_webui_browsertest.js
[modify] https://crrev.com/8e69885a473fcaf0f6c22664a3ae5fc2b4d38425/ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html

Comment 7 by chaok@google.com, Oct 2 2016

Repros in: 55.0.2878.0
1. collapsed button
2. button pressed
3. button
4. button
5. button

Comment 8 by chaok@google.com, Dec 13 2016

Any update? How can we help to ensure that these accessibility items are fixed for md-settings?

Thanks!
Blockedon: 671375
Blockedon: -671375
Blocking: 671375

Comment 11 by chaok@google.com, Jan 26 2017

NextAction: 2017-01-26

Comment 12 by dbeam@chromium.org, Mar 17 2017

Cc: steve...@chromium.org
pretty much all buttons will have labels as of now (desktop) and tomorrow (ChromeOS) so i'm closing this bug.

if we find any more unlabelled controls, we'll file specific issues.

Comment 13 by dbeam@chromium.org, Mar 17 2017

Status: Fixed (was: Started)

Sign in to add a comment