New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626869 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"mash_browser_tests (with patch)" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jul 9 2016

Issue description

"mash_browser_tests (with patch)" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKgsSBUZsYWtlIh9tYXNoX2Jyb3dzZXJfdGVzdHMgKHdpdGggcGF0Y2gpDA.


 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, Jul 13 2016

Detected 5 new flakes for test/step "mash_browser_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKgsSBUZsYWtlIh9tYXNoX2Jyb3dzZXJfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.

Comment 2 by engedy@chromium.org, Jul 13 2016

Cc: engedy@chromium.org
Components: MUS
Labels: -Sheriff-Chromium
Owner: sky@chromium.org
Status: Assigned (was: Untriaged)
Scott, can you please help route this to the right owner?
Project Member

Comment 3 by chromium...@appspot.gserviceaccount.com, Jul 16 2016

Detected 12 new flakes for test/step "mash_browser_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKgsSBUZsYWtlIh9tYXNoX2Jyb3dzZXJfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.

Comment 4 by sky@chromium.org, Jul 18 2016

Status: Started (was: Assigned)

Comment 5 by sky@chromium.org, Jul 18 2016

Cc: yzshen@chromium.org
At least one of the problems seems to be triggered by mus crashing. Stack is here:
#0 0x7f2c5ba902be base::debug::StackTrace::StackTrace()
#1 0x7f2c5ba97b7a logging::LogMessage::~LogMessage()
#2 0x7f2c5c005d42 ui::ws::WindowTree::NewTopLevelWindow()
#3 0x7f2c5b93ceba ui::mojom::WindowTreeStub::Accept()
#4 0x7f2c5bb0ec34 mojo::InterfaceEndpointClient::HandleValidatedMessage()
#5 0x7f2c5b941dec ui::mojom::WindowTreeRequestValidator::Accept()
#6 0x7f2c5bb0f9fa mojo::InterfaceEndpointClient::HandleIncomingMessage()
#7 0x7f2c5bb14017 mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#8 0x7f2c5bb12d25 mojo::internal::MultiplexRouter::ProcessTasks()
#9 0x7f2c5bb149d2 mojo::internal::MultiplexRouter::LockAndCallProcessTasks()
#10 0x7f2c5ba907d9 base::debug::TaskAnnotator::RunTask()
#11 0x7f2c5ba9ce25 base::MessageLoop::RunTask()
#12 0x7f2c5ba9d118 base::MessageLoop::DeferOrRunPendingTask()
#13 0x7f2c5ba9d46b base::MessageLoop::DoWork()
#14 0x7f2c5ba9ed49 base::MessagePumpGlib::Run()
#15 0x7f2c5ba9c96d base::MessageLoop::RunHandler()
#16 0x7f2c5baad190 base::RunLoop::Run()
#17 0x7f2c5ba8827b shell::ApplicationRunner::Run()
#18 0x7f2c5ba8832c shell::ApplicationRunner::Run()
#19 0x7f2c5b913d58 MojoMain
#20 0x000002b99204 shell::RunNativeApplication()
#21 0x000002b96750 shell::(anonymous namespace)::RunNativeLibrary()
#22 0x000001febc8a _ZN4base8internal7InvokerINS0_9BindStateIPFvPN7content15RenderFrameHostEN4mojo16InterfaceRequestIN5blink5mojom19PresentationServiceEEEEJNS0_17UnretainedWrapperINS3_19RenderFrameHostImplEEEEEEFvSB_EE3RunEPNS0_13BindStateBaseEOSB_
#23 0x000002b9813b shell::ChildProcessMainWithCallback()
#24 0x000002b966f6 shell::ChildProcessMain()
#25 0x000001522585 RunMashBrowserTests()
#26 0x0000005ffbc3 main
#27 0x7f2c5def47ed __libc_start_main
#28 0x0000005ffad1 <unknown>

This DCHECK will only hit if a binding has been paused *and* we are still getting messages. I asked Yuzhu about it and he is going to take a look.

Comment 6 by yzshen@chromium.org, Jul 18 2016

Cc: roc...@chromium.org
RE comment #5: If the MultplexRouter has queued an incoming message before we pause the underlying message pipe, then it is possible to dispatch it to the user code. However, according to Scott this message pipe hasn't served any associated interface yet and no sync method call is possible. In that case, I don't know why we need to queue incoming messages.

I will need to take a closer look.

Btw, is this flake new? I followed the link on comment #3 and clicked "show all flakes" at the bottom. The oldest is 2016-07-07. I am not familiar with this tool -- does it only cache data for a few days? If not, this is likely to be a regression.


Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, Jul 19 2016

Detected 3 new flakes for test/step "mash_browser_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKgsSBUZsYWtlIh9tYXNoX2Jyb3dzZXJfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3383bb96a7ca62b76c9cc6b119474a023465832b

commit 3383bb96a7ca62b76c9cc6b119474a023465832b
Author: sky <sky@chromium.org>
Date: Wed Jul 20 17:25:39 2016

Adds some DCHECKs to help isolate flake

We seem to be getting messages when a binding is paused. The only way
this should be possible is if an associated interface has been
created. The added DCHECKs check for this.

BUG= 626869 
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2165873003
Cr-Commit-Position: refs/heads/master@{#406597}

[modify] https://crrev.com/3383bb96a7ca62b76c9cc6b119474a023465832b/services/ui/ws/window_tree.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b5e32c68d238a4143ac391db41f1a673143c3d8

commit 8b5e32c68d238a4143ac391db41f1a673143c3d8
Author: sky <sky@chromium.org>
Date: Wed Jul 20 22:11:07 2016

Moves DCHECK so that it might actually hit

The way the DCHECKs are now we won't know if an associated interface
has been created. By moving the DCHECK earlier on we can know if that
is the cause.

BUG= 626869 
TEST=none
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2164133002
Cr-Commit-Position: refs/heads/master@{#406685}

[modify] https://crrev.com/8b5e32c68d238a4143ac391db41f1a673143c3d8/services/ui/ws/window_tree.cc

Project Member

Comment 10 by chromium...@appspot.gserviceaccount.com, Jul 20 2016

Detected 6 new flakes for test/step "mash_browser_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKgsSBUZsYWtlIh9tYXNoX2Jyb3dzZXJfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d02e723a6b13338355523ca3ea45e6b807dc17c4

commit d02e723a6b13338355523ca3ea45e6b807dc17c4
Author: sky <sky@chromium.org>
Date: Thu Jul 21 00:19:06 2016

Converts exit_warning_handler to use ash common types

BUG= 626869 
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2168483006
Cr-Commit-Position: refs/heads/master@{#406723}

[modify] https://crrev.com/d02e723a6b13338355523ca3ea45e6b807dc17c4/ash/accelerators/exit_warning_handler.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/261d3e418deb8a4e2b218e3cbea44911eaaf3798

commit 261d3e418deb8a4e2b218e3cbea44911eaaf3798
Author: sky <sky@chromium.org>
Date: Thu Jul 21 03:06:17 2016

Moves ash/strings to ash/common/strings

BUG= 626869 
TEST=none
R=jamescook@chromium.org,reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2163253003
Cr-Commit-Position: refs/heads/master@{#406746}

[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/BUILD.gn
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/accelerators/accelerator_table.cc
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/ash_strings.grd
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/ash_strings.gyp
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/BUILD.gn
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_am.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_ar.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_bg.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_bn.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_ca.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_cs.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_da.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_de.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_el.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_en-GB.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_es-419.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_es.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_et.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_fa.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_fi.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_fil.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_fr.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_gu.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_hi.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_hr.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_hu.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_id.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_it.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_iw.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_ja.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_kn.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_ko.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_lt.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_lv.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_ml.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_mr.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_ms.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_nl.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_no.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_pl.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_pt-BR.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_pt-PT.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_ro.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_ru.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_sk.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_sl.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_sr.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_sv.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_sw.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_ta.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_te.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_th.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_tr.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_uk.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_vi.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_zh-CN.xtb
[rename] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/common/strings/ash_strings_zh-TW.xtb
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/mus/BUILD.gn
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/ash/sysui/BUILD.gn
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/chrome/browser/chromeos/power/peripheral_battery_observer.cc
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/chrome/browser/ui/ash/multi_user/user_switch_util.cc
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/chrome/chrome_repack_locales.gni
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/chrome/test/BUILD.gn
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/chrome/tools/build/repack_locales.py
[modify] https://crrev.com/261d3e418deb8a4e2b218e3cbea44911eaaf3798/components/exo/BUILD.gn

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2

commit 3018a07a055cd8f5df929d7dd4910ef6ae8af7e2
Author: sky <sky@chromium.org>
Date: Thu Jul 21 03:08:07 2016

Splits debug_commands into aura and non-aura parts

I ended up moving the aura parts directly into
accelerator_controller_delegate_aura as it didn't seem worth an extra
file as the code is always compiled (and isn't that much).

BUG= 626869 
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2168733002
Cr-Commit-Position: refs/heads/master@{#406748}

[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/accelerators/DEPS
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/accelerators/accelerator_controller.h
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/accelerators/accelerator_controller_delegate_aura.cc
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/accelerators/debug_commands.h
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/aura/wm_window_aura.h
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/common/wm_root_window_controller.h
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/common/wm_window.h
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/mus/bridge/wm_root_window_controller_mus.cc
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/mus/bridge/wm_root_window_controller_mus.h
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ash/mus/window_manager.h
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ui/compositor/debug_utils.cc
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ui/compositor/debug_utils.h
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ui/views/mus/window_manager_connection.cc
[modify] https://crrev.com/3018a07a055cd8f5df929d7dd4910ef6ae8af7e2/ui/views/mus/window_manager_connection.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f89458416af0982a7d5708b6d99c54c31a8da0e

commit 0f89458416af0982a7d5708b6d99c54c31a8da0e
Author: yzshen <yzshen@chromium.org>
Date: Thu Jul 21 16:15:35 2016

Mojo C++ bindings: fix Pause/Resume for MultiplexRouter.

Previously if there are queued messages, MultiplexRouter may dispatch method
calls or connection error notifications while it is paused.

BUG= 626869 

Review-Url: https://codereview.chromium.org/2165153002
Cr-Commit-Position: refs/heads/master@{#406867}

[modify] https://crrev.com/0f89458416af0982a7d5708b6d99c54c31a8da0e/mojo/public/cpp/bindings/lib/multiplex_router.cc
[modify] https://crrev.com/0f89458416af0982a7d5708b6d99c54c31a8da0e/mojo/public/cpp/bindings/lib/multiplex_router.h
[modify] https://crrev.com/0f89458416af0982a7d5708b6d99c54c31a8da0e/mojo/public/cpp/bindings/lib/router.h

Project Member

Comment 15 by chromium...@appspot.gserviceaccount.com, Jul 22 2016

Detected 3 new flakes for test/step "mash_browser_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKgsSBUZsYWtlIh9tYXNoX2Jyb3dzZXJfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.

Comment 16 by sky@chromium.org, Jul 25 2016

Status: Fixed (was: Started)
I haven't seen any flakes since Yuzhu's patch landed. Closing out.
Components: -MUS Internals>Services>WindowService

Sign in to add a comment