New issue
Advanced search Search tips

Issue 626853 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

milo: bad timing in https://luci-milo.appspot.com/swarming/prod/2fafff1d46fc5010

Project Member Reported by no...@chromium.org, Jul 9 2016

Issue description

build https://luci-milo.appspot.com/swarming/prod/2fafff1d46fc5010 has really weird timing:

- build duration is 3h, but start and end are same
- bot_update step took > 10 days
 

Comment 2 by no...@chromium.org, Jul 9 2016

Labels: -M-53 M-54
all those builds hanged

Comment 3 by no...@chromium.org, Jul 12 2016

Labels: -Pri-1 Pri-0
Status: Assigned (was: Untriaged)

Comment 4 by abw@google.com, Jul 12 2016

Labels: -Pri-0 Pri-1
Hi, Nodir ! Is a milo display bug really a P0 for c-i-t ? I'm thinking "no", so I'm downgrading it ... feel free to upgrade it if it is indeed causing significant impact for our users.

(Also, if it is Assigned, who is it assigned to ?)

Comment 5 by no...@chromium.org, Jul 12 2016

Owner: no...@chromium.org
Status: Started (was: Assigned)
Pri-0 meant highest priority, not necessarily impact on users
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/2d9c0bca8435d223d907cca702bbeb347a6a83b1

commit 2d9c0bca8435d223d907cca702bbeb347a6a83b1
Author: nodir <nodir@chromium.org>
Date: Mon Jul 18 18:37:37 2016

milo: fix build/step timing

This CL fixes two bugs:
1) confused swarming task StartedTs and CompletedTs
2) hang steps in infrafailed builds stayed Running and we compute their
   duration till now

R=hinoka@chromium.org, estaab@chromium.org
BUG= 626853 

Review-Url: https://codereview.chromium.org/2141013003

[modify] https://crrev.com/2d9c0bca8435d223d907cca702bbeb347a6a83b1/appengine/cmd/milo/logdog/logDogBuild.go
[modify] https://crrev.com/2d9c0bca8435d223d907cca702bbeb347a6a83b1/appengine/cmd/milo/resp/build.go
[add] https://crrev.com/2d9c0bca8435d223d907cca702bbeb347a6a83b1/appengine/cmd/milo/settings/funcs_test.go
[modify] https://crrev.com/2d9c0bca8435d223d907cca702bbeb347a6a83b1/appengine/cmd/milo/swarming/build.go
[modify] https://crrev.com/2d9c0bca8435d223d907cca702bbeb347a6a83b1/appengine/cmd/milo/swarming/build_test.go
[modify] https://crrev.com/2d9c0bca8435d223d907cca702bbeb347a6a83b1/appengine/cmd/milo/swarming/expectations/build-canceled.json
[modify] https://crrev.com/2d9c0bca8435d223d907cca702bbeb347a6a83b1/appengine/cmd/milo/swarming/expectations/build-exception.json
[add] https://crrev.com/2d9c0bca8435d223d907cca702bbeb347a6a83b1/appengine/cmd/milo/swarming/expectations/build-hang.json
[modify] https://crrev.com/2d9c0bca8435d223d907cca702bbeb347a6a83b1/appengine/cmd/milo/swarming/expectations/build-timeout.json
[add] https://crrev.com/2d9c0bca8435d223d907cca702bbeb347a6a83b1/appengine/cmd/milo/swarming/testdata/build-hang
[add] https://crrev.com/2d9c0bca8435d223d907cca702bbeb347a6a83b1/appengine/cmd/milo/swarming/testdata/build-hang.swarm

Comment 7 by no...@chromium.org, Jul 18 2016

Status: Verified (was: Started)

Sign in to add a comment