New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626851 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 624608
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

MD Overview mode performance seems slow (even on Pixel2)

Project Member Reported by dhadd...@chromium.org, Jul 9 2016

Issue description

1. Open some windows: 5 Chrome windows, Get Help, Files app, Play Store 
2. Arrange windows so you can see most of them at once. 
3. Press overview mode

It is clear that the title bar disappears from the windows and then a second later overview mode appears. This doesn't seem smooth

Likewise when you have all of the windows minimized then go into and out of overview mode it just seems to glitch for a second and then shows your wallpaper. Is there an animation playing in these two cases? 

In non-MD mode it feels a lot quicker 
 
This could be two bugs but I guess the point of this bug is to get a feel of if we are happy with the current performance. It feels less "snappy" than before 
Cc: abodenha@chromium.org
Labels: -Pri-3 Pri-1

Comment 4 by abodenha@google.com, Jul 10 2016

Owner: varkha@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by varkha@chromium.org, Jul 11 2016

Labels: M-54

Comment 6 by varkha@chromium.org, Jul 15 2016

I have a draft CL at https://codereview.chromium.org/2146323004/ that improves the smoothness but at a cost of disabling the window header hiding for the case of many (>10) windows. I would like to get a feel if this is an acceptable trade-off.
This will also likely improve situation with  issue 624608 .

Comment 7 by varkha@chromium.org, Jul 15 2016

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66

commit d8748a3907d55ade9282b8cf4d0993ac9ee5ab66
Author: varkha <varkha@chromium.org>
Date: Tue Jul 19 16:03:45 2016

[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
certain number of windows in the overview mode (controlled via flags).
Default is set to hardcoded 10.
It also makes sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

New flags are introduced:

--ash-max-previews-to-use-mask=<number>
Maximum number of preview windows in overview mode that can use masks to
hide window headers and use rounded corners. Use -1 to set to unlimited.

--ash-max-previews-to-use-shape=<number>
Maximum number of preview windows in overview mode that can use shapes to
hide window headers. Use -1 to set to unlimited.

BUG= 626851 
BUG= 624608 

Review-Url: https://codereview.chromium.org/2146323004
Cr-Commit-Position: refs/heads/master@{#406286}

[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/ash_switches.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/ash_switches.h
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/ash/wm/panels/panel_frame_view.h
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/chrome/app/generated_resources.grd
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/chrome/browser/about_flags.cc
[modify] https://crrev.com/d8748a3907d55ade9282b8cf4d0993ac9ee5ab66/tools/metrics/histograms/histograms.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 26 2016

Labels: merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbfb5afbb61eac2a18e6b210ec4f40162357f612

commit fbfb5afbb61eac2a18e6b210ec4f40162357f612
Author: Valery Arkhangorodsky <varkha@chromium.org>
Date: Tue Jul 26 22:51:04 2016

[ash-md] Improves smoothness with many windows in overview

Experimentally, most of the animation cost was coming from having window
shapes (used to mask the window header) and from using rounded rectangle
masks.
This CL disables both those performance hogs when there are more than
certain number of windows in the overview mode (controlled via flags).
Default is set to hardcoded 10.
It also makes sure that window controls (minimize / resize / close) are
hidden when in overview mode for custom and panel frames.

New flags are introduced:

--ash-max-previews-to-use-mask=<number>
Maximum number of preview windows in overview mode that can use masks to
hide window headers and use rounded corners. Use -1 to set to unlimited.

--ash-max-previews-to-use-shape=<number>
Maximum number of preview windows in overview mode that can use shapes to
hide window headers. Use -1 to set to unlimited.

BUG= 626851 
BUG= 624608 

Review-Url: https://codereview.chromium.org/2146323004
Cr-Commit-Position: refs/heads/master@{#406286}
(cherry picked from commit d8748a3907d55ade9282b8cf4d0993ac9ee5ab66)

Review URL: https://codereview.chromium.org/2184543005 .

Cr-Commit-Position: refs/branch-heads/2785@{#365}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/ash_switches.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/ash_switches.h
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/wm/panels/panel_frame_view.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/ash/wm/panels/panel_frame_view.h
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/chrome/app/generated_resources.grd
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/chrome/browser/about_flags.cc
[modify] https://crrev.com/fbfb5afbb61eac2a18e6b210ec4f40162357f612/tools/metrics/histograms/histograms.xml

Mergedinto: 624608
Status: Duplicate (was: Started)
Will track this as part of  issue 624608 .

Sign in to add a comment