New issue
Advanced search Search tips

Issue 626848 link

Starred by 2 users
Status: Fixed
Owner:
mdjones@chromium.org
Closed: Jul 2016
Cc:
mdjones@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 626764



Sign in to add a comment

Android: Don't pass |content_view_core*| around to all the scene layers

Project Member Reported by siev...@chromium.org, Jul 8 2016 
Matt, do you think we could just pass around cc::Layer* instead?

If you search for GetNativeContentViewCore() you will see where all this originates. 

Otherwise if you look at https://codereview.chromium.org/2122403002/ passing ViewAndroid would also be an option (esp. if you needed to find out anything else that's view/layout related that we could expose there).

Comment 1 by mdjones@chromium.org, Jul 9 2016

Owner: mdjones@chromium.org
Status: Assigned (was: Available)
Passing around cc::Layer seems reasonable because I don't recall needing any layout specific things. I'll take a look at implementing on Monday.

Comment 2 by siev...@chromium.org, Jul 11 2016 

Sounds great, thanks for helping!
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88238fa101071d080ae92cf9b1c8b43177a6b5f2

commit 88238fa101071d080ae92cf9b1c8b43177a6b5f2
Author: mdjones <mdjones@chromium.org>
Date: Thu Jul 14 00:17:28 2016

Remove ContentViewCore dependency from OverlayPanel

The only reason ContentViewCore is passed to the OverlayPanels is to
get the cc::Layer containing the content. This change removes the
dependency on ContentViewCore from the native OverlayPanel layers
in favor of the cc::Layer obtained from WebContents.

BUG= 626848 

Review-Url: https://codereview.chromium.org/2142263002
Cr-Commit-Position: refs/heads/master@{#405360}

[modify] https://crrev.com/88238fa101071d080ae92cf9b1c8b43177a6b5f2/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ContextualSearchSceneLayer.java
[modify] https://crrev.com/88238fa101071d080ae92cf9b1c8b43177a6b5f2/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ReaderModeSceneLayer.java
[modify] https://crrev.com/88238fa101071d080ae92cf9b1c8b43177a6b5f2/chrome/browser/android/compositor/layer/contextual_search_layer.cc
[modify] https://crrev.com/88238fa101071d080ae92cf9b1c8b43177a6b5f2/chrome/browser/android/compositor/layer/contextual_search_layer.h
[modify] https://crrev.com/88238fa101071d080ae92cf9b1c8b43177a6b5f2/chrome/browser/android/compositor/layer/overlay_panel_layer.cc
[modify] https://crrev.com/88238fa101071d080ae92cf9b1c8b43177a6b5f2/chrome/browser/android/compositor/layer/overlay_panel_layer.h
[modify] https://crrev.com/88238fa101071d080ae92cf9b1c8b43177a6b5f2/chrome/browser/android/compositor/layer/reader_mode_layer.cc
[modify] https://crrev.com/88238fa101071d080ae92cf9b1c8b43177a6b5f2/chrome/browser/android/compositor/layer/reader_mode_layer.h
[modify] https://crrev.com/88238fa101071d080ae92cf9b1c8b43177a6b5f2/chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc
[modify] https://crrev.com/88238fa101071d080ae92cf9b1c8b43177a6b5f2/chrome/browser/android/compositor/scene_layer/reader_mode_scene_layer.cc

Comment 4 by mdjones@chromium.org, Jul 14 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment