New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626839 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Remove screensaver blocking logic out of ScreenCapturer

Project Member Reported by zijiehe@chromium.org, Jul 8 2016

Issue description

This bug is to track work to remove screensaver blocking logic out of ScreenCapturer.

Logically screensaver blocker is not part of ScreenCapturer, and should be removed from them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/726a66222237491b51c1538854ea20e5df0b89d8

commit 726a66222237491b51c1538854ea20e5df0b89d8
Author: zijiehe <zijiehe@chromium.org>
Date: Fri Jul 15 21:44:27 2016

[Chromoting] Use device::PowerSaveBlocker to block screen saver

Now ScreenCapturers implement their own screen-saver blocking logic, which is
not part of ScreenCapturer functionality. This change adds ScreenSaverBlocker
into It2MeHost or RemotingMe2MeHost as a HostStatusObserver. The
ScreenSaverBlocker implementation uses device::PowerSaverBlocker to do the real
job, and monitors HostStatusMonitor's OnClientConnected and OnClientDisconnected
events to start and stop PowerSaverBlocker. After this change, we can eventually
remove screen-saver blocking logic from various ScreenCapturer implementations.

BUG= 626839 

Review-Url: https://codereview.chromium.org/2080723008
Cr-Commit-Position: refs/heads/master@{#405864}

[modify] https://crrev.com/726a66222237491b51c1538854ea20e5df0b89d8/remoting/host/BUILD.gn
[modify] https://crrev.com/726a66222237491b51c1538854ea20e5df0b89d8/remoting/host/DEPS
[add] https://crrev.com/726a66222237491b51c1538854ea20e5df0b89d8/remoting/host/host_power_save_blocker.cc
[add] https://crrev.com/726a66222237491b51c1538854ea20e5df0b89d8/remoting/host/host_power_save_blocker.h
[add] https://crrev.com/726a66222237491b51c1538854ea20e5df0b89d8/remoting/host/host_power_save_blocker_unittest.cc
[modify] https://crrev.com/726a66222237491b51c1538854ea20e5df0b89d8/remoting/host/remoting_me2me_host.cc
[modify] https://crrev.com/726a66222237491b51c1538854ea20e5df0b89d8/remoting/remoting_host.gypi
[modify] https://crrev.com/726a66222237491b51c1538854ea20e5df0b89d8/remoting/remoting_host_srcs.gypi
[modify] https://crrev.com/726a66222237491b51c1538854ea20e5df0b89d8/remoting/remoting_test.gypi

Owner: ajnolley@chromium.org
Status: Fixed (was: Started)
Hi, AJ,
This is a simple cleanup to existing code, which should have zero behavior impact. But if you happen to find screen-saver takes effect or machine suspends on host machine after a long time idle (no mouse or keyboard activities), please kindly let me know.

Thank you.
Sorry to confuse this bug. We do not block screen-saver from taking effect, but to block screen to power off or machine to suspend.
Status: Verified (was: Fixed)
In that case, this works correctly and I found no regressions. Verified in 54.0.2803.0

Sign in to add a comment