When the shipping address section is expanded, the name should be bolded, as well.
Screenshots of half of the fix on a KK device. We need backend changes to remove the phone number from the full address. Until those changes happen, I'm not displaying the phone number on its own line, but the uploaded CL adds the ability to do so.
Going to change the backend based on your CL.
Screenshot with the backend change.
dfalcantara@, feel free to take this bug back.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92f4c6ac21b2578ab3938c5bd3eb0f793621164f commit 92f4c6ac21b2578ab3938c5bd3eb0f793621164f Author: dfalcantara <dfalcantara@chromium.org> Date: Fri Jul 15 23:40:29 2016 [Payments] Add ability to bold parts of addresses * Add the ability to bold parts of a label. * Add the ability to show a tertiary label in the PaymentOption, which will later be used for phone number display. * The phone number is passed in to the PaymentOption using the new constructor via the AutofillAddress class. See crbug.com/626833 for screenshots. BUG=603635, 626833 Review-Url: https://codereview.chromium.org/2135573004 Cr-Commit-Position: refs/heads/master@{#405900} [modify] https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java [modify] https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java [modify] https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java [modify] https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java [modify] https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f/chrome/browser/autofill/android/personal_data_manager_android.cc [modify] https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f/chrome/browser/autofill/android/personal_data_manager_android.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdf235c56a359c2181ad5e664a2cbb442892e5de commit bdf235c56a359c2181ad5e664a2cbb442892e5de Author: markusheintz <markusheintz@chromium.org> Date: Mon Jul 18 09:02:03 2016 Revert of [Payments] Add ability to bold parts of addresses (patchset #4 id:60001 of https://codereview.chromium.org/2135573004/ ) Reason for revert: Android Test builder is failing since https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35304 see https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35304/steps/chrome_public_test_apk/logs/stdio This may be one of two CLs that could have caused this (the other is https://codereview.chromium.org/2116583002). Since the two CLs have some files in common I'll start reverting this one first. Original issue's description: > [Payments] Add ability to bold parts of addresses > > * Add the ability to bold parts of a label. > > * Add the ability to show a tertiary label in the PaymentOption, which > will later be used for phone number display. > > * The phone number is passed in to the PaymentOption using the new constructor > via the AutofillAddress class. > > See crbug.com/626833 for screenshots. > > BUG=603635, 626833 > > Committed: https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f > Cr-Commit-Position: refs/heads/master@{#405900} TBR=rouslan@chromium.org,mathp@chromium.org,dfalcantara@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=603635, 626833 Review-Url: https://codereview.chromium.org/2158763002 Cr-Commit-Position: refs/heads/master@{#405968} [modify] https://crrev.com/bdf235c56a359c2181ad5e664a2cbb442892e5de/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java [modify] https://crrev.com/bdf235c56a359c2181ad5e664a2cbb442892e5de/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java [modify] https://crrev.com/bdf235c56a359c2181ad5e664a2cbb442892e5de/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java [modify] https://crrev.com/bdf235c56a359c2181ad5e664a2cbb442892e5de/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java [modify] https://crrev.com/bdf235c56a359c2181ad5e664a2cbb442892e5de/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/bdf235c56a359c2181ad5e664a2cbb442892e5de/chrome/browser/autofill/android/personal_data_manager_android.cc [modify] https://crrev.com/bdf235c56a359c2181ad5e664a2cbb442892e5de/chrome/browser/autofill/android/personal_data_manager_android.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1089ca591550d0ca24befe3023b369a5ed2944da commit 1089ca591550d0ca24befe3023b369a5ed2944da Author: dfalcantara <dfalcantara@chromium.org> Date: Mon Jul 18 19:29:15 2016 [Payments] Add ability to bold parts of addresses * Add the ability to bold parts of a label. * Add the ability to show a tertiary label in the PaymentOption, which will later be used for phone number display. * The phone number is passed in to the PaymentOption using the new constructor via the AutofillAddress class. See crbug.com/626833 for screenshots. BUG=603635, 626833 Committed: https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f Review-Url: https://codereview.chromium.org/2135573004 Cr-Original-Commit-Position: refs/heads/master@{#405900} Cr-Commit-Position: refs/heads/master@{#406062} [modify] https://crrev.com/1089ca591550d0ca24befe3023b369a5ed2944da/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java [modify] https://crrev.com/1089ca591550d0ca24befe3023b369a5ed2944da/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java [modify] https://crrev.com/1089ca591550d0ca24befe3023b369a5ed2944da/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java [modify] https://crrev.com/1089ca591550d0ca24befe3023b369a5ed2944da/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java [modify] https://crrev.com/1089ca591550d0ca24befe3023b369a5ed2944da/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/1089ca591550d0ca24befe3023b369a5ed2944da/chrome/browser/autofill/android/personal_data_manager_android.cc [modify] https://crrev.com/1089ca591550d0ca24befe3023b369a5ed2944da/chrome/browser/autofill/android/personal_data_manager_android.h
Would like to merge commit 1089ca591550d0ca24befe3023b369a5ed2944da into M-53.
Your change meets the bar and is auto-approved for M53 (branch: 2785)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da302982c0331e56fbb90afac83f3ee777ecf7b3 commit da302982c0331e56fbb90afac83f3ee777ecf7b3 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Tue Jul 19 17:01:01 2016 [Merge M-53] [Payments] Add ability to bold parts of addresses * Add the ability to bold parts of a label. * Add the ability to show a tertiary label in the PaymentOption, which will later be used for phone number display. * The phone number is passed in to the PaymentOption using the new constructor via the AutofillAddress class. See crbug.com/626833 for screenshots. BUG=603635, 626833 Committed: https://crrev.com/92f4c6ac21b2578ab3938c5bd3eb0f793621164f Review-Url: https://codereview.chromium.org/2135573004 Cr-Original-Commit-Position: refs/heads/master@{#405900} Cr-Commit-Position: refs/heads/master@{#406062} (cherry picked from commit 1089ca591550d0ca24befe3023b369a5ed2944da) Review URL: https://codereview.chromium.org/2160293002 . Cr-Commit-Position: refs/branch-heads/2785@{#219} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/da302982c0331e56fbb90afac83f3ee777ecf7b3/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java [modify] https://crrev.com/da302982c0331e56fbb90afac83f3ee777ecf7b3/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java [modify] https://crrev.com/da302982c0331e56fbb90afac83f3ee777ecf7b3/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java [modify] https://crrev.com/da302982c0331e56fbb90afac83f3ee777ecf7b3/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java [modify] https://crrev.com/da302982c0331e56fbb90afac83f3ee777ecf7b3/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java [modify] https://crrev.com/da302982c0331e56fbb90afac83f3ee777ecf7b3/chrome/browser/autofill/android/personal_data_manager_android.cc [modify] https://crrev.com/da302982c0331e56fbb90afac83f3ee777ecf7b3/chrome/browser/autofill/android/personal_data_manager_android.h
Comment 1 by dfalcant...@chromium.org
, Jul 8 2016166 KB
166 KB View Download
170 KB
170 KB View Download