Issue metadata
Sign in to add a comment
|
Suggestions spontaneously cleared while they are not expired |
||||||||||||||||||||||
Issue description1. Open Chrome on NTP, see snippets loaded from a previous session 2. Wait... wait... 3. Observe snippets be cleared even though they are not expired. D/cr_Ntp : [NewTabPageAdapter.java:140] Received 7 new snippets. D/cr_NtpCards: [StatusListItem.java:113] Registering card for status: History Sync Disabled D/cr_Ntp : [NewTabPageAdapter.java:140] Received 2 new snippets. D/cr_NtpCards: [StatusListItem.java:70] Registering card for status: No Snippets W/cr_NtpCards: The RecyclerView items are not attached, can't determine the content height: snap=null, last=null. Using full height: 2105 Might be related to the temporary status being wrong. In that case properly handling issue 624338 should fix it. Better investigate soon though.
,
Jul 19 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 20 2016
,
Jul 20 2016
I can reproduce this behavior 100% if I kill Chrome via the app switcher. @dgn: Are you sure that this could be related to issue 624338 ? It is about the reload-spinner.
,
Jul 20 2016
Fix for this is in review: https://codereview.chromium.org/2166753003/ The spinner is another issue, yes, but it will be needed for when we don't have snippets in the DB. We become aware of history sync being enabled very late and we don't have a good way to handle that in the UI for now ( issue 627488 )
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc4b68d76ae1bc8db479c14be1b306e9185a1626 commit fc4b68d76ae1bc8db479c14be1b306e9185a1626 Author: dgn <dgn@chromium.org> Date: Thu Jul 21 14:06:11 2016 [NTP Client] Stop clearing suggestions to show the RELOAD card. We used to clear already loaded suggestions unconditionally when receiving notifications of the service status having changed. During startup we used to pull suggestions right away and get the status OK notification afterwards, which cleared them. We now properly detect and do nothing in that case. BUG= 626831 Review-Url: https://codereview.chromium.org/2166753003 Cr-Commit-Position: refs/heads/master@{#406837} [modify] https://crrev.com/fc4b68d76ae1bc8db479c14be1b306e9185a1626/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/fc4b68d76ae1bc8db479c14be1b306e9185a1626/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
,
Jul 21 2016
,
Jul 21 2016
Reopening to request M53 merge.
,
Jul 21 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 21 2016
cherry-pick fails with https://codereview.chromium.org/2162093002 (SnippetArticle -> SnippetArticleListItem) missing, and cherry-picking that one fails on https://codereview.chromium.org/2122993003 (remove unused Interests code). I might just merge with the old name instead or adding the missing CLs.
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86cb36f424317ea3128f4751f052d2a5aeb9e51e commit 86cb36f424317ea3128f4751f052d2a5aeb9e51e Author: dgn <dgn@chromium.org> Date: Fri Jul 22 10:13:53 2016 [M53][NTP Client] Stop clearing suggestions to show the RELOAD card. We used to clear already loaded suggestions unconditionally when receiving notifications of the service status having changed. During startup we used to pull suggestions right away and get the status OK notification afterwards, which cleared them. We now properly detect and do nothing in that case. BUG= 626831 TBR=bauerb@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2166753003 Cr-Commit-Position: refs/heads/master@{#406837} (cherry picked from commit fc4b68d76ae1bc8db479c14be1b306e9185a1626) Review-Url: https://codereview.chromium.org/2169393002 Cr-Commit-Position: refs/branch-heads/2785@{#293} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/86cb36f424317ea3128f4751f052d2a5aeb9e51e/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java [modify] https://crrev.com/86cb36f424317ea3128f4751f052d2a5aeb9e51e/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
,
Jul 22 2016
,
Aug 4 2016
Made a request to merge https://codereview.chromium.org/2216683002/ in M53, approved by kerz@ on the CL.
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/beb43eea08f42bef2ff83d72c4d7a51cd42fb3eb commit beb43eea08f42bef2ff83d72c4d7a51cd42fb3eb Author: dgn <dgn@chromium.org> Date: Thu Aug 04 17:43:45 2016 [M53][NTP Client] Fix test compilation on branch Fix the inconsistent class name usage introduced by https://codereview.chromium.org/2166753003 BUG= 626831 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2216683002 Cr-Commit-Position: refs/branch-heads/2785@{#504} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/beb43eea08f42bef2ff83d72c4d7a51cd42fb3eb/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nepper@chromium.org
, Jul 19 2016Labels: -Type-Bug zine-triaged M-54 M-53 Type-Bug-Regression