Right, this will become obsolete in that we'll never create a new paste popup directly from the browser.

However, note that in my plan we will still need a mechanism to change the visibility of existing popups, parts of which might look superficially similar to this.

I'm hoping that it doesn't have to be an embedder API though but an implementation detail since we already know about the important visibility bits and could hide it from whatever place is reponsible (i.e. WebContents or RWHV visibility).

Just keep myself up-to-date - is there any action amaralp@ or I can take for this issue or is it being done as a part of other team's work?

This bug is actually being blocked by the Context Menu Refactor.

crrev.com/2785853002 fixed this

It looks like it was just renamed though the actual mechanism behind it got much different. I'm trying to delete this virtual method with a view to removing the interface ContentViewCore entirely on the native side in the long run.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bd5a1d686abd3670a98e4767602a8b69ee51f4b

commit 4bd5a1d686abd3670a98e4767602a8b69ee51f4b
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Fri Jun 16 06:28:19 2017

Bypass ContentViewCore for selection popup methods

Some flows destined to SelectionPopupController are unnecessarily
routed through ContentViewCore. Since what WebContentsViewDelegate
do for embedders is basically same, factored the common part into
WebContentsViewAndroid, and routed it through
RenderWidgetHostViewAndroid -> SelectionPopupController.

This change got pulled from a bigger refactoring to break it down
to more manageable size https://crrev.com/2890173003 (still WIP).

BUG= 626830 , 626765 

Change-Id: Iaccd2b90288ebc65326b885be3830932e6a38486
Reviewed-on: https://chromium-review.googlesource.com/535676
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479967}
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/android_webview/browser/aw_web_contents_view_delegate.cc
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/android_webview/browser/aw_web_contents_view_delegate.h
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/content/browser/android/content_view_core_impl.h
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/content/browser/android/selection_popup_controller.cc
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/content/browser/android/selection_popup_controller.h
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/content/browser/web_contents/web_contents_view_android.cc
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/content/browser/web_contents/web_contents_view_android.h
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/content/public/browser/android/content_view_core.h
[modify] https://crrev.com/4bd5a1d686abd3670a98e4767602a8b69ee51f4b/content/shell/browser/shell_web_contents_view_delegate_android.cc

Now the method is really gone.