mac BreakpadURL is set to “none” when it should be cleared |
||
Issue descriptionIn bug crashpad:127 , I spotted this being logged by a build with Google branding (so opt-in-to-report-upload was available and on) in debug mode (so there isn’t an upload URL): [0708/145128:ERROR:http_transport_mac.mm(197)] unsupported URL (NSURLErrorDomain -1002) This is happening because the BreakpadURL key in the framework’s Info.plist is present but set to the string “none”. That was done in tweak_info_plist in https://crrev.com/794fb4784f694fe9d2dd23fa461caeb476c5a0de to trick Breakpad into saving crash dumps to a file. Crashpad always saves crash dumps, so this hack is no longer necessary and should be removed.
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd828670eaef26966373521fa23624d5b7b3ddd6 commit bd828670eaef26966373521fa23624d5b7b3ddd6 Author: mark <mark@chromium.org> Date: Mon Aug 01 21:38:11 2016 mac: Don't rely on Breakpad Info.plist keys for Crashpad initialization BUG= 626811 Review-Url: https://codereview.chromium.org/2204473002 Cr-Commit-Position: refs/heads/master@{#409063} [modify] https://crrev.com/bd828670eaef26966373521fa23624d5b7b3ddd6/build/config/features.gni [modify] https://crrev.com/bd828670eaef26966373521fa23624d5b7b3ddd6/build/mac/tweak_info_plist.py [modify] https://crrev.com/bd828670eaef26966373521fa23624d5b7b3ddd6/chrome/BUILD.gn [modify] https://crrev.com/bd828670eaef26966373521fa23624d5b7b3ddd6/components/crash/content/app/crashpad_mac.mm
,
Aug 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ecf788aa4505ad102829a31f9160d4fef7feab0 commit 8ecf788aa4505ad102829a31f9160d4fef7feab0 Author: mark <mark@chromium.org> Date: Tue Aug 02 17:46:32 2016 mac {content,app}_shell: disable Breakpad upload Breakpad upload should be disabled for these targets, but it was inadvertently enabled in bd828670eaef. BUG= 626811 Review-Url: https://codereview.chromium.org/2207593002 Cr-Commit-Position: refs/heads/master@{#409228} [modify] https://crrev.com/8ecf788aa4505ad102829a31f9160d4fef7feab0/content/shell/BUILD.gn [modify] https://crrev.com/8ecf788aa4505ad102829a31f9160d4fef7feab0/extensions/shell/app_shell.gyp
,
Aug 2 2016
The following revision refers to this bug: http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=89197 ------------------------------------------------------------------ r89197 | mmentovai@google.com | 2016-08-02T17:55:45.968699Z -----------------------------------------------------------------
,
Aug 2 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/src-internal.git/+/67400621d3c0235e5e1884af03451b834b8680fd commit 67400621d3c0235e5e1884af03451b834b8680fd Author: Mark Mentovai <mark@chromium.org> Date: Tue Aug 02 18:03:43 2016
,
Aug 2 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by mark@chromium.org
, Jul 8 2016