New issue
Advanced search Search tips

Issue 626810 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 771757
Owner: ----
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

When an iframe is hidden, its FrameView calls dispose(); but the FrameView may be reused later

Project Member Reported by szager@chromium.org, Jul 8 2016

Issue description

See:

https://codereview.chromium.org/2129033002/#msg3

If display:none is set on an iframe, that calls:

LayoutPart::willBeDestroyed()
  `HTMLFrameOwnerElement::setWidget(nullptr)
    `moveWidgetToParentSoon(frameView)
      `frameView->dispose()

However, the HTMLFrameOwnerElement retains a reference to the FrameView in its m_contentFrame member variable, and it reuses that FrameView if it subsequently becomes visible.

It's bananas to call FrameView::dispose() and then use the FrameView again.  The patch linked above tried to fix this, but it caused test failures.
 

Comment 1 by e...@chromium.org, Jul 12 2016

Cc: szager@chromium.org
Labels: -Pri-3 OS-All Pri-2
Status: Available (was: Untriaged)
That's crazy. Can we fix this as a part of root layzer scrolling?

Comment 2 by szager@chromium.org, Jul 12 2016

First things first: I am now going to start referring to the project as "Root Laser Scrolling".

Root laser scrolling will not fix this, but it will fix a related bug, which is that the frameView's scrollbars -- having been destroyed during the call to dispose() -- are not recreated when the iframe becomes visible again ( crbug.com/623280 ).
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 13 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by e...@chromium.org, Jul 17 2017

Status: Available (was: Untriaged)
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 18

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mergedinto: 771757
Status: Duplicate (was: Untriaged)

Sign in to add a comment