New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626796 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 611319
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: ----



Sign in to add a comment

Missing kasko_features.h when compiling setup_lib.installer_crash_reporting.obj

Project Member Reported by chrisha@chromium.org, Jul 8 2016

Issue description

This build failed while compiling setup_lib.installer_crash_reporting.obj

https://build.chromium.org/p/chromium/builders/Win/builds/45068

It complains about kasko_features.h missing. This is generated by the build flag system, and appears to be flake as the previous and next builds both succeeded, with nothing touching any code at all related to Crashpad or Kasko. The kasko_features is a public_dep of kasko, which is a public dep of crash, so the particular setup_lib build step should be waiting for the header file to be generated.

Is Kasko using the build flag features incorrectly, or is there problem with the GN implementation of build flags?

This has happened a couple of times sporadically over the last couple of months, specifically with kasko_features.h. I'm not aware of it happening with other build flag header files, but that doesn't mean it hasn't happened.

NB. Kasko is disappearing "real soon now" (being ripped out of SyzyASAN, the last piece of code depending on it), which will mitigate this particular issue in short order.
 
Also FWIW I looked at the media/ buildflag_header and it looks the same (same use of public_deps etc).
Mergedinto: 611319
Status: Duplicate (was: Assigned)

Sign in to add a comment