Remove use_cfi_cast |
||||
Issue descriptionThis issue is to track removal of use_cfi_cast GN option. We want to launch a check for virtual calls first, and only then follow up with cast checks, so is_cfi does not include the cast checks by default, and they might be added by use_cfi_cast=true. Once we're ready to launch CFI with cast checks, we'll need to remove use_cfi_cast.
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59d3718ac1328d46fac147720f078c53f63070cf commit 59d3718ac1328d46fac147720f078c53f63070cf Author: krasin <krasin@google.com> Date: Wed Jul 13 03:24:34 2016 Implement use_cfi_cast to optionally enable cast checks. This is to allow launching cfi-vcal first, and follow up with additional strictness later. BUG=626794, 464797 Review-Url: https://codereview.chromium.org/2131423002 Cr-Commit-Position: refs/heads/master@{#404956} [modify] https://crrev.com/59d3718ac1328d46fac147720f078c53f63070cf/base/BUILD.gn [modify] https://crrev.com/59d3718ac1328d46fac147720f078c53f63070cf/base/base.gyp [modify] https://crrev.com/59d3718ac1328d46fac147720f078c53f63070cf/base/tools_sanity_unittest.cc [modify] https://crrev.com/59d3718ac1328d46fac147720f078c53f63070cf/build/common.gypi [modify] https://crrev.com/59d3718ac1328d46fac147720f078c53f63070cf/build/config/sanitizers/BUILD.gn [modify] https://crrev.com/59d3718ac1328d46fac147720f078c53f63070cf/build/config/sanitizers/sanitizers.gni
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27490f9605648a3697251f616e71e734e9ca3424 commit 27490f9605648a3697251f616e71e734e9ca3424 Author: krasin <krasin@google.com> Date: Thu Jul 21 05:53:44 2016 Add 'CFI Linux Full' buildbot (src part). 'CFI Linux Full' buildbot is similar to 'CFI Linux', but also enables bad cast checks, which while are not scheduled to be released to the official Chrome in the nearest future, provide an important feedback on the bad casts in Chrome. We also want to track any regressions, so when we're ready to launch them, no additional cleanup is required. Also, enabling cfi_cast checks on a number of bots. BUG=626794 Review-Url: https://codereview.chromium.org/2164033003 Cr-Commit-Position: refs/heads/master@{#406773} [modify] https://crrev.com/27490f9605648a3697251f616e71e734e9ca3424/tools/mb/mb_config.pyl
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16c5214808e143ce453c80c2e538ec11861956c4 commit 16c5214808e143ce453c80c2e538ec11861956c4 Author: krasin <krasin@google.com> Date: Wed Aug 10 01:09:04 2016 Run tests on CFI Linux Full BUG=626794 Review-Url: https://codereview.chromium.org/2221193006 Cr-Commit-Position: refs/heads/master@{#410910} [modify] https://crrev.com/16c5214808e143ce453c80c2e538ec11861956c4/testing/buildbot/chromium.fyi.json
,
Aug 10 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 10 2017
At some point we should decide what to do about use_cfi_cast. It seems increasingly likely that we'll want to merge it into use_cfi_diag. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jul 13 2016