New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 626786 link

Starred by 7 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Mar 2017
Cc:
jonr...@chromium.org
█ tdander...@chromium.org
est...@chromium.org
█ shrike@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 535386


Sign in to add a comment

Move vector icons into platform-specific directories

Project Member Reported by tdander...@chromium.org, Jul 8 2016 
Once  issue 535386  is resolved, move the Chrome OS and Mac-specific vector icon files into their own subdirectories of ui/gfx/vector_icons, and modify ui/gfx/BUILD.gn to only include the vector icons needed for specific build configurations (e.g., only ship the Ash-specific icons when use_ash is true).

Comment 1 by tdander...@chromium.org, Jul 9 2016

Status: Started (was: Assigned)
CL for Ash-specific assets: https://chromiumcodereview.appspot.com/2139493002/

Comment 2 by tdander...@chromium.org, Aug 19 2016 

The CL mentioned in #1 isn't going to work. See https://codereview.chromium.org/2251643011/ for a new approach (still a very early WIP).

Comment 3 by tdander...@chromium.org, Aug 26 2016

Labels: -M-54 M-55
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e20e220418a0897ba123a53c2e0a27b369b7a3

commit 70e20e220418a0897ba123a53c2e0a27b369b7a3
Author: tdanderson <tdanderson@chromium.org>
Date: Wed Aug 31 22:25:19 2016

Move Ash-specific vector icons to ash/common/resources

Adds the initial plumbing needed in order to move
Ash-specific .icon files out of ui/gfx/vector_icons
and into ash/common/resources/vector_icons. As a
result, these icons will only be included when the
'ash' component is built.

Previously, the icon file foo_bar.icon would be
identified in code as the enum value
gfx::VectorIconId::FOO_BAR. For Ash-specific icons,
foo_bar.icon is now identified in code as the
constant ash::kFooBarIcon, which maps to a
VectorIcon struct (also introduced in this CL).
The eventual goal is for all icons to be identified
in this manner, and for the gfx::VectorIconId struct
to be removed.

BUG= 626786 
TEST=manual

Review-Url: https://codereview.chromium.org/2251643011
Cr-Commit-Position: refs/heads/master@{#415782}

[modify] https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3/ash/BUILD.gn
[modify] https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3/ash/common/DEPS
[modify] https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3/ash/common/system/ime/tray_ime_chromeos.cc
[add] https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3/ash/resources/vector_icons/BUILD.gn
[rename] https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3/ash/resources/vector_icons/system_menu_keyboard.1x.icon
[rename] https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3/ash/resources/vector_icons/system_menu_keyboard.icon
[add] https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3/ash/resources/vector_icons/vector_icons.cc.template
[add] https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3/ash/resources/vector_icons/vector_icons.h.template
[modify] https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3/ui/gfx/paint_vector_icon.cc
[modify] https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3/ui/gfx/paint_vector_icon.h
[modify] https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3/ui/gfx/vector_icon_types.h
[modify] https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3/ui/gfx/vector_icons/BUILD.gn
[modify] https://crrev.com/70e20e220418a0897ba123a53c2e0a27b369b7a3/ui/gfx/vector_icons/aggregate_vector_icons.py

Comment 5 by tdander...@chromium.org, Sep 1 2016

Labels: Hotlist-VectorIcons
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81c6985d45b90f6316b3e6c7382f3baf204d38a8

commit 81c6985d45b90f6316b3e6c7382f3baf204d38a8
Author: estade <estade@chromium.org>
Date: Thu Sep 08 21:25:59 2016

Move a bunch of ash-only vector icons to ash/.

BUG= 626786 

Review-Url: https://codereview.chromium.org/2316183003
Cr-Commit-Position: refs/heads/master@{#417402}

[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/audio/volume_view.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/cast/tray_cast.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/brightness/tray_brightness.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/common_palette_tool.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/common_palette_tool.h
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/palette_tool.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/palette_tool.h
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/palette_tool_manager.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/palette_tool_manager.h
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/palette_tray.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/tools/capture_region_mode.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/tools/capture_region_mode.h
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/tools/capture_screen_action.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/tools/capture_screen_action.h
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/tools/create_note_action.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/tools/create_note_action.h
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/tools/create_note_unittest.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/tools/laser_pointer_mode.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/tools/laser_pointer_mode.h
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/tools/magnifier_mode.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/palette/tools/magnifier_mode.h
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/power/power_status.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/screen_security/screen_tray_item.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/tray/label_tray_view.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/tray/tray_image_item.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/tray/tray_item_more.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/tray/tray_notification_view.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/common/system/update/tray_update.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/BUILD.gn
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_action_capture_region.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_action_capture_region.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_action_capture_screen.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_action_capture_screen.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_action_create_note.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_action_create_note.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_mode_laser_pointer.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_mode_laser_pointer.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_mode_magnify.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_mode_magnify.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_tray_icon_default.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_tray_icon_default.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_tray_icon_laser_pointer.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_tray_icon_laser_pointer.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_tray_icon_magnify.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/palette_tray_icon_magnify.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_accessibility.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_accessibility.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_arrow_right.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_arrow_right.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_bluetooth.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_bluetooth.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_bluetooth_disabled.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_bluetooth_disabled.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_brightness.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_brightness.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_business.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_business.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_caps_lock.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_caps_lock.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_cast.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_cast.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_child_user.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_child_user.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_rotation_lock_auto.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_rotation_lock_auto.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_rotation_lock_locked.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_rotation_lock_locked.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_screen_share.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_screen_share.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_sms.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_supervised_user.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_supervised_user.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_timer.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_timer.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_update.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_menu_update.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_accessibility.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_accessibility.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_battery.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_battery.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_battery_alert.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_battery_alert.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_battery_bolt.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_battery_bolt.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_battery_unreliable.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_battery_unreliable.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_battery_x.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_battery_x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_caps_lock.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_caps_lock.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_cast.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_cast.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_rotation_lock_locked.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_rotation_lock_locked.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_screen_share.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_screen_share.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_update.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_update.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_volume_mute.1x.icon
[rename] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/resources/vector_icons/system_tray_volume_mute.icon
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ash/system/chromeos/rotation/tray_rotation_lock.cc
[modify] https://crrev.com/81c6985d45b90f6316b3e6c7382f3baf204d38a8/ui/gfx/vector_icons/BUILD.gn

Comment 7 by tbuck...@chromium.org, Oct 24 2016

Labels: -Proj-MaterialDesign-NativeUI -Proj-MaterialDesign-CrOS

Comment 8 by tdander...@chromium.org, Oct 26 2016

Labels: -M-55 M-56
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b09a20497413aec05429e479a32cc47802df0784

commit b09a20497413aec05429e479a32cc47802df0784
Author: estade <estade@chromium.org>
Date: Wed Oct 26 16:10:45 2016

Share tray constants in network icon code,
and move network vector icons definitions to ash.

BUG= 626786 

Review-Url: https://codereview.chromium.org/2447113002
Cr-Commit-Position: refs/heads/master@{#427704}

[modify] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/common/system/chromeos/network/network_icon.cc
[modify] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/BUILD.gn
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_add_other.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_add_other.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_captive_portal.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_captive_portal.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_roaming.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_roaming.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_secure.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_secure.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_1x.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_3g.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_3g.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_4g.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_4g.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_edge.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_edge.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_evdo.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_evdo.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_gprs.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_gprs.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_hspa.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_hspa.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_hspa_plus.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_hspa_plus.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_lte.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_lte.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_lte_advanced.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_technology_lte_advanced.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_vpn.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_badge_vpn.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_ethernet.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_ethernet.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_vpn.1x.icon
[rename] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ash/resources/vector_icons/network_vpn.icon
[modify] https://crrev.com/b09a20497413aec05429e479a32cc47802df0784/ui/gfx/vector_icons/BUILD.gn
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8283cad74e0cad4840d1f222052d2244136ffeda

commit 8283cad74e0cad4840d1f222052d2244136ffeda
Author: estade <estade@chromium.org>
Date: Sun Jan 08 18:43:26 2017

Create vector icon resource directory specific to Chrome.

BUG= 626786 

Review-Url: https://codereview.chromium.org/2610163003
Cr-Commit-Position: refs/heads/master@{#442183}

[add] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/BUILD.gn
[rename] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/browser_tools.icon
[rename] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/browser_tools_error.icon
[rename] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/browser_tools_update.icon
[rename] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/navigate_back.1x.icon
[rename] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/navigate_back.icon
[rename] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/navigate_forward.1x.icon
[rename] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/navigate_forward.icon
[rename] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/navigate_home.1x.icon
[rename] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/navigate_home.icon
[rename] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/navigate_reload.1x.icon
[rename] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/navigate_reload.icon
[rename] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/navigate_stop.1x.icon
[rename] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/navigate_stop.icon
[add] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/vector_icons.cc.template
[add] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/app/vector_icons/vector_icons.h.template
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/browser/recovery/recovery_install_global_error.cc
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.h
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/browser/ui/global_error/global_error.cc
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/browser/ui/views/toolbar/app_menu_button.cc
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/browser/ui/views/toolbar/reload_button.cc
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/chrome/browser/upgrade_detector.cc
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/ui/gfx/vector_icons/BUILD.gn
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/ui/views/controls/button/vector_icon_button.cc
[modify] https://crrev.com/8283cad74e0cad4840d1f222052d2244136ffeda/ui/views/controls/button/vector_icon_button.h
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c2a3a29a5ad22d423151a835bc67582395870c6

commit 0c2a3a29a5ad22d423151a835bc67582395870c6
Author: vitaliii <vitaliii@chromium.org>
Date: Mon Jan 09 08:52:07 2017

Revert of Create vector icon resource directory specific to Chrome. (patchset #7 id:140001 of https://codereview.chromium.org/2610163003/ )

Reason for revert:
Speculative revert, likely broke:

Linux:
https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/31040

Mac:
https://uberchromegw.corp.google.com/i/chromium/builders/Mac/builds/22402

BUG= 679272 

Original issue's description:
> Create vector icon resource directory specific to Chrome.
>
> BUG= 626786 
>
> Review-Url: https://codereview.chromium.org/2610163003
> Cr-Commit-Position: refs/heads/master@{#442183}
> Committed: https://chromium.googlesource.com/chromium/src/+/8283cad74e0cad4840d1f222052d2244136ffeda

TBR=oshima@chromium.org,tdanderson@chromium.org,sky@chromium.org,avi@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 626786 

Review-Url: https://codereview.chromium.org/2614333002
Cr-Commit-Position: refs/heads/master@{#442212}

[delete] https://crrev.com/07c4f6235908cf73368e37301404a911401fb86e/chrome/app/vector_icons/BUILD.gn
[delete] https://crrev.com/07c4f6235908cf73368e37301404a911401fb86e/chrome/app/vector_icons/vector_icons.cc.template
[delete] https://crrev.com/07c4f6235908cf73368e37301404a911401fb86e/chrome/app/vector_icons/vector_icons.h.template
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/recovery/recovery_install_global_error.cc
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.h
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/global_error/global_error.cc
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/views/toolbar/app_menu_button.cc
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/views/toolbar/reload_button.cc
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/chrome/browser/upgrade_detector.cc
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/BUILD.gn
[rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/browser_tools.icon
[rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/browser_tools_error.icon
[rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/browser_tools_update.icon
[rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_back.1x.icon
[rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_back.icon
[rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_forward.1x.icon
[rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_forward.icon
[rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_home.1x.icon
[rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_home.icon
[rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_reload.1x.icon
[rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_reload.icon
[rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_stop.1x.icon
[rename] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/gfx/vector_icons/navigate_stop.icon
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/views/controls/button/vector_icon_button.cc
[modify] https://crrev.com/0c2a3a29a5ad22d423151a835bc67582395870c6/ui/views/controls/button/vector_icon_button.h
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01876af8d286f290fc12baeae8e4ac08913b9b90

commit 01876af8d286f290fc12baeae8e4ac08913b9b90
Author: estade <estade@chromium.org>
Date: Mon Jan 09 21:35:43 2017

Reland crrev.com/8283cad74e0cad4840d1f with fix for static initializers.

Fix for static initializers is in ui/gfx/vector_icon_types.h

Original description:
Create vector icon resource directory specific to Chrome.

BUG= 626786 
Review-Url: https://codereview.chromium.org/2610163003

Review-Url: https://codereview.chromium.org/2618403002
Cr-Commit-Position: refs/heads/master@{#442357}

[add] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/BUILD.gn
[rename] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/browser_tools.icon
[rename] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/browser_tools_error.icon
[rename] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/browser_tools_update.icon
[rename] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/navigate_back.1x.icon
[rename] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/navigate_back.icon
[rename] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/navigate_forward.1x.icon
[rename] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/navigate_forward.icon
[rename] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/navigate_home.1x.icon
[rename] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/navigate_home.icon
[rename] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/navigate_reload.1x.icon
[rename] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/navigate_reload.icon
[rename] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/navigate_stop.1x.icon
[rename] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/navigate_stop.icon
[add] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/vector_icons.cc.template
[add] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/app/vector_icons/vector_icons.h.template
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/browser/recovery/recovery_install_global_error.cc
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.h
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/browser/ui/global_error/global_error.cc
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/browser/ui/views/toolbar/app_menu_button.cc
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/browser/ui/views/toolbar/reload_button.cc
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/chrome/browser/upgrade_detector.cc
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/ui/gfx/vector_icon_types.h
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/ui/gfx/vector_icons/BUILD.gn
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/ui/views/controls/button/vector_icon_button.cc
[modify] https://crrev.com/01876af8d286f290fc12baeae8e4ac08913b9b90/ui/views/controls/button/vector_icon_button.h

Comment 13 by tdander...@chromium.org, Jan 9 2017

Cc: tdander...@chromium.org
Labels: -M-56 M-57
Owner: est...@chromium.org
Looks like Evan has picked up where I left off on this bug (thanks, Evan) so I'm going to reassign this to him.
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b92771b6d4a397129523f92eb829b295109c808

commit 1b92771b6d4a397129523f92eb829b295109c808
Author: estade <estade@chromium.org>
Date: Tue Jan 10 04:51:20 2017

Move more vector icons into respective directories.

BUG= 626786 

Review-Url: https://codereview.chromium.org/2623693003
Cr-Commit-Position: refs/heads/master@{#442481}

[modify] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ash/common/shelf/overflow_button.cc
[modify] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ash/common/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ash/common/system/overview/overview_button_tray.cc
[modify] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ash/resources/vector_icons/BUILD.gn
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ash/resources/vector_icons/shelf_keyboard.1x.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ash/resources/vector_icons/shelf_keyboard.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ash/resources/vector_icons/shelf_logout.1x.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ash/resources/vector_icons/shelf_logout.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ash/resources/vector_icons/shelf_overflow.1x.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ash/resources/vector_icons/shelf_overflow.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ash/resources/vector_icons/shelf_overview.1x.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ash/resources/vector_icons/shelf_overview.icon
[modify] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/BUILD.gn
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/laptop.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/smartphone.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab_audio.1x.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab_audio.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab_audio_muting.1x.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab_audio_muting.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab_bluetooth_connected.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab_close_hovered_pressed.1x.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab_close_hovered_pressed.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab_close_normal.1x.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab_close_normal.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab_media_capturing.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab_media_recording.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab_usb_connected.1x.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tab_usb_connected.icon
[rename] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/app/vector_icons/tablet.icon
[modify] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/browser/ui/cocoa/hover_close_button.mm
[modify] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/browser/ui/tabs/tab_utils.cc
[modify] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc
[modify] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/1b92771b6d4a397129523f92eb829b295109c808/ui/gfx/vector_icons/BUILD.gn
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5157480667e99269e0062e9df1df3875db85197

commit f5157480667e99269e0062e9df1df3875db85197
Author: estade <estade@chromium.org>
Date: Tue Jan 10 04:59:46 2017

Move more vector icons to respective directories and update code to
use gfx::VectorIcon structs instead of the VectorIconId enum.

Also add version of ImageButton::SetImage that takes a const ref image.

BUG= 626786 

Review-Url: https://codereview.chromium.org/2620613005
Cr-Commit-Position: refs/heads/master@{#442488}

[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/common/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/common/frame/caption_buttons/frame_caption_button.h
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/common/frame/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/common/frame/caption_buttons/frame_caption_button_container_view.h
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/common/frame/caption_buttons/frame_caption_button_container_view_unittest.cc
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/common/frame/default_header_painter.cc
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/common/system/tray/tray_popup_header_button.cc
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/BUILD.gn
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_back.1x.icon
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_back.icon
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_close.1x.icon
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_close.icon
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_left_snapped.1x.icon
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_left_snapped.icon
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_maximize.1x.icon
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_maximize.icon
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_minimize.1x.icon
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_minimize.icon
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_restore.1x.icon
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_restore.icon
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_right_snapped.1x.icon
[rename] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ash/resources/vector_icons/window_control_right_snapped.icon
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/chrome/browser/chromeos/options/wifi_config_view.cc
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/chrome/browser/chromeos/options/wimax_config_view.cc
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/chrome/browser/ui/views/frame/browser_header_painter_ash.cc
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ui/gfx/vector_icons/BUILD.gn
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ui/message_center/views/message_center_button_bar.cc
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ui/views/controls/button/image_button.cc
[modify] https://crrev.com/f5157480667e99269e0062e9df1df3875db85197/ui/views/controls/button/image_button.h

Comment 16 by jonr...@chromium.org, Jan 10 2017

Cc: jonr...@chromium.org
Hey,

The change in #15 has broken chromium os builds:

obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlMinimizeIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlCloseIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlLeftSnappedIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlRightSnappedIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlRestoreIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlMaximizeIcon'


The new icon constants are not checked in. I will revert to unblock the build.
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad25bdddb113a0986c246b4a046e6f68a327ac98

commit ad25bdddb113a0986c246b4a046e6f68a327ac98
Author: jonross <jonross@chromium.org>
Date: Tue Jan 10 15:54:40 2017

Revert of Move more vector icons to respective directories and update code to (patchset #1 id:1 of https://codereview.chromium.org/2620613005/ )

Reason for revert:
Hey,

The change in #15 has broken chromium os builds:

obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlMinimizeIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlCloseIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlLeftSnappedIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlRightSnappedIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlRestoreIcon'
obj/chrome/browser/ui/libui.a(browser_header_painter_ash.o):../../chrome/browser/ui/views/frame/browser_header_painter_ash.cc:function BrowserHeaderPainterAsh::UpdateCaptionButtons(): error: undefined reference to 'ash::kWindowControlMaximizeIcon'

The new icon constants are not checked in. I will revert to unblock the build.

Original issue's description:
> Move more vector icons to respective directories and update code to
> use gfx::VectorIcon structs instead of the VectorIconId enum.
>
> Also add version of ImageButton::SetImage that takes a const ref image.
>
> BUG= 626786 
>
> Review-Url: https://codereview.chromium.org/2620613005
> Cr-Commit-Position: refs/heads/master@{#442488}
> Committed: https://chromium.googlesource.com/chromium/src/+/f5157480667e99269e0062e9df1df3875db85197

TBR=sky@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 626786 

Review-Url: https://codereview.chromium.org/2618383004
Cr-Commit-Position: refs/heads/master@{#442595}

[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ash/common/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ash/common/frame/caption_buttons/frame_caption_button.h
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ash/common/frame/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ash/common/frame/caption_buttons/frame_caption_button_container_view.h
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ash/common/frame/caption_buttons/frame_caption_button_container_view_unittest.cc
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ash/common/frame/default_header_painter.cc
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ash/common/system/tray/tray_popup_header_button.cc
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ash/resources/vector_icons/BUILD.gn
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/chrome/browser/chromeos/options/wifi_config_view.cc
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/chrome/browser/chromeos/options/wimax_config_view.cc
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/chrome/browser/ui/views/frame/browser_header_painter_ash.cc
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/BUILD.gn
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_back.1x.icon
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_back.icon
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_close.1x.icon
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_close.icon
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_left_snapped.1x.icon
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_left_snapped.icon
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_maximize.1x.icon
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_maximize.icon
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_minimize.1x.icon
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_minimize.icon
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_restore.1x.icon
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_restore.icon
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_right_snapped.1x.icon
[rename] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/gfx/vector_icons/window_control_right_snapped.icon
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/message_center/views/message_center_button_bar.cc
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/views/controls/button/image_button.cc
[modify] https://crrev.com/ad25bdddb113a0986c246b4a046e6f68a327ac98/ui/views/controls/button/image_button.h
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fc24d12c8b88f8703321ba4470692b717bd381e

commit 0fc24d12c8b88f8703321ba4470692b717bd381e
Author: estade <estade@chromium.org>
Date: Wed Jan 11 16:23:52 2017

Reland f5157480667e99269e0062e9df1df3875db with fix for compile failure.

------------------------
Move more vector icons to respective directories and update code to
use gfx::VectorIcon structs instead of the VectorIconId enum.

Also add version of ImageButton::SetImage that takes a const ref image.

BUG= 626786 
Review-Url: https://codereview.chromium.org/2620613005
------------------------

Review-Url: https://codereview.chromium.org/2622893003
Cr-Commit-Position: refs/heads/master@{#442920}

[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/BUILD.gn
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/common/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/common/frame/caption_buttons/frame_caption_button.h
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/common/frame/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/common/frame/caption_buttons/frame_caption_button_container_view.h
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/common/frame/caption_buttons/frame_caption_button_container_view_unittest.cc
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/common/frame/default_header_painter.cc
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/common/system/tray/tray_popup_header_button.cc
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/common/wm/overview/window_selector_item.cc
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/common/wm/overview/window_selector_item.h
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/BUILD.gn
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_back.1x.icon
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_back.icon
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_close.1x.icon
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_close.icon
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_left_snapped.1x.icon
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_left_snapped.icon
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_maximize.1x.icon
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_maximize.icon
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_minimize.1x.icon
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_minimize.icon
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_restore.1x.icon
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_restore.icon
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_right_snapped.1x.icon
[rename] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ash/resources/vector_icons/window_control_right_snapped.icon
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/chrome/browser/chromeos/options/wifi_config_view.cc
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/chrome/browser/chromeos/options/wimax_config_view.cc
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/chrome/browser/ui/views/frame/browser_header_painter_ash.cc
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ui/gfx/vector_icons/BUILD.gn
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ui/message_center/views/message_center_button_bar.cc
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ui/views/controls/button/image_button.cc
[modify] https://crrev.com/0fc24d12c8b88f8703321ba4470692b717bd381e/ui/views/controls/button/image_button.h
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c

commit 48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c
Author: estade <estade@chromium.org>
Date: Thu Jan 12 17:22:35 2017

Migrate more vector icons to chrome/.

- Move and rename the find bar buttons (since they're used beyond just
  the find bar these days).
- Fix VectorIconButton's disabled state.

BUG= 626786 

Review-Url: https://codereview.chromium.org/2625273002
Cr-Commit-Position: refs/heads/master@{#443275}

[modify] https://crrev.com/48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c/chrome/app/vector_icons/BUILD.gn
[rename] https://crrev.com/48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c/chrome/app/vector_icons/caret_down.1x.icon
[rename] https://crrev.com/48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c/chrome/app/vector_icons/caret_down.icon
[rename] https://crrev.com/48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c/chrome/app/vector_icons/caret_up.1x.icon
[rename] https://crrev.com/48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c/chrome/app/vector_icons/caret_up.icon
[modify] https://crrev.com/48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
[modify] https://crrev.com/48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c/chrome/browser/ui/views/download/download_item_view.cc
[modify] https://crrev.com/48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c/ui/gfx/vector_icons/BUILD.gn
[modify] https://crrev.com/48d29c26b53c8f5809b2afaf7d9fdbaabdf5522c/ui/views/controls/button/vector_icon_button.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b3cc0d6f505b0c261caa6bb8e96c48170930064

commit 8b3cc0d6f505b0c261caa6bb8e96c48170930064
Author: estade <estade@chromium.org>
Date: Tue Jan 17 19:01:28 2017

Create vector icon directory for resources used by controls in ui/views.

BUG= 626786 

Review-Url: https://codereview.chromium.org/2627353002
Cr-Commit-Position: refs/heads/master@{#444104}

[modify] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/gfx/vector_icons/BUILD.gn
[modify] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/BUILD.gn
[modify] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/controls/button/checkbox.cc
[modify] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/controls/button/checkbox.h
[modify] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/controls/button/radio_button.cc
[modify] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/controls/button/radio_button.h
[modify] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/controls/menu/menu_image_util.cc
[add] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/BUILD.gn
[rename] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/checkbox_active.icon
[rename] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/checkbox_normal.icon
[rename] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/combobox_arrow_mac_disabled.icon
[rename] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/combobox_arrow_mac_enabled.icon
[rename] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/menu_check.1x.icon
[rename] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/menu_check.icon
[rename] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/menu_radio_empty.icon
[rename] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/menu_radio_selected.icon
[rename] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/radio_button_active.icon
[rename] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/radio_button_normal.icon
[rename] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/submenu_arrow.1x.icon
[rename] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/submenu_arrow.icon
[add] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/vector_icons.cc.template
[add] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/resources/vector_icons/vector_icons.h.template
[modify] https://crrev.com/8b3cc0d6f505b0c261caa6bb8e96c48170930064/ui/views/style/platform_style_mac.mm
Project Member

Comment 21 by bugdroid1@chromium.org, Jan 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50d9301aee1d5794a5c89f40992ff372995f60e3

commit 50d9301aee1d5794a5c89f40992ff372995f60e3
Author: estade <estade@chromium.org>
Date: Thu Jan 26 01:48:00 2017

Move around more vector icons.

Aside from mechanical changes, this does the following:
- adds vector icons to relevant libraries in components/
- moves initialization work (including virtual fn calls) from BubbleIconView ctor to Init().

BUG= 626786 

Review-Url: https://codereview.chromium.org/2644903004
Cr-Commit-Position: refs/heads/master@{#446200}

[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/ash/resources/vector_icons/vector_icons.h.template
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/BUILD.gn
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/autologin.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/bluetooth_connected.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/crashed_tab.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/credit_card.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/credit_card.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/folder.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/folder.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/folder_managed.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/folder_managed.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/folder_supervised.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/folder_supervised.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/incognito.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/incognito.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/overflow_chevron.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/overflow_chevron.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/translate.icon
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/vector_icons.h.template
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/zoom_minus.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/app/vector_icons/zoom_plus.icon
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/app_list/search/omnibox_result.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/autofill/autofill_popup_layout_model.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/bookmarks/bookmark_utils.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration_unittest.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/save_credit_card_decoration.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/star_decoration.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/star_decoration.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/translate_decoration.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/translate_decoration.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/zoom_decoration.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/cocoa/profiles/avatar_icon_controller.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/autofill/save_card_icon_view.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/autofill/save_card_icon_view.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/device_chooser_content_view.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/location_bar/bubble_icon_view.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/location_bar/selected_keyword_view.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/location_bar/star_view.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/location_bar/star_view.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/location_bar/zoom_view.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/location_bar/zoom_view.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/omnibox/omnibox_result_view.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/passwords/manage_passwords_icon_views.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/sad_tab_view.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/translate/translate_icon_view.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/chrome/browser/ui/views/translate/translate_icon_view.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/autocomplete_match.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/omnibox_view.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/omnibox_view.h
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/vector_icons/calculator.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/vector_icons/calculator.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/vector_icons/extension_app.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/vector_icons/extension_app.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/vector_icons/http.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/vector_icons/keyword_search.icon
[add] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/vector_icons/search.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/vector_icons/star.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/vector_icons/star.icon
[add] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/vector_icons/vector_icons.cc.template
[add] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/omnibox/browser/vector_icons/vector_icons.h.template
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/BUILD.gn
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/test_toolbar_model.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/test_toolbar_model.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/toolbar_model.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/toolbar_model_delegate.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/toolbar_model_impl.cc
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/toolbar_model_impl.h
[add] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/business.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/http.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/http.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/https_invalid.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/https_invalid.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/https_valid.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/https_valid.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/https_valid_in_chip.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/https_valid_in_chip.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/product.1x.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/product.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/star.icon
[rename] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/star_active.icon
[add] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/vector_icons.cc.template
[add] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/components/toolbar/vector_icons/vector_icons.h.template
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.h
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.mm
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/ui/gfx/vector_icons/BUILD.gn
[modify] https://crrev.com/50d9301aee1d5794a5c89f40992ff372995f60e3/ui/views/resources/vector_icons/vector_icons.h.template
Project Member

Comment 23 by bugdroid1@chromium.org, Feb 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8741905369e3debd9ae7e6eb469fa47a60fbd9b6

commit 8741905369e3debd9ae7e6eb469fa47a60fbd9b6
Author: estade <estade@chromium.org>
Date: Tue Feb 07 23:37:31 2017

Make new target for vector icon structs to replace
ui/gfx/vector_icons/

Migrate just one icon over for now.

BUG= 626786 

Review-Url: https://codereview.chromium.org/2667753006
Cr-Commit-Position: refs/heads/master@{#448789}

[modify] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/chrome/browser/ui/views/download/download_shelf_view.cc
[modify] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/chrome/browser/ui/views/find_bar_view.cc
[modify] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/ui/gfx/vector_icons/BUILD.gn
[add] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/ui/vector_icons/BUILD.gn
[add] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/ui/vector_icons/DEPS
[rename] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/ui/vector_icons/close.1x.icon
[rename] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/ui/vector_icons/close.icon
[add] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/ui/vector_icons/vector_icons.cc.template
[add] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/ui/vector_icons/vector_icons.h.template
[modify] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/ui/views/BUILD.gn
[modify] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/ui/views/DEPS
[modify] https://crrev.com/8741905369e3debd9ae7e6eb469fa47a60fbd9b6/ui/views/bubble/bubble_frame_view.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f45c88123e13fe4eaf095784ebd82406a9e7cf36

commit f45c88123e13fe4eaf095784ebd82406a9e7cf36
Author: estade <estade@chromium.org>
Date: Wed Feb 08 02:22:52 2017

Update ui/vector_icons/BUILD.gn to use new gn template.

Also add OWNERS file for the directory.

BUG= 626786 

Review-Url: https://codereview.chromium.org/2680043003
Cr-Commit-Position: refs/heads/master@{#448863}

[modify] https://crrev.com/f45c88123e13fe4eaf095784ebd82406a9e7cf36/ui/vector_icons/BUILD.gn
[add] https://crrev.com/f45c88123e13fe4eaf095784ebd82406a9e7cf36/ui/vector_icons/OWNERS
Project Member

Comment 25 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e235b69eb08d4d20006c5be62bc3cca37532801

commit 1e235b69eb08d4d20006c5be62bc3cca37532801
Author: estade <estade@chromium.org>
Date: Wed Feb 15 01:40:34 2017

Move more vector icons to more appropriate directories.

Some of the icons are now duplicated because updating all references to
them at once is very onerous --- often, updating one icon requires
updating many other related icons, e.g. all infobar icons. These will be
de-duped soon.

BUG= 626786 

Review-Url: https://codereview.chromium.org/2685683004
Cr-Commit-Position: refs/heads/master@{#450549}

[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/app/vector_icons/BUILD.gn
[add] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/app/vector_icons/chromium/product.icon
[add] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/app/vector_icons/file_download.icon
[rename] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/app/vector_icons/file_download_incognito.1x.icon
[rename] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/app/vector_icons/file_download_incognito.icon
[rename] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/app/vector_icons/file_download_shelf.icon
[add] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/app/vector_icons/google_chrome/product.icon
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/BUILD.gn
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/chrome_quota_permission_context.cc
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/download/download_permission_request.cc
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/download/notification/download_item_notification.h
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/media/webrtc/media_stream_devices_controller.cc
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/permissions/mock_permission_request.cc
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/permissions/permission_request.h
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/permissions/permission_request_impl.cc
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/ui/toolbar/media_router_action.cc
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/ui/toolbar/media_router_action.h
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/ui/toolbar/media_router_action_unittest.cc
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/ui/views/download/download_started_animation_views.cc
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/media/remoting/BUILD.gn
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/media/remoting/DEPS
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/media/remoting/interstitial.cc
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/gfx/vector_icons/BUILD.gn
[modify] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/BUILD.gn
[rename] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/error_circle.icon
[add] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/extension.icon
[rename] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/location_on.icon
[rename] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/media_router_active.icon
[rename] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/media_router_error.icon
[rename] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/media_router_idle.icon
[rename] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/media_router_warning.icon
[rename] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/microphone.icon
[add] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/midi.icon
[add] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/notifications.icon
[add] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/protocol_handler.icon
[add] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/videocam.icon
[add] https://crrev.com/1e235b69eb08d4d20006c5be62bc3cca37532801/ui/vector_icons/warning.icon
Project Member

Comment 26 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65b29245034c4f14504cac85af8b87ae0ed8e193

commit 65b29245034c4f14504cac85af8b87ae0ed8e193
Author: estade <estade@chromium.org>
Date: Wed Feb 22 17:07:52 2017

Add note to ui/gfx/vector_icons/BUILD to reduce developer confusion as
we transition to different vector icon targets.

NOTRY=true
BUG= 626786 

Review-Url: https://codereview.chromium.org/2712433002
Cr-Commit-Position: refs/heads/master@{#452099}

[modify] https://crrev.com/65b29245034c4f14504cac85af8b87ae0ed8e193/ui/gfx/vector_icons/BUILD.gn
Project Member

Comment 27 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd85908c96b3ef0016091664a0dff37eaaced26b

commit bd85908c96b3ef0016091664a0dff37eaaced26b
Author: estade <estade@chromium.org>
Date: Fri Feb 24 21:53:43 2017

Update infobars to use VectorIcon struct instead of VectorIconId.

Once again, some duped icons until we can update more clients.

TBR=rohitrao@chromium.org
BUG= 626786 

Review-Url: https://codereview.chromium.org/2711623003
Cr-Commit-Position: refs/heads/master@{#452940}

[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/app/vector_icons/BUILD.gn
[add] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/app/vector_icons/OWNERS
[rename] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/app/vector_icons/apps.icon
[add] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/app/vector_icons/cookie.icon
[rename] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/app/vector_icons/extension.icon
[rename] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/app/vector_icons/extension_crashed.icon
[rename] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/app/vector_icons/globe.icon
[rename] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/app/vector_icons/paintbrush.icon
[rename] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/app/vector_icons/sad_tab.icon
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/banners/app_banner_infobar_delegate_desktop.h
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/extensions/extension_icon_manager.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/extensions/theme_installed_infobar_delegate.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/extensions/theme_installed_infobar_delegate.h
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/pepper_broker_infobar_delegate.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/pepper_broker_infobar_delegate.h
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/permissions/permission_request_impl.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/plugins/plugin_infobar_delegates.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/plugins/plugin_infobar_delegates.h
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/plugins/plugin_observer.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/chrome_select_file_policy.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/collected_cookies_infobar_delegate.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/collected_cookies_infobar_delegate.h
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/hung_plugin_tab_helper.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/startup/default_browser_infobar_delegate.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/startup/default_browser_infobar_delegate.h
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/startup/session_crashed_infobar_delegate.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/startup/session_crashed_infobar_delegate.h
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/website_settings/website_settings_infobar_delegate.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/chrome/browser/ui/website_settings/website_settings_infobar_delegate.h
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/components/infobars/core/infobar_delegate.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/components/infobars/core/infobar_delegate.h
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/components/infobars/core/simple_alert_infobar_delegate.cc
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/components/infobars/core/simple_alert_infobar_delegate.h
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/ui/gfx/vector_icons/BUILD.gn
[modify] https://crrev.com/bd85908c96b3ef0016091664a0dff37eaaced26b/ui/vector_icons/BUILD.gn
Project Member

Comment 28 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eac868b87946406cbcce4633a76fca5e65ab9291

commit eac868b87946406cbcce4633a76fca5e65ab9291
Author: estade <estade@chromium.org>
Date: Tue Feb 28 05:36:22 2017

Update content settings to new vector icon format.

BUG= 626786 

Review-Url: https://codereview.chromium.org/2721823002
Cr-Commit-Position: refs/heads/master@{#453514}

[modify] https://crrev.com/eac868b87946406cbcce4633a76fca5e65ab9291/chrome/app/vector_icons/BUILD.gn
[rename] https://crrev.com/eac868b87946406cbcce4633a76fca5e65ab9291/chrome/app/vector_icons/blocked_badge.icon
[rename] https://crrev.com/eac868b87946406cbcce4633a76fca5e65ab9291/chrome/app/vector_icons/code.icon
[rename] https://crrev.com/eac868b87946406cbcce4633a76fca5e65ab9291/chrome/app/vector_icons/image.icon
[rename] https://crrev.com/eac868b87946406cbcce4633a76fca5e65ab9291/chrome/app/vector_icons/mixed_content.icon
[rename] https://crrev.com/eac868b87946406cbcce4633a76fca5e65ab9291/chrome/app/vector_icons/my_location.icon
[rename] https://crrev.com/eac868b87946406cbcce4633a76fca5e65ab9291/chrome/app/vector_icons/subresource_filter_active.icon
[rename] https://crrev.com/eac868b87946406cbcce4633a76fca5e65ab9291/chrome/app/vector_icons/warning_badge.icon
[add] https://crrev.com/eac868b87946406cbcce4633a76fca5e65ab9291/chrome/app/vector_icons/web.icon
[modify] https://crrev.com/eac868b87946406cbcce4633a76fca5e65ab9291/chrome/browser/ui/content_settings/content_setting_image_model.cc
[modify] https://crrev.com/eac868b87946406cbcce4633a76fca5e65ab9291/chrome/browser/ui/content_settings/content_setting_image_model.h
[modify] https://crrev.com/eac868b87946406cbcce4633a76fca5e65ab9291/ui/gfx/vector_icons/BUILD.gn
[delete] https://crrev.com/1aebff2782292aed9da6a88bf3e98dc8a280c605/ui/gfx/vector_icons/cookie.icon
[delete] https://crrev.com/1aebff2782292aed9da6a88bf3e98dc8a280c605/ui/gfx/vector_icons/extension.icon
[delete] https://crrev.com/1aebff2782292aed9da6a88bf3e98dc8a280c605/ui/gfx/vector_icons/file_download.icon
[delete] https://crrev.com/1aebff2782292aed9da6a88bf3e98dc8a280c605/ui/gfx/vector_icons/midi.icon
[delete] https://crrev.com/1aebff2782292aed9da6a88bf3e98dc8a280c605/ui/gfx/vector_icons/protocol_handler.icon
[delete] https://crrev.com/1aebff2782292aed9da6a88bf3e98dc8a280c605/ui/gfx/vector_icons/videocam.icon

Comment 29 Deleted

Project Member

Comment 30 by bugdroid1@chromium.org, Mar 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78fa524fa500c7e54491c0af8d1674555a64e367

commit 78fa524fa500c7e54491c0af8d1674555a64e367
Author: estade <estade@chromium.org>
Date: Fri Mar 03 02:22:37 2017

Update vector icons in browser profiles code (bubble, etc.) to structs.

Move icon definitions as appropriate.

BUG= 626786 

Review-Url: https://codereview.chromium.org/2729623002
Cr-Commit-Position: refs/heads/master@{#454470}

[modify] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/BUILD.gn
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/account_box.icon
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/account_child.icon
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/account_child_circle.icon
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/account_circle.icon
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/close_all.icon
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/lock.icon
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/mode_edit.icon
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/photo_camera.icon
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/remove_box.icon
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/settings.icon
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/supervisor_account.icon
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/supervisor_account_circle.icon
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/sync_problem.icon
[rename] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/app/vector_icons/user_account_avatar.icon
[modify] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
[modify] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
[modify] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/browser/ui/views/profiles/new_avatar_button.cc
[modify] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/78fa524fa500c7e54491c0af8d1674555a64e367/ui/gfx/vector_icons/BUILD.gn
[delete] https://crrev.com/5bc2737ade6958dda45c2085bc2755970a6639ab/ui/gfx/vector_icons/remove_circle.icon
Project Member

Comment 31 by bugdroid1@chromium.org, Mar 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b0d20258d8d2009595e515010ae04f92208f4ee

commit 3b0d20258d8d2009595e515010ae04f92208f4ee
Author: estade <estade@chromium.org>
Date: Thu Mar 09 07:25:18 2017

Move final vector icons out of ui/gfx/vector_icons/ and remove the
enum.

BUG= 626786 
TBR=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2733823003
Cr-Commit-Position: refs/heads/master@{#455689}

[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/BUILD.gn
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/common/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/common/system/chromeos/audio/audio_detailed_view.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/common/system/chromeos/ime_menu/ime_list_view.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/common/system/chromeos/network/network_list_md.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/common/system/chromeos/palette/common_palette_tool.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/common/system/chromeos/palette/palette_tray.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/common/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/common/wm/overview/window_selector.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/resources/vector_icons/BUILD.gn
[rename] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/resources/vector_icons/check_circle.1x.icon
[rename] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ash/resources/vector_icons/check_circle.icon
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/app/vector_icons/BUILD.gn
[rename] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/app/vector_icons/default_favicon.icon
[rename] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/app/vector_icons/eol.icon
[rename] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/app/vector_icons/google_search_mac_touchbar.icon
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/chromeos/eol_notification.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/chromeos/options/network_config_view.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/extensions/DEPS
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/extensions/extension_context_menu_model.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/permissions/permission_request.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/chrome_select_file_policy.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac_unittest.mm
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration_unittest.mm
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/cocoa/passwords/credential_item_button.mm
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/extensions/extension_message_bubble_bridge.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/extensions/extension_message_bubble_bridge_unittest.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/startup/automation_infobar_delegate.h
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/views/autofill/save_card_icon_view.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/views/download/download_item_view.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/views/download/download_started_animation_views.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/views/location_bar/selected_keyword_view.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/views/location_bar/star_view.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views_unittest.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/components/omnibox/browser/DEPS
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/components/omnibox/browser/omnibox_view.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/components/toolbar/BUILD.gn
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/components/toolbar/DEPS
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/components/toolbar/toolbar_model_impl.cc
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/components/toolbar/vector_icons/business.icon
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ios/chrome/browser/ui/toolbar/toolbar_model_delegate_ios.mm
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/gfx/BUILD.gn
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/gfx/paint_vector_icon.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/gfx/paint_vector_icon.h
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/BUILD.gn
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/OWNERS
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/chromium/product.icon
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/fullscreen.icon
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/google_chrome/product.icon
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/help_outline.icon
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/notifications.icon
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/omnibox_search.icon
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/pdf.1x.icon
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/pdf.icon
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/vector_icons.cc.template
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/vector_icons.h.template
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/warning.icon
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons/web.icon
[delete] https://crrev.com/86769268e85c0913ef8d86c46ff08baff599703e/ui/gfx/vector_icons_public.h
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/vector_icons/BUILD.gn
[rename] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/vector_icons/aggregate_vector_icons.py
[rename] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/vector_icons/business.icon
[add] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/vector_icons/check_circle.icon
[rename] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/vector_icons/info_outline.icon
[rename] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/vector_icons/notifications_off.icon
[rename] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/vector_icons/search.icon
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/vector_icons/vector_icons.gni
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/views/bubble/tooltip_icon.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/views/controls/button/vector_icon_button.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/views/controls/button/vector_icon_button.h
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/views/controls/throbber.cc
[modify] https://crrev.com/3b0d20258d8d2009595e515010ae04f92208f4ee/ui/views/examples/vector_example.cc

Comment 32 by est...@chromium.org, Mar 15 2017

Status: Fixed (was: Started)
►

Sign in to add a comment