Android: Remove ContentViewCore::PauseOrResumeGeolocation() |
||||
Issue descriptionI think this is only used by WebView. The background is that I want to eliminate the content_view_core.h public interface line by line. So this just needs to be exposed in another proper public interface so WebView can use it. It's a bit interesting now because WebContentsImpl implements GetGeolocationServiceContext() via the RenderFrameHostDelegate interface right now, i.e. this is used from internally otherwise. Well, if WebView needs to do this and this needs to be done for the subscriptions of a specific WebContents then maybe it just needs to be a public API on WebContents. Anyone from WebView available to pick this up?
,
Sep 29 2016
,
Sep 30 2016
,
Oct 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5df3a5d1a16eabf9c1d6ae306b5957596cb3b0ca commit 5df3a5d1a16eabf9c1d6ae306b5957596cb3b0ca Author: jinsukkim <jinsukkim@chromium.org> Date: Sun Oct 16 23:52:44 2016 Remove ContentViewCore::PauseOrResumeGeolocation() Geolocation is being paused/resumed via the page visibility mechanisim, so the logic associated with onPause/onResume can be removed safely. This is part of an effort to remove/split up ContentViewCore. BUG= 626782 Review-Url: https://codereview.chromium.org/2379253002 Cr-Commit-Position: refs/heads/master@{#425601} [modify] https://crrev.com/5df3a5d1a16eabf9c1d6ae306b5957596cb3b0ca/android_webview/java/src/org/chromium/android_webview/AwContents.java [modify] https://crrev.com/5df3a5d1a16eabf9c1d6ae306b5957596cb3b0ca/android_webview/native/aw_contents.cc [modify] https://crrev.com/5df3a5d1a16eabf9c1d6ae306b5957596cb3b0ca/content/browser/android/content_view_core_impl.cc [modify] https://crrev.com/5df3a5d1a16eabf9c1d6ae306b5957596cb3b0ca/content/browser/android/content_view_core_impl.h [modify] https://crrev.com/5df3a5d1a16eabf9c1d6ae306b5957596cb3b0ca/content/public/browser/android/content_view_core.h [modify] https://crrev.com/5df3a5d1a16eabf9c1d6ae306b5957596cb3b0ca/device/geolocation/geolocation_service_context.cc [modify] https://crrev.com/5df3a5d1a16eabf9c1d6ae306b5957596cb3b0ca/device/geolocation/geolocation_service_context.h [modify] https://crrev.com/5df3a5d1a16eabf9c1d6ae306b5957596cb3b0ca/device/geolocation/geolocation_service_impl.cc
,
Oct 16 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by siev...@chromium.org
, Jul 8 2016