Unify ui::DisplaySnapshot and ash::DisplayInfo |
|||||||||||||||
Issue descriptionThere is a large overlap between ui::DisplaySnapshot and ash::DisplayInfo. It would be ideal if we could unify the implementations somehow. One possibility is for ash::DisplayInfo to hold onto a ui::DisplaySnapshot. Another more difficult possibility is to merge the classes together. This is complicated by DIP vs DDP differences between the two classes.
,
Jul 8 2016
msw@ saw this recently as well
,
Jul 8 2016
I had noticed the similarities between ui and ash DisplayMode types: ui::DisplayMode (ui/display/types/display_mode.h) ash::DisplayMode (ash/common/display/display_info.h) But, yeah, there seem to be a number of similar types and access methods.
,
Jul 30 2016
,
Jul 30 2016
,
Jul 30 2016
,
Jul 30 2016
Outline of approach: * make ash::DisplayMode look like ui::DisplayMode * augment ui::DisplayMode * remove ash::DisplayMode * move ash::DisplayInfo and friends to ui * merge ash::DisplayInfo with ui::DisplaySnapshot
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8503c15d538e221dcca5843c9376f86efd244c3e commit 8503c15d538e221dcca5843c9376f86efd244c3e Author: rjkroege <rjkroege@chromium.org> Date: Fri Aug 05 21:19:42 2016 Make ash::DisplayMode more like ui::DisplayMode As a first step towards merging ui::DisplaySnapshot and ash::DisplayInfo, make ash::DisplayMode more like ui::DisplayMode so that a subsequent CL can remove ash::DisplayMode. BUG=626778 Review-Url: https://codereview.chromium.org/2196923002 Cr-Commit-Position: refs/heads/master@{#410166} [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/accelerators/accelerator_commands_aura.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/common/display/display_info.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/common/display/display_info.h [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/common/display/display_info_unittest.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/display/display_change_observer_chromeos.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/display/display_change_observer_chromeos.h [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/display/display_change_observer_chromeos_unittest.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/display/display_manager.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/display/display_manager.h [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/display/display_manager_unittest.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/display/display_util.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/display/display_util.h [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/display/resolution_notification_controller.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/display/resolution_notification_controller.h [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/display/resolution_notification_controller_unittest.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/test/display_manager_test_api.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/touch/touch_transformer_controller_unittest.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/ash/touch/touchscreen_util_unittest.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/chrome/browser/chromeos/display/display_preferences.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/chrome/browser/chromeos/display/display_preferences_unittest.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/8503c15d538e221dcca5843c9376f86efd244c3e/chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
,
Aug 19 2016
This still seems desirable but is not strictly necessary to advance the larger goal of full display management on mus.
,
Aug 19 2016
,
Oct 4 2016
,
Dec 9 2016
,
Feb 21 2017
,
Feb 26 2018
,
Feb 26 2018
,
Apr 19 2018
,
Aug 1
,
Aug 14
Bug scrub: Doesn't seem on critical path for mash. abodenha, this is a good example of a code health issue for the cros team. |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by kylec...@chromium.org
, Jul 8 2016