New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626773 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
inactive
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Use a flag to enable drag and drop feature on Android

Project Member Reported by hush@chromium.org, Jul 8 2016

Issue description

We need to fully test it before we can enable it by default.
 

Comment 1 by hush@chromium.org, Jul 8 2016

Labels: M-53
This has to be merged back to m53 because it is enabled by default in m53.

Comment 3 by hush@chromium.org, Jul 9 2016

Labels: Merge-Request-53
Can I merge this CL to m53?

Comment 4 by dimu@google.com, Jul 9 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)

Comment 5 by hush@chromium.org, Jul 9 2016

Cc: sgu...@chromium.org
Status: Fixed (was: Assigned)
Sorry actually no need to get this to m53.
The CL that really enabled drag and drop only went to m54.

commit 445de0ecb75960ee4060dfcfaf1a86e5632e4d0a
Author: hush <hush@chromium.org>
Date:   Thu Jun 30 23:52:45 2016 -0700

    Support dragging texts into Android WebView.
    
    WebView gets callback 'onDragEvent' when something is dragged into the WebView.
    This CL extracts the texts (if any) and location from the DragEvent and creates
    DropData which is Chromium's internal representation of dragged data.
    
    The event plumbing path is WebView#onDragEvent --> AwContents#onDragEvent -->
    ContentViewCore --> WebContentsViewAndroid.
    
    This CL also uses a new blink::WebView API that performs dropping with DropData,
    because on Android, the DropData is only available when the drop is performed,
    not when the drag is started.
    
    BUG= 584789 
    
    Review-Url: https://codereview.chromium.org/1728193002
    Cr-Commit-Position: refs/heads/master@{#403417}

Comment 6 by boliu@chromium.org, Jul 9 2016

Labels: -Merge-Approved-53

Sign in to add a comment