TabDragging/DetachToBrowserInSeparateDisplayTabDragControllerTest.DragSingleTabToSeparateWindowInSecondDisplay/1 triggers DCHECK |
||||||||
Issue descriptionHere's the stack: [36061:36061:0708/132034:FATAL:window_event_dispatcher.cc(443)] Check failed: window()->Contains(target_window). #0 0x7f88f92ed65e base::debug::StackTrace::StackTrace() #1 0x7f88f9348f3c logging::LogMessage::~LogMessage() #2 0x7f88f067489f aura::WindowEventDispatcher::PreDispatchEvent() #3 0x7f88f054abe5 ui::EventDispatcherDelegate::DispatchEvent() #4 0x7f88f06738c6 aura::WindowEventDispatcher::ProcessGestures() #5 0x7f88f06756f8 aura::WindowEventDispatcher::PostDispatchEvent() #6 0x7f88f054aca4 ui::EventDispatcherDelegate::DispatchEvent() #7 0x7f88f055093b ui::EventProcessor::OnEventFromSource() #8 0x7f88f05519a5 ui::EventSource::DeliverEventToProcessor() #9 0x7f88f055162c ui::EventSource::SendEventToProcessor() #10 0x0000036e4ac0 ui::EventSourceTestApi::SendEventToProcessor() #11 0x0000036e264d ui::test::EventGenerator::DoDispatchEvent() #12 0x0000036e0330 ui::test::EventGenerator::Dispatch() #13 0x0000036e0e32 ui::test::EventGenerator::ReleaseTouchId() #14 0x0000036e0d97 ui::test::EventGenerator::ReleaseTouch() #15 0x0000008e0c80 DetachToBrowserTabDragControllerTest::ReleaseInput() #16 0x0000008df085 (anonymous namespace)::DragSingleTabToSeparateWindowInSecondDisplayStep3() #17 0x0000008e846a _ZN4base8internal13FunctorTraitsIPFvP36DetachToBrowserTabDragControllerTestEE6InvokeIJRKS3_EEEvS5_DpOT_ #18 0x0000008e8418 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKPFvP36DetachToBrowserTabDragControllerTestEJRKS5_EEEvOT_DpOT0_ #19 0x0000008e83d2 _ZN4base8internal7InvokerINS0_9BindStateIPFvP36DetachToBrowserTabDragControllerTestEJS4_EEEFvvEE7RunImplIRKS6_RKSt5tupleIJS4_EEJLm0EEEEvOT_OT0_N\ S_13IndexSequenceIJXspT1_EEEE #20 0x0000008e833c _ZN4base8internal7InvokerINS0_9BindStateIPFvP36DetachToBrowserTabDragControllerTestEJS4_EEEFvvEE3RunEPNS0_13BindStateBaseE #21 0x7f88f92d127e base::Callback<>::Run() #22 0x7f88f92f2f5e base::debug::TaskAnnotator::RunTask() #23 0x7f88f93656e1 base::MessageLoop::RunTask() #24 0x7f88f9365964 base::MessageLoop::DeferOrRunPendingTask() #25 0x7f88f9365c2e base::MessageLoop::DoWork() #26 0x7f88f937b516 base::MessagePumpGlib::Run() #27 0x7f88f936514a base::MessageLoop::RunHandler() #28 0x7f88f93ff824 base::RunLoop::Run() #29 0x7f88f008ae68 ash::ToplevelWindowEventHandler::RunMoveLoop() #30 0x7f88fa203af3 views::NativeWidgetAura::RunMoveLoop() #31 0x7f88fa1c7f52 views::Widget::RunMoveLoop() #32 0x000005d5d8e8 TabDragController::RunMoveLoop() #33 0x000005d60149 TabDragController::DetachIntoNewBrowserAndRunMoveLoop() #34 0x000005d5f199 TabDragController::DragBrowserToNewTabStrip() #35 0x000005d5e009 TabDragController::ContinueDragging() #36 0x000005d5bec0 TabDragController::Drag() #37 0x000005d72d91 TabStrip::ContinueDrag() #38 0x000005d78746 TabStrip::OnGestureEvent() #39 0x7f88f054fd2b ui::EventHandler::OnEvent() #40 0x7f88f054b650 ui::EventDispatcher::DispatchEvent() #41 0x7f88f054afab ui::EventDispatcher::ProcessEvent() #42 0x7f88f054ad42 ui::EventDispatcherDelegate::DispatchEventToTarget() #43 0x7f88f054ac22 ui::EventDispatcherDelegate::DispatchEvent() #44 0x7f88f055093b ui::EventProcessor::OnEventFromSource() #45 0x7f88f05519a5 ui::EventSource::DeliverEventToProcessor() #46 0x7f88f055162c ui::EventSource::SendEventToProcessor() #47 0x7f88fa1caa1c views::Widget::OnGestureEvent() #48 0x7f88fa205251 views::NativeWidgetAura::OnGestureEvent() #49 0x7f88f054fd2b ui::EventHandler::OnEvent() #50 0x7f88f054b650 ui::EventDispatcher::DispatchEvent() #51 0x7f88f054afab ui::EventDispatcher::ProcessEvent() #52 0x7f88f054ad42 ui::EventDispatcherDelegate::DispatchEventToTarget() #53 0x7f88f054ac22 ui::EventDispatcherDelegate::DispatchEvent() #54 0x7f88f06738c6 aura::WindowEventDispatcher::ProcessGestures() #55 0x7f88f06756f8 aura::WindowEventDispatcher::PostDispatchEvent() #56 0x7f88f054aca4 ui::EventDispatcherDelegate::DispatchEvent() #57 0x7f88f055093b ui::EventProcessor::OnEventFromSource() #58 0x7f88f05519a5 ui::EventSource::DeliverEventToProcessor() #59 0x7f88f055162c ui::EventSource::SendEventToProcessor() #60 0x0000036e4ac0 ui::EventSourceTestApi::SendEventToProcessor() #61 0x0000036e264d ui::test::EventGenerator::DoDispatchEvent()
,
Nov 10 2016
,
Apr 5 2017
,
Apr 6 2017
,
Apr 15 2017
One WindowEventDispatcher is responsible for dispatching events in the associated WindowTreeHost, i.e. the target of the event needs to live inside that WindowTreeHost. If, during the dispatch of an event, the target window is destroyed, then the EventDispatchDetails.target_destroyed will be set, which will abort the processing of the rest of the gesture events in that sequence. If, however, the window is *moved* out of that WindowTreeHost, then we do not abort the processing of the rest of the gesture events in the sequence. So, the fix would either be to abort the dispatch of the gestures, or to route them to the right WindowTreeHost. I tested locally, both test with mouse and touch passed, so I uploaded a cl and run it on try bot, the weird thing is that the test failed. In the test, the tab should be dragged to the second display, but it actually stays in the first display. I am not sure what the difference between running locally and on try bot? Here is the CL: https://codereview.chromium.org/2823663002/
,
Apr 20 2017
test using ozone has different behavior with not using ozone: For touch input, the tab is dragged to second screen no matter we use ozone or not. For mouse input, the tab is dragged to second screen if we don't use ozone, but stays in first screen if we use ozone.
,
Apr 20 2017
+kylechar@
,
Apr 21 2017
If I understand correctly, the test behaviour is different with X11 Chrome OS and Ozone Chrome OS using Ozone X11? X11 Chrome OS will use AshWindowTreeHostX11 + WindowTreeHostX11 for the window. It also uses X11EventSourceGlib for dispatching events. Ozone Chrome OS will use AshWindowTreeHostPlatform + WindowTreeHostPlatform with a PlatformWindow. For Ozone X11 the PlatformWindow is X11WindowOzone. It also uses X11EventSourceLibEvent for dispatching events. There might be a difference in how capture works, or something with how events are created and dispatched?
,
Apr 24 2017
#10 Yes you are right. X11 Chrome OS use UIControllerX11 while Ozone Chrome OS use UIControlsOzone in test. Each UIController is responsible for sending key/mouse event in the associated display. For Ozone, UIControllers for two displays does not share the mouse state (down,up) as the button_down_mask is a class member of UIController. When the mouse is moved to second display, UIController for second display does not know the state of the mouse. That's why the tab cannot be dragged to the second display in Ozone Chrome OS environment. Simple solution is to move the button_down_mask outside of UIControllerOzone.
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/171e2ebecd1cda288825631299b898d65b80f52e commit 171e2ebecd1cda288825631299b898d65b80f52e Author: weidongg <weidongg@chromium.org> Date: Fri Apr 28 17:42:32 2017 Fix an interactive ui test * Remove touch drag for a series of tests about tab dragging to the second display as, up to now, there's no use case. * Each display has its own UI controller in the test, but, in ozone build, they do not share the state of mouse (down, up). When the mouse is moved to the second display, the UI controller for it does know that the mouse is down in first display. That's why the tab cannot be dragged to the second display only in ozone build. Simple solution is to move the mouse state variable outside of UI controller class. BUG= 626769 Review-Url: https://codereview.chromium.org/2836073003 Cr-Commit-Position: refs/heads/master@{#468048} [modify] https://crrev.com/171e2ebecd1cda288825631299b898d65b80f52e/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc [modify] https://crrev.com/171e2ebecd1cda288825631299b898d65b80f52e/ui/aura/test/ui_controls_factory_ozone.cc
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/171e2ebecd1cda288825631299b898d65b80f52e commit 171e2ebecd1cda288825631299b898d65b80f52e Author: weidongg <weidongg@chromium.org> Date: Fri Apr 28 17:42:32 2017 Fix an interactive ui test * Remove touch drag for a series of tests about tab dragging to the second display as, up to now, there's no use case. * Each display has its own UI controller in the test, but, in ozone build, they do not share the state of mouse (down, up). When the mouse is moved to the second display, the UI controller for it does know that the mouse is down in first display. That's why the tab cannot be dragged to the second display only in ozone build. Simple solution is to move the mouse state variable outside of UI controller class. BUG= 626769 Review-Url: https://codereview.chromium.org/2836073003 Cr-Commit-Position: refs/heads/master@{#468048} [modify] https://crrev.com/171e2ebecd1cda288825631299b898d65b80f52e/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc [modify] https://crrev.com/171e2ebecd1cda288825631299b898d65b80f52e/ui/aura/test/ui_controls_factory_ozone.cc
,
Apr 28 2017
,
May 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1483ffaddd203a96a19c420061101ab9b2fcd48 commit d1483ffaddd203a96a19c420061101ab9b2fcd48 Author: sky <sky@chromium.org> Date: Mon May 01 21:03:33 2017 Revert of Fix an interactive ui test (patchset #7 id:120001 of https://codereview.chromium.org/2836073003/ ) Reason for revert: Reverting as this seems to be causing flake on the msan bot. See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ChromiumOS_MSan_Tests%2F260%2F%2B%2Frecipes%2Fsteps%2Finteractive_ui_tests%2F0%2Flogs%2FTabDragging__x2f_DetachToBrowserInSeparateDisplayTabDragControllerTest.DragSingleTabToSeparateWindowInSecondDisplay__x2f_0%2F0 for example: [ RUN ] TabDragging/DetachToBrowserInSeparateDisplayTabDragControllerTest.DragSingleTabToSeparateWindowInSecondDisplay/0 [9966:9966:0428/135949.114391:WARNING:chrome_browser_main_chromeos.cc(408)] Running as stub user with profile dir: test-user [9966:9966:0428/135949.955645:WARNING:audio_manager.cc(293)] Multiple instances of AudioManager detected [9966:9966:0428/135949.955736:WARNING:audio_manager.cc(254)] Multiple instances of AudioManager detected Xlib: extension "RANDR" missing on display ":99". Xlib: extension "RANDR" missing on display ":99". libva info: VA-API version 0.35.0 libva info: va_getDriverName() returns -1 libva error: va_getDriverName() failed with unknown libva error,driver_name=(null) [9997:9997:0428/135950.268268:WARNING:vaapi_wrapper.cc(1220)] vaInitialize failed: unknown libva error [9966:9987:0428/135950.394495:WARNING:freezer_cgroup_process_manager.cc(61)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes. ==9966==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0xb8902c5 in SkPaint::nothingToDraw() const third_party/skia/src/core/SkPaint.cpp:2328:17 #1 0x1e298854 in skia::AnalysisCanvas::onDrawRect(SkRect const&, SkPaint const&) skia/ext/analysis_canvas.cc:121:13 #2 0xc152180 in operator()<SkRecords::DrawRect> third_party/skia/src/core/SkRecordDraw.h:62:15 #3 0xc152180 in SkMiniPicture<SkRecords::DrawRect>::playback(SkCanvas*, SkPicture::AbortCallback*) const third_party/skia/src/core/SkMiniRecorder.cpp:55:0 #4 0xe99b5ad in cc::(anonymous namespace)::RasterItem(cc::DisplayItem const&, SkCanvas*, SkPicture::AbortCallback*) cc/paint/display_item_list.cc:105:21 #5 0xe99a627 in cc::DisplayItemList::Raster(SkCanvas*, SkPicture::AbortCallback*) const cc/paint/display_item_list.cc:188:5 #6 0xe99a025 in cc::DisplayItemList::Raster(SkCanvas*, SkPicture::AbortCallback*, gfx::Rect const&, float) const cc/paint/display_item_list.cc:175:3 #7 0x1044dd06 in cc::RecordingSource::DetermineIfSolidColor() cc/layers/recording_source.cc:152:18 #8 0x1044d4bb in cc::RecordingSource::FinishDisplayItemListUpdate() cc/layers/recording_source.cc:56:3 #9 0x1ee06f0f in cc::PictureLayer::Update() cc/layers/picture_layer.cc:130:24 #10 0x102e1014 in PaintContent cc/trees/layer_tree_host.cc:1066:33 #11 0x102e1014 in cc::LayerTreeHost::DoUpdateLayers(cc::Layer*) cc/trees/layer_tree_host.cc:716:0 #12 0x102df467 in cc::LayerTreeHost::UpdateLayers() cc/trees/layer_tree_host.cc:591:17 #13 0x103e12c9 in DoPainting cc/trees/single_thread_proxy.cc:705:21 #14 0x103e12c9 in cc::SingleThreadProxy::BeginMainFrame(cc::BeginFrameArgs const&) cc/trees/single_thread_proxy.cc:685:0 #15 0xd4f1335 in Run base/callback.h:91:12 #16 0xd4f1335 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:59:0 #17 0xd25eb93 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:423:19 #18 0xd260561 in base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) base/message_loop/message_loop.cc:434:5 #19 0xd26210e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:527:13 #20 0xd271a59 in HandleDispatch base/message_loop/message_pump_glib.cc:267:25 #21 0xd271a59 in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) base/message_loop/message_pump_glib.cc:109:0 #22 0x7f475b7653ce in g_main_dispatch /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3064:27 #23 0x7f475b7653ce in g_main_context_dispatch /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3663:0 #24 0x7f475b766686 in g_main_context_iterate /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3734:5 #25 0x7f475b766a1d in g_main_context_iteration /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3795:12 #26 0xd270fb3 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_glib.cc:309:30 #27 0xd25dc2b in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10 #28 0xd31d81c in base::RunLoop::Run() base/run_loop.cc:37:10 #29 0x1479f62d in ash::ToplevelWindowEventHandler::RunMoveLoop(aura::Window*, gfx::Vector2d const&, aura::client::WindowMoveSource) ash/wm/toplevel_window_event_handler.cc:99:12 #30 0xcaa4ced in views::NativeWidgetAura::RunMoveLoop(gfx::Vector2d const&, views::Widget::MoveLoopSource, views::Widget::MoveLoopEscapeBehavior) ui/views/widget/native_widget_aura.cc:707:20 #31 0x15221a1d in TabDragController::RunMoveLoop(gfx::Vector2d const&) chrome/browser/ui/views/tabs/tab_drag_controller.cc:1076:26 #32 0x1522a3f5 in TabDragController::DetachIntoNewBrowserAndRunMoveLoop(gfx::Point const&) chrome/browser/ui/views/tabs/tab_drag_controller.cc:1045:3 #33 0x1522693c in TabDragController::DragBrowserToNewTabStrip(TabStrip*, gfx::Point const&) chrome/browser/ui/views/tabs/tab_drag_controller.cc:565:5 #34 0x1522279d in TabDragController::ContinueDragging(gfx::Point const&) chrome/browser/ui/views/tabs/tab_drag_controller.cc:530:9 #35 0x1521a39f in TabDragController::Drag(gfx::Point const&) chrome/browser/ui/views/tabs/tab_drag_controller.cc:387:7 #36 0x15253741 in ContinueDrag chrome/browser/ui/views/tabs/tab_strip.cc:1221:23 #37 0x15253741 in non-virtual thunk to TabStrip::ContinueDrag(views::View*, ui::LocatedEvent const&) chrome/browser/ui/views/tabs/tab_strip.cc:0:0 #38 0x1520bb4b in OnMouseDragged chrome/browser/ui/views/tabs/tab.cc:893:16 #39 0x1520bb4b in non-virtual thunk to Tab::OnMouseDragged(ui::MouseEvent const&) chrome/browser/ui/views/tabs/tab.cc:0:0 #40 0xca25f95 in views::View::ProcessMouseDragged(ui::MouseEvent const&) ui/views/view.cc:2463:9 #41 0xca247a4 in views::View::OnMouseEvent(ui::MouseEvent*) ui/views/view.cc:1076:11 #42 0xebbd783 in DispatchEvent ui/events/event_dispatcher.cc:191:12 #43 0xebbd783 in ui::EventDispatcher::ProcessEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:139:0 #44 0xebbcbf8 in DispatchEventToTarget ui/events/event_dispatcher.cc:86:14 #45 0xebbcbf8 in ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:58:0 #46 0xca4021f in views::internal::RootView::OnMouseDragged(ui::MouseEvent const&) ui/views/widget/root_view.cc:422:9 #47 0xca5e71b in views::Widget::OnMouseEvent(ui::MouseEvent*) ui/views/widget/widget.cc:1239:22 #48 0xebbd783 in DispatchEvent ui/events/event_dispatcher.cc:191:12 #49 0xebbd783 in ui::EventDispatcher::ProcessEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:139:0 #50 0xebbcbf8 in DispatchEventToTarget ui/events/event_dispatcher.cc:86:14 #51 0xebbcbf8 in ui::EventDispatcherDelegate::DispatchEvent(ui::EventTarget*, ui::Event*) ui/events/event_dispatcher.cc:58:0 #52 0xebc594f in ui::EventProcessor::OnEventFromSource(ui::Event*) ui/events/event_processor.cc:46:15 #53 0xebc6f28 in DeliverEventToSink ui/events/event_source.cc:73:16 #54 0xebc6f28 in ui::EventSource::SendEventToSink(ui::Event*) ui/events/event_source.cc:51:0 #55 0x1ef37da4 in aura::WindowTreeHostX11::DispatchEvent(_XEvent* const&) ui/aura/window_tree_host_x11.cc:274:9 #56 0xeb9250c in ui::PlatformEventSource::DispatchEvent(_XEvent*) ui/events/platform/platform_event_source.cc:81:29 #57 0xed247b6 in ui::X11EventSource::ExtractCookieDataDispatchEvent(_XEvent*) ui/events/platform/x11/x11_event_source.cc:240:14 #58 0xed24471 in ui::X11EventSource::DispatchXEvents() ui/events/platform/x11/x11_event_source.cc:140:5 #59 0xed23c59 in ui::(anonymous namespace)::XSourceDispatch(_GSource*, int (*)(void*), void*) ui/events/platform/x11/x11_event_source_glib.cc:41:15 #60 0x7f475b7653ce in g_main_dispatch /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3064:27 #61 0x7f475b7653ce in g_main_context_dispatch /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3663:0 #62 0x7f475b766686 in g_main_context_iterate /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3734:5 #63 0x7f475b766a1d in g_main_context_iteration /home/tom/chromium/src/third_party/instrumented_libraries/scripts/out/Instrumented-msan-chained-origins-trusty/gen/third_party/instrumented_libraries/libglib2.0-0/glib2.0-2.40.2/glib/gmain.c:3795:12 #64 0xd270fb3 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_glib.cc:309:30 #65 0xd25dc2b in base::MessageLoop::RunHandler() base/message_loop/message_loop.cc:387:10 #66 0xd31d81c in base::RunLoop::Run() base/run_loop.cc:37:10 #67 0xd1464d in DetachToBrowserTabDragControllerTest::QuitWhenNotDragging() chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:527:23 #68 0xd7288e in DetachToBrowserInSeparateDisplayTabDragControllerTest_DragSingleTabToSeparateWindowInSecondDisplay_Test::RunTestOnMainThread() chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc:1812:3 #69 0xa860dfb in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:309:5 #70 0x94cd165 in Run base/callback.h:80:12 #71 0x94cd165 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1916:0 #72 0x94c8e14 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1257:18 #73 0x4c94b49 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() chrome/browser/chromeos/chrome_browser_main_chromeos.cc:506:32 #74 0x2771066 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:1161:13 #75 0x381ec1a in Run base/callback.h:80:12 #76 0x381ec1a in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45:0 #77 0x2768b24 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:956:25 #78 0x277f340 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:125:17 #79 0x275c35f in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:42:32 #80 0x934aeba in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:411:14 #81 0x934dadb in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:703:12 #82 0x10e02e92 in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:450:29 #83 0x9347727 in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 #84 0xa85fea0 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:265:3 #85 0x9479b7a in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:266:20 #86 0xc6c1a97 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12 #87 0xc6c1a97 in testing::Test::Run() testing/gtest/src/gtest.cc:2470:0 #88 0xc6c4a8b in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11 #89 0xc6c6029 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28 #90 0xc6e59cd in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43 #91 0xc6e485e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12 #92 0xc6e485e in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255:0 #93 0xd169eb0 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46 #94 0xd169eb0 in base::TestSuite::Run() base/test/test_suite.cc:271:0 #95 0xab1007 in InteractiveUITestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/interactive_ui_tests_main.cc:85:47 #96 0xa87dcab in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:520:31 #97 0xab0e43 in main chrome/test/base/interactive_ui_tests_main.cc:109:22 #98 0x7f4755681f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287:0 #99 0x4a0435 in _start ??:0:0 Original issue's description: > Fix an interactive ui test > > * Remove touch drag for a series of tests about tab dragging to the second display as, up to now, there's no use case. > > * Each display has its own UI controller in the test, but, in ozone build, they do not share the state of mouse (down, up). When the mouse is moved to the second display, the UI controller for it does know that the mouse is down in first display. That's why the tab cannot be dragged to the second display only in ozone build. Simple solution is to move the mouse state variable outside of UI controller class. > > BUG= 626769 > > Review-Url: https://codereview.chromium.org/2836073003 > Cr-Commit-Position: refs/heads/master@{#468048} > Committed: https://chromium.googlesource.com/chromium/src/+/171e2ebecd1cda288825631299b898d65b80f52e TBR=pkasting@chromium.org,sadrul@chromium.org,weidongg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 626769 Review-Url: https://codereview.chromium.org/2851333002 Cr-Commit-Position: refs/heads/master@{#468406} [modify] https://crrev.com/d1483ffaddd203a96a19c420061101ab9b2fcd48/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc [modify] https://crrev.com/d1483ffaddd203a96a19c420061101ab9b2fcd48/ui/aura/test/ui_controls_factory_ozone.cc
,
Aug 1 2017
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by tbuck...@chromium.org
, Oct 11 2016Status: Assigned (was: Untriaged)