Search Engine: Editing default search engine - > shouldn't be able to edit the word "default" |
||||||
Issue descriptionIf you edit your default search engine (manage search engine -> hamburger menu -> edit) you can actually edit the word "default". This is potentially confusing to people who saw the word default appear when they change their default search engine instead of manually writing it in.
,
Jul 11 2016
,
Jul 11 2016
,
Jul 11 2016
This is not just confusing, it is actually a bug. Try the following: 1) Find the default search engine and select "edit" from the popup menu. 2) Without changing the name "Google (Default)", click "save" in the dialog. Notice how the name changes to "Google (Default) (Default)", which is a bug.
,
Jul 12 2016
Agreed!
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17ea31cf6ab7e0ed11445feaf94e6b3352350e01 commit 17ea31cf6ab7e0ed11445feaf94e6b3352350e01 Author: dpapad <dpapad@chromium.org> Date: Wed Jul 13 03:47:10 2016 MD Settings: Fix editing name of default search engine. When editing the default search engine's name, the "(Default)" suffix should not be displayed in the textbox. BUG= 626767 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2144453002 Cr-Commit-Position: refs/heads/master@{#404979} [modify] https://crrev.com/17ea31cf6ab7e0ed11445feaf94e6b3352350e01/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js [modify] https://crrev.com/17ea31cf6ab7e0ed11445feaf94e6b3352350e01/chrome/test/data/webui/settings/search_engines_page_test.js
,
Jul 13 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17ea31cf6ab7e0ed11445feaf94e6b3352350e01 commit 17ea31cf6ab7e0ed11445feaf94e6b3352350e01 Author: dpapad <dpapad@chromium.org> Date: Wed Jul 13 03:47:10 2016 MD Settings: Fix editing name of default search engine. When editing the default search engine's name, the "(Default)" suffix should not be displayed in the textbox. BUG= 626767 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2144453002 Cr-Commit-Position: refs/heads/master@{#404979} [modify] https://crrev.com/17ea31cf6ab7e0ed11445feaf94e6b3352350e01/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js [modify] https://crrev.com/17ea31cf6ab7e0ed11445feaf94e6b3352350e01/chrome/test/data/webui/settings/search_engines_page_test.js |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sheriffbot@chromium.org
, Jul 9 2016