Master bug for eliminating this interface and adjusting all embedder call sites to go through WebContents, RenderWidgetHost(View), ViewAndroid, etc. instead.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77e87e6a068ab2297d4107bd38f81de4d24eebee commit 77e87e6a068ab2297d4107bd38f81de4d24eebee Author: sievers <sievers@chromium.org> Date: Fri Jul 29 21:34:00 2016 Android: Remove ContentViewCore::GetLayer() from public interface This removes some native references to ContentViewCore from the embedder, which were mostly unnecessary indirections and can use WebContents directly. BUG= 626764 Review-Url: https://codereview.chromium.org/2179563003 Cr-Commit-Position: refs/heads/master@{#408772} [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/chrome/browser/android/compositor/tab_content_manager.cc [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/chrome/browser/android/compositor/tab_content_manager.h [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/chrome/browser/android/contextualsearch/contextual_search_delegate.cc [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/chrome/browser/android/contextualsearch/contextual_search_delegate.h [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/chrome/browser/android/contextualsearch/contextual_search_manager.cc [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/chrome/browser/android/contextualsearch/contextual_search_manager.h [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/chrome/browser/android/tab_android.cc [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/chrome/browser/android/tab_android.h [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/content/browser/android/content_view_core_impl.cc [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/content/browser/android/content_view_core_impl.h [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/content/browser/android/content_view_render_view.cc [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/content/browser/android/content_view_render_view.h [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java [modify] https://crrev.com/77e87e6a068ab2297d4107bd38f81de4d24eebee/content/public/browser/android/content_view_core.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/834eaab8e927945d5b0d9bb60282a1733d50256f commit 834eaab8e927945d5b0d9bb60282a1733d50256f Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Fri Jun 23 16:54:38 2017 Do not use native CVC in embedders Native interface ContentViewCore is going away. This CL replaces it usage in embedders with WebContents/ViewAndroid in preparation of the deletion. This CL make changes to media-related part. BUG= 626764 Change-Id: I4afee7e603d8ea9d801f09e7f2a5ef27faf2dd68 Reviewed-on: https://chromium-review.googlesource.com/543081 Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#481931} [modify] https://crrev.com/834eaab8e927945d5b0d9bb60282a1733d50256f/chrome/browser/media/android/remote/remote_media_player_bridge.cc [modify] https://crrev.com/834eaab8e927945d5b0d9bb60282a1733d50256f/chrome/browser/media/webrtc/media_stream_devices_controller.cc [modify] https://crrev.com/834eaab8e927945d5b0d9bb60282a1733d50256f/content/browser/media/android/browser_media_player_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4ded7ec6f0654f0536073af9ab94722dd02498c commit c4ded7ec6f0654f0536073af9ab94722dd02498c Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Fri Jun 23 21:14:56 2017 Add viewport size from frame info to ViewAndroid Adding viewport size from frame info to ViewAndroid in prepration of replacing all the usage of native ContentViewCore with ViewAndroid. See https://crrev.com/c/536895 for how it will be used. Also changed the type of ViewAndroid::content_offset to float, since x part of the prevsious type (Vector2df) is not in use. BUG= 626764 Change-Id: Idd8489e554d803fd194d1ecf046ac2793aad1087 Reviewed-on: https://chromium-review.googlesource.com/546216 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#482034} [modify] https://crrev.com/c4ded7ec6f0654f0536073af9ab94722dd02498c/content/browser/android/content_view_core_impl.cc [modify] https://crrev.com/c4ded7ec6f0654f0536073af9ab94722dd02498c/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/c4ded7ec6f0654f0536073af9ab94722dd02498c/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/c4ded7ec6f0654f0536073af9ab94722dd02498c/ui/android/view_android.cc [modify] https://crrev.com/c4ded7ec6f0654f0536073af9ab94722dd02498c/ui/android/view_android.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd8a5a3348315e3527c27bacca9cc1b65fdb3848 commit cd8a5a3348315e3527c27bacca9cc1b65fdb3848 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Tue Jun 27 18:48:06 2017 Define ui::FrameInfo for frame metadata ViewAndroid stores the view-related frame metadata in a new struct defined in this class. Moved the fields that have been stored individually in ViewAndroid, and added |page_scale| for facilitating css-to-pix conversion in embedders. BUG= 626764 Change-Id: I7b53e5559a4ca572de7fa9142a649ce0c18670ec Reviewed-on: https://chromium-review.googlesource.com/549636 Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#482695} [modify] https://crrev.com/cd8a5a3348315e3527c27bacca9cc1b65fdb3848/content/browser/android/content_view_core_impl.cc [modify] https://crrev.com/cd8a5a3348315e3527c27bacca9cc1b65fdb3848/content/browser/android/content_view_core_impl.h [modify] https://crrev.com/cd8a5a3348315e3527c27bacca9cc1b65fdb3848/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/cd8a5a3348315e3527c27bacca9cc1b65fdb3848/ui/android/view_android.cc [modify] https://crrev.com/cd8a5a3348315e3527c27bacca9cc1b65fdb3848/ui/android/view_android.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e07c1ee92347dd08e58e5e425c311eb665b03f3 commit 4e07c1ee92347dd08e58e5e425c311eb665b03f3 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Wed Jun 28 18:55:20 2017 Do not use native CVC in embedders in chrome/ Native interface ContentViewCore is going away. This CL replaces it usage in embedders with WebContents/ViewAndroid in preparation of the deletion. BUG= 626764 Change-Id: I6d8d255e054af63d085dae72238c5085f629bfef Reviewed-on: https://chromium-review.googlesource.com/547415 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#483082} [modify] https://crrev.com/4e07c1ee92347dd08e58e5e425c311eb665b03f3/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java [modify] https://crrev.com/4e07c1ee92347dd08e58e5e425c311eb665b03f3/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java [modify] https://crrev.com/4e07c1ee92347dd08e58e5e425c311eb665b03f3/chrome/android/java/src/org/chromium/chrome/browser/widget/ContextMenuDialog.java [modify] https://crrev.com/4e07c1ee92347dd08e58e5e425c311eb665b03f3/chrome/browser/permissions/permission_update_infobar_delegate_android.cc [modify] https://crrev.com/4e07c1ee92347dd08e58e5e425c311eb665b03f3/chrome/browser/supervised_user/child_accounts/child_account_service_android.cc [modify] https://crrev.com/4e07c1ee92347dd08e58e5e425c311eb665b03f3/chrome/browser/ui/android/bluetooth_chooser_android.cc [modify] https://crrev.com/4e07c1ee92347dd08e58e5e425c311eb665b03f3/chrome/browser/ui/android/context_menu_helper.cc [modify] https://crrev.com/4e07c1ee92347dd08e58e5e425c311eb665b03f3/chrome/browser/ui/android/usb_chooser_dialog_android.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/33dbb18a885ca3abab18cbda03706dd89df4dc4b commit 33dbb18a885ca3abab18cbda03706dd89df4dc4b Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Thu Jun 29 03:31:10 2017 Do not use native CVC in embedders in component/ Native interface ContentViewCore is going away. This CL replaces it usage in embedders with WebContents/ViewAndroid in preparation of the deletion. BUG= 626764 Change-Id: I115c1de5d8d9cf15fe6d4c4e1208341477711232 Reviewed-on: https://chromium-review.googlesource.com/547056 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#483280} [modify] https://crrev.com/33dbb18a885ca3abab18cbda03706dd89df4dc4b/components/web_contents_delegate_android/DEPS [modify] https://crrev.com/33dbb18a885ca3abab18cbda03706dd89df4dc4b/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ColorChooserAndroid.java [modify] https://crrev.com/33dbb18a885ca3abab18cbda03706dd89df4dc4b/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/ValidationMessageBubble.java [modify] https://crrev.com/33dbb18a885ca3abab18cbda03706dd89df4dc4b/components/web_contents_delegate_android/color_chooser_android.cc [modify] https://crrev.com/33dbb18a885ca3abab18cbda03706dd89df4dc4b/components/web_contents_delegate_android/validation_message_bubble_android.cc [modify] https://crrev.com/33dbb18a885ca3abab18cbda03706dd89df4dc4b/components/web_contents_delegate_android/validation_message_bubble_android.h [modify] https://crrev.com/33dbb18a885ca3abab18cbda03706dd89df4dc4b/components/web_contents_delegate_android/web_contents_delegate_android.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/599cfca2b34a94ee0563af466f04a3a933b31bd1 commit 599cfca2b34a94ee0563af466f04a3a933b31bd1 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Thu Jul 06 06:36:51 2017 Remove unnecessary #include's Removes #include "..content_view_core.h" that are not in use. BUG= 626764 Change-Id: If8e63a00474ddaab4a85c6c50c14e72015db1563 Reviewed-on: https://chromium-review.googlesource.com/554731 Reviewed-by: Brett Wilson <brettw@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#484482} [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/android_webview/browser/aw_autofill_client.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/android_webview/browser/aw_contents.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/android_webview/browser/renderer_host/aw_render_view_host_ext.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/chrome/browser/android/bottombar/overlay_panel_content.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/chrome/browser/android/bottombar/overlay_panel_content.h [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/chrome/browser/android/compositor/compositor_view.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.h [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/chrome/browser/android/compositor/scene_layer/toolbar_scene_layer.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/chrome/browser/android/contextualsearch/contextual_search_delegate.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/chrome/browser/android/contextualsearch/contextual_search_delegate.h [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/chrome/browser/android/web_contents_factory.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/content/browser/android/browser_jni_registrar.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/content/browser/android/content_video_view.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/content/browser/android/nfc_host.cc [modify] https://crrev.com/599cfca2b34a94ee0563af466f04a3a933b31bd1/content/shell/browser/shell_web_contents_view_delegate_android.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d commit 447a719920ef8b6e3ac337b6ecf9ae4afdceca7d Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Sun Jul 16 18:17:41 2017 Delete native ContentViewCore interface This removes all the public native references to ContentViewCore from the embedder, which were indirections that became unnecessary. Now they can be handled by using WebContents, passing container view or view-specific coordinates values instead. For many parts, changes were made so that these values are converted from css to device pixel unit right before being passed up to Java layer. I think it helps the two units avoid being mixed in the code. BUG= 626764 Change-Id: I7348c9aea00cde93f976d1bae3779270826dce03 Reviewed-on: https://chromium-review.googlesource.com/536895 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#487016} [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/chrome/browser/android/signin/signin_promo_util_android.cc [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/chrome/browser/android/signin/signin_promo_util_android.h [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/BUILD.gn [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/android/content_video_view.h [rename] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/android/content_view_core.cc [rename] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/android/content_view_core.h [delete] https://crrev.com/3de608576703311817c69a8a64bdbc4feb87519b/content/browser/android/content_view_core_impl_observer.h [add] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/android/content_view_core_observer.h [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/android/dialog_overlay_impl.cc [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/android/dialog_overlay_impl.h [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/media/android/browser_media_player_manager.cc [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/media/android/browser_surface_view_manager.cc [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/renderer_host/input/synthetic_gesture_target_android.cc [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/renderer_host/render_widget_host_view_android.cc [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/renderer_host/render_widget_host_view_android.h [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/screen_orientation/screen_orientation_delegate_android.cc [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/web_contents/web_contents_android.cc [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/web_contents/web_contents_view_android.cc [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/browser/web_contents/web_contents_view_android.h [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/public/android/BUILD.gn [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java [modify] https://crrev.com/447a719920ef8b6e3ac337b6ecf9ae4afdceca7d/content/public/browser/BUILD.gn [delete] https://crrev.com/3de608576703311817c69a8a64bdbc4feb87519b/content/public/browser/android/content_view_core.h
Comment 1 by siev...@chromium.org
, Jul 8 2016