New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626740 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Make WPT manual test import conditional on matching wpt-automation script

Project Member Reported by rbyers@chromium.org, Jul 8 2016

Issue description

Previously we skipped importing all -manual.html web-platform-tests.
Now "manual" pointer events tests are being imported and automated via a matching testname-input.js file in LayoutTests/imported/wpt_automation.

Currently this is done with this code in deps_updater.py:

    def is_manual_test(self, fs, dirname, basename):
        return ("pointerevents" not in dirname) and (basename.endswith('-manual.html') or basename.endswith('-manual.htm'))

https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py?rcl=0&l=196

Let's generalize this so that more teams can easily use it.  Eg. maybe rename the "-input" files to something more generic ("-automation.js" maybe?).  Then deps_updater.py can permit manual tests which happen to already have a corresponding -automation.js file in wpt_automation.  Thoughts?
 
Cc: raikiri@google.com dcampb@google.com
Makes sense to me :-D

This could just be a change in is_manual_test which checks `fs.isfile(self.path_from_webkit_base('LayoutTests', 'imported', 'wpt_automation', '...'))` or something like that.
Owner: qyears...@chromium.org
Status: Started (was: Available)
Uploaded a CL for this: http://crrev.com/2132273002
I have a couple questions, related to this issue:

 1. After Navid's change http://crrev.com/1994683004 we have local modifications to LayoutTests/resources/testharnessreport.js, which means that each time wpt is updated to reflect the copy in w3c/web-platform-tests, the two copies of testharnessreport.js will be out of sync. I believe this has made it so that wpt can't be updated now without making the presubmit fail.

Is there some way that we can inject synthetic input when running the tests via some other way than testharnessreport.js, or do we *want* to have our own separate and different copy of testharnessreport.js? This is related to  bug 625846 .

2. Do we want to rename *-input.js to *-automation.js?

Comment 5 by rbyers@chromium.org, Jul 12 2016

1.  Ugh, really?  I thought testharnessreport.js was the ONE place we were supposed to customize?  From the comments at the top of that file:

 * This file is intended for vendors to implement
 * code needed to integrate testharness.js tests with their own test systems.

We should come up with some pattern for customizing the file, even if we want to start with the default one.

2. Let's discuss on your CL: https://codereview.chromium.org/2142283002/
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08a8c723d6bc4fb6d57800677df1b86f6ec909e8

commit 08a8c723d6bc4fb6d57800677df1b86f6ec909e8
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Jul 13 17:42:05 2016

Rename *-input.js -> *-automation.js in wpt_automation.

BUG= 626740 

Review-Url: https://codereview.chromium.org/2142283002
Cr-Commit-Position: refs/heads/master@{#405214}

[modify] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt/resources/testharnessreport.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_button_attribute_mouse-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_mouse-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_capture_suppressing_mouse-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_change-touch-action-onpointerdown_touch-manual-automation.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_gotpointercapture_before_first_pointerevent-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_gotpointercapture_before_first_pointerevent-manual-input.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_lostpointercapture_for_disconnected_node-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_lostpointercapture_is_first-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointercancel_touch-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerdown-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerenter-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerenter_does_not_bubble-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerenter_nohover-manual-automation.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_after_pointercancel_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_after_pointerup_nohover-manual-input.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_descendant_over-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_descendants-manual-automation.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_does_not_bubble-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_does_not_bubble-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_mouse-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_pen-manual-automation.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerleave_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointermove-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointermove-manual-input.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointermove_isprimary_same_as_pointerdown-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointermove_pointertype-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout-manual-input.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_after_pointercancel_touch-manual-automation.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_after_pointerup_nohover-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_pen-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_pen-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_received_once-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerout_received_once-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerover-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerover-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointertype_mouse-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointertype_mouse-manual-input.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointertype_pen-manual-automation.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointertype_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointertype_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerup-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerup-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerup_isprimary_same_as_pointerdown-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerup_isprimary_same_as_pointerdown-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerup_pointertype-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_pointerup_pointertype-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_events_to_original_target-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_events_to_original_target-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_invalid_pointerid-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_invalid_pointerid-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch-manual-input.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse-manual-automation.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_disconnected-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_disconnected-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_inactive_button_mouse-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_inactive_button_mouse-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_invalid_pointerid-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_invalid_pointerid-manual-input.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_setpointercapture_relatedtarget-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-auto-css_touch-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-button-test_touch-manual-automation.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual-input.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-keyboard-manual-automation.js
[rename] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-mouse-manual-automation.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-none-css_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-none-css_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-span-test_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-span-test_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-svg-test_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-svg-test_touch-manual-input.js
[copy] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-automation.js
[delete] https://crrev.com/f3c4a58fcc70cd3384020708ce3ff50d847654ba/third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_touch-action-table-test_touch-manual-input.js
[modify] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/LayoutTests/resources/testharnessreport.js
[modify] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
[modify] https://crrev.com/08a8c723d6bc4fb6d57800677df1b86f6ec909e8/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

Status: Fixed (was: Started)
Re #5: Oh, I didn't see that testharnessreport.js was intended to be place for vendor-specific customizations. Given that, that seems like the right place for injecting synthetic input.

We should follow up and decide what to do in  issue 625846 ; meanwhile, I think this bug is considered done now.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8313c6bc7a7b916b6e56d987a6110a5936aa47c8

commit 8313c6bc7a7b916b6e56d987a6110a5936aa47c8
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Jul 15 18:03:12 2016

Fix is_manual_test for files with no file extension.

In http://crrev.com/2132273002, I made an assumption that all
files have a "." character, which is incorrect. This is a follow-up
fix for that mistake.

BUG= 626740 

Review-Url: https://codereview.chromium.org/2144343002
Cr-Commit-Position: refs/heads/master@{#405790}

[modify] https://crrev.com/8313c6bc7a7b916b6e56d987a6110a5936aa47c8/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
[modify] https://crrev.com/8313c6bc7a7b916b6e56d987a6110a5936aa47c8/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

Components: Blink>Infra>Predictability
Labels: -Hotlist-PredictabilityInfra
Components: -Blink>Infra
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment