New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626739 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Payments-Maintenance


Sign in to add a comment

Credit card unmask dialog title is not being displayed

Project Member Reported by jdonnelly@chromium.org, Jul 8 2016

Issue description

See attached screenshot. The title "Verify Card" should be displayed between the "CANCEL" and "VERIFY" buttons.

Steps to reproduce:
1. You must be logged in to Chrome with a gmail.com or google.com account.
2. You must have a credit card in Google Payments. To add a card, visit https://payments.google.com, navigate to "Payment methods" and then choose "Add a payment method".
3. You must have "Show addresses and credit cards from Google Payments" enabled in the autofill settings.
4. Visit https://rsolomakhin.github.io/autofill/.
5. Select the "Name on card" field in the Credit Card autofill form.
6. The credit card(s) you have in Payments should appear as chips in the keyboard accessory above the keyboard. Select one of them.
7. The unmask dialog should appear.

This is a regression that seems to probably have been introduced by either https://chromereviews.googleplex.com/434547013, https://chromereviews.googleplex.com/457677016, or a combination of both.
 
Screen Shot 2016-07-08 at 11.34.09 AM.png
61.2 KB View Download

Comment 1 by pkl@chromium.org, Jul 11 2016

Cc: lpromero@chromium.org
Labels: M-53
Owner: rohitrao@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 12 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: hwi@chromium.org pschaffner@chromium.org jdonnelly@chromium.org
I guess it's worth asking whether we still need a title here in light of the changes to this dialog over time?

The action button is VERIFY and the text in the dialog now says, "Enter the CVC for Visa - 5679. Once you confirm, your card details will be shared with this site." Do we need another string that says "Verify Card"?

pschaffner, hwi, what do you think?

Comment 4 by hwi@chromium.org, Jul 20 2016

Thanks jdonnelly@

Options

1. Card Details
2. CVC
3. [blank]: Feels a bit like a bug. 

1 or 2 are my preferred option. Wdyt, jdonnelly@, zkoch@, pschaffner@?

The reason why I was thinking about the possibility of no title is that I noticed the main settings dialog has a similar big empty space in the middle. Granted, it *does* have a title ("Settings") it's just that there's only one button so the title is aligned all the way to the left.

But given that you prefer we keep the title, which is fine, these new options ("CVC" and "Card Details") don't seem necessarily better than the existing title ("Verify Card"). We should just fix the bug to get that back.
Components: UI>Browser>Autofill
Cc: -jdonnelly@chromium.org
Owner: mahmadi@chromium.org
mahmadi: I don't know if this issue is still present. Can you verify?
Components: UI>Browser>Autofill>Payments
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
Status: Untriaged (was: Assigned)

Comment 11 by se...@chromium.org, May 29 2018

Status: Assigned (was: Untriaged)

Sign in to add a comment