New issue
Advanced search Search tips

Issue 626733 link

Starred by 4 users
Status: Fixed
Owner:
erikc...@chromium.org
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 477124
issue 579255



Sign in to add a comment

Remove NSWindowHostsLayersInWindowServer workaround

Project Member Reported by mark@chromium.org, Jul 8 2016 
Mentioned during review of https://codereview.chromium.org/2137453003:

content/app/mac/mac_init.mm has this workaround:

      // CoreAnimation has poor performance and CoreAnimation and
      // non-CoreAnimation exhibit window flickering when layers are not hosted
      // in the window server, which is the default when not not using the
      // 10.9 SDK.
      // TODO: Remove this when we build with the 10.9 SDK.
      @"NSWindowHostsLayersInWindowServer": @YES

We’re on the 10.10 SDK now (but the deployment target still hasn’t quite made it to 10.9). Are we able to remove this workaround?

Comment 1 by ccameron@chromium.org, Jul 8 2016 

Fairly certain, but not 100% sure.

To test, probably
* run with --disable-mac-overlays
* open 5 instances of https://webkit.org/blog-files/3d-transforms/poster-circle.html 
* see if performance is okay (it'll be terrible if this is still an issue).

That works fine locally, *but* this setting seemed to be "sticky" on my machine.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e488739b2d5698ef40af30de34ad30daca2621a

commit 2e488739b2d5698ef40af30de34ad30daca2621a
Author: erikchen <erikchen@chromium.org>
Date: Wed Nov 02 17:49:45 2016

Remove NSWindowHostsLayersInWindowServer workaround.

It was only necessary before Chrome started building against the macOS 10.9 SDK.

BUG= 626733 

Review-Url: https://codereview.chromium.org/2471523003
Cr-Commit-Position: refs/heads/master@{#429328}

[modify] https://crrev.com/2e488739b2d5698ef40af30de34ad30daca2621a/content/app/mac/mac_init.mm

Comment 3 by erikc...@chromium.org, Nov 2 2016

Owner: erikc...@chromium.org
Status: Fixed (was: Assigned)

Comment 4 by tapted@chromium.org, Jul 17 2017

Blocking: 477124
►

Sign in to add a comment