New issue
Advanced search Search tips

Issue 626662 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Report Fraction of touch scrolls blocked on main thread via UMA

Project Member Reported by tdres...@chromium.org, Jul 8 2016

Issue description

We report the fraction of touch events sent to the main thread which block scroll (Event.PassiveListeners), but not the fraction of all touch scrolls which are blocked on main.

We should measure this!
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24b30bfd5ac15c60a29477638c91ab0fb8159055

commit 24b30bfd5ac15c60a29477638c91ab0fb8159055
Author: sahel <sahel@chromium.org>
Date: Tue Jan 24 00:05:32 2017

UMA metrics for fractions of wheel and touch scrolls blocked on the main thread.

BUG= 626662 ,  626663 
TEST=InputHandlerProxyTest.GestureScrollingThreadStatusHistograms,
     InputHandlerProxyTest.WheelScrollingThreadStatusHistograms

Review-Url: https://codereview.chromium.org/2636583002
Cr-Commit-Position: refs/heads/master@{#445551}

[modify] https://crrev.com/24b30bfd5ac15c60a29477638c91ab0fb8159055/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/24b30bfd5ac15c60a29477638c91ab0fb8159055/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/24b30bfd5ac15c60a29477638c91ab0fb8159055/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/24b30bfd5ac15c60a29477638c91ab0fb8159055/ui/events/blink/input_handler_proxy_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f4f936297a58457a6726d361bcb013e45ade2a2

commit 9f4f936297a58457a6726d361bcb013e45ade2a2
Author: dbeam <dbeam@chromium.org>
Date: Tue Jan 24 06:34:12 2017

Revert "UMA metrics for fractions of wheel and touch scrolls blocked on the main thread."

This reverts commit 24b30bfd5ac15c60a29477638c91ab0fb8159055.

Broke events_unittests on Linux Tests (dbg)(1)(32):
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)(32)

With a problem of:

AnimateInput/InputHandlerProxyTest.GestureScrollingThreadStatusHistograms/0 (run #1):
[ RUN      ] AnimateInput/InputHandlerProxyTest.GestureScrollingThreadStatusHistograms/0
[6128:6128:0123/172239.190828:1350397596:FATAL:input_handler_proxy.cc(797)] Check failed: !expect_scroll_update_end_.

TBR=sahel@chromium.org,dtapuska@chromium.org,tdresser@chromium.org,holte@chromium.org
BUG= 626662 , 626663 
NOTRY=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2650943004
Cr-Commit-Position: refs/heads/master@{#445666}

[modify] https://crrev.com/9f4f936297a58457a6726d361bcb013e45ade2a2/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/9f4f936297a58457a6726d361bcb013e45ade2a2/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/9f4f936297a58457a6726d361bcb013e45ade2a2/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/9f4f936297a58457a6726d361bcb013e45ade2a2/ui/events/blink/input_handler_proxy_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4ff2064283bc966a9de8b8c391dc8a3b168233d

commit b4ff2064283bc966a9de8b8c391dc8a3b168233d
Author: sahel <sahel@chromium.org>
Date: Tue Jan 24 21:38:55 2017

Re-landing "UMA metrics for fractions of wheel and touch scrolls blocked on the main thread."

The original review-URL is https://codereview.chromium.org/2636583002
It got reverted because unittests were failing in Linux_Tests (dbg).

I changed the tests to call ScrollEnd before calling ScrollBegin
for the second time.

TBR=holte@chromium.org
BUG= 626662 ,  626663 
TEST=InputHandlerProxyTest.GestureScrollingThreadStatusHistogram,
     InputHandlerProxyTest.WheelScrollingThreadStatusHistogram

Review-Url: https://codereview.chromium.org/2651883007
Cr-Commit-Position: refs/heads/master@{#445826}

[modify] https://crrev.com/b4ff2064283bc966a9de8b8c391dc8a3b168233d/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/b4ff2064283bc966a9de8b8c391dc8a3b168233d/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/b4ff2064283bc966a9de8b8c391dc8a3b168233d/ui/events/blink/input_handler_proxy.h
[modify] https://crrev.com/b4ff2064283bc966a9de8b8c391dc8a3b168233d/ui/events/blink/input_handler_proxy_unittest.cc

Comment 5 by sahel@chromium.org, Jan 25 2017

Status: Fixed (was: Assigned)

Sign in to add a comment