Clean up some lint errors |
||
Issue descriptionRemove unused code which is coming up in lint
,
Jul 8 2016
Which code is that? ☺
,
Jul 8 2016
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:12 The resource `R.color.input_underline_color` appears to be unused: UnusedResources [warning]
<color name="input_underline_color">#e5e5e5</color>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/colors.xml:113 The resource `R.color.snippets_background_color` appears to be unused: UnusedResources [warning]
<color name="snippets_background_color">#fff</color>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:225 The resource `R.dimen.toolbar_elevation` appears to be unused: UnusedResources [warning]
<dimen name="toolbar_elevation">2dp</dimen>
~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:254 The resource `R.dimen.omnibox_suggestion_answer_image_vertical_spacing` appears to be unused: UnusedResourc
es [warning]
<dimen name="omnibox_suggestion_answer_image_vertical_spacing">5dp</dimen>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chrome/android/java/res/values/dimens.xml:295 The resource `R.dimen.snippets_card_elevation` appears to be unused: UnusedResources [warning]
<dimen name="snippets_card_elevation">2dp</dimen>
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8448997bb54bba94e8999f0af995b2d06bae2818 commit 8448997bb54bba94e8999f0af995b2d06bae2818 Author: mcwilliams <mcwilliams@chromium.org> Date: Fri Jul 08 15:47:23 2016 Remove unused code that is causing lint warnings A number of unused variables are causing lint errors - removing these ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ chrome/android/java/res/values/colors.xml:12 The resource `R.color.input_underline_color` appears to be unused: UnusedResources [warning] <color name="input_underline_color">#e5e5e5</color> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ chrome/android/java/res/values/colors.xml:113 The resource `R.color.snippets_background_color` appears to be unused: UnusedResources [warning] <color name="snippets_background_color">#fff</color> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ chrome/android/java/res/values/dimens.xml:225 The resource `R.dimen.toolbar_elevation` appears to be unused: UnusedResources [warning] <dimen name="toolbar_elevation">2dp</dimen> ~~~~~~~~~~~~~~~~~~~~~~~~ chrome/android/java/res/values/dimens.xml:295 The resource `R.dimen.snippets_card_elevation` appears to be unused: UnusedResources [warning] <dimen name="snippets_card_elevation">2dp</dimen> Modify the vertical offset to use the correct value https://codereview.chromium.org/2020403003 BUG= 626655 Review-Url: https://codereview.chromium.org/2129193002 Cr-Commit-Position: refs/heads/master@{#404397} [modify] https://crrev.com/8448997bb54bba94e8999f0af995b2d06bae2818/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/8448997bb54bba94e8999f0af995b2d06bae2818/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/8448997bb54bba94e8999f0af995b2d06bae2818/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
,
Jul 8 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by mcwilliams@chromium.org
, Jul 8 2016