Regression: Unnecessary ‘embedded on* ‘ is seen for added link in ’chrome://md-settings/siteSettings/location’
Reported by
dmascare...@etouch.net,
Jul 8 2016
|
|||||
Issue descriptionChrome Version:54.0.2791.0 05f35eab096fe52eab3af2c6db191c1285dc5a68-refs/heads/master@{#404283} (32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://md-settings/siteSettings/location 2. Add link (such as https://permission.site/) into exception and observe Actual: Unnecessary ‘embedded on* ‘ is seen for added link Expected: ‘embedded on*’ should not be seen. This is regression issue,broken in ‘M 53’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/64acfeb29cfa3ac2dd7e98d3946fafce7ae2aeaa..82a45a85f0b2a9292d9524e90cc82ee3da68d876?pretty=fuller&n=100 Suspecting: r397819 Good build:53.0.2751.0 Bad build:53.0.2753.0
,
Jul 12 2016
@finnur: Gentle Ping!
,
Jul 18 2016
Just to update, Issue is still observed on Dev build 53.0.2785.8 and Canary build 54.0.2799.0 on Windows 7, MAC 10.11.5, Ubuntu 14.04. Issue is marked with a stable blocker and M53 is going to pushed to beta soon, @finnur: Request you to please take a look into it. If not a blocker, kindly request you to remove the blocker label Thanks.!
,
Jul 21 2016
@finnur: Gentle Ping. Still able to repro this issue on Chrome Canary Version - 54.0.2803.0
,
Jul 25 2016
finnur@, Could you please check the issue and update, this issue marked as RBS and tagged for M53.
,
Aug 1 2016
@finnur: Gentle Ping. Still able to repro this issue on Chrome Canary Version - 54.0.2815.0
,
Aug 3 2016
M53 Stable launch is coming soon.Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix asap so it gets chance to bake in beta before stable promotion. Thank you.
,
Aug 5 2016
@finnur: Gentle Ping. Still able to repro this issue on Chrome Canary Version - 54.0.2820.0
,
Aug 5 2016
,
Aug 9 2016
@finnur: Gentle Ping. Could you please provide an update on this issue. Thank you.
,
Aug 9 2016
Just got back from vacation yesterday. Submitted a fix for review yesterday, about to check in today.
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82e5d1649102d7bc18c98d3330396c5821eeea25 commit 82e5d1649102d7bc18c98d3330396c5821eeea25 Author: finnur <finnur@chromium.org> Date: Tue Aug 09 11:28:41 2016 MD Settings Desktop: Set embedder when adding exceptions. BUG= 626628 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2226613003 Cr-Commit-Position: refs/heads/master@{#410632} [modify] https://crrev.com/82e5d1649102d7bc18c98d3330396c5821eeea25/chrome/browser/resources/settings/site_settings/add_site_dialog.js
,
Aug 9 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by msrchandra@chromium.org
, Jul 8 2016