Recent updates to the Push API renamed the PushSubscriptionOptions dictionary to PushSubscriptionOptionsInit, and instead introduced a PushSubscriptionOptions interface which should be exposed as an attribute on PushSubscription objects, reflecting the options that were passed in when subscribing. See commits: https://github.com/w3c/push-api/commit/3f7aaed45680818d6c472e6b6bce8854e0c9bff2 https://github.com/w3c/push-api/commit/5c25fee2dcaecb140d78566ac26207ee602a6844 https://github.com/w3c/push-api/commit/428f4c5c8993fc6af82f1ea9194e1bb1cbec2feb
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8882a829851f9bfe6e1857c9d8b0a7c679d89c00 commit 8882a829851f9bfe6e1857c9d8b0a7c679d89c00 Author: johnme <johnme@chromium.org> Date: Fri Jul 15 13:13:47 2016 Push API: Implement and ship PushSubscription.options Intent to implement and ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/ysEXU21Dn1Y/discussion Recent updates to the Push API renamed the PushSubscriptionOptions dictionary to PushSubscriptionOptionsInit, and instead introduced a PushSubscriptionOptions interface which should be exposed as an attribute on PushSubscription objects, reflecting the options that were passed in when subscribing. See commits: https://github.com/w3c/push-api/commit/3f7aaed45680818d6c472e6b6bce8854e0c9bff2 https://github.com/w3c/push-api/commit/5c25fee2dcaecb140d78566ac26207ee602a6844 https://github.com/w3c/push-api/commit/428f4c5c8993fc6af82f1ea9194e1bb1cbec2feb This patch implements those changes. BUG= 626627 Review-Url: https://codereview.chromium.org/2133673002 Cr-Commit-Position: refs/heads/master@{#405752} [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/content/browser/push_messaging/push_messaging_message_filter.cc [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/content/browser/push_messaging/push_messaging_message_filter.h [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/content/child/push_messaging/push_provider.cc [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/content/child/push_messaging/push_provider.h [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/content/common/push_messaging_messages.h [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/content/renderer/push_messaging/push_messaging_dispatcher.cc [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/content/renderer/push_messaging/push_messaging_dispatcher.h [add] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/LayoutTests/http/tests/push_messaging/push-subscription-options.html [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/Source/modules/modules.gypi [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/Source/modules/push_messaging/PushManager.cpp [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/Source/modules/push_messaging/PushManager.h [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/Source/modules/push_messaging/PushManager.idl [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/Source/modules/push_messaging/PushManagerTest.cpp [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/Source/modules/push_messaging/PushSubscription.h [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/Source/modules/push_messaging/PushSubscription.idl [add] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.cpp [add] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.h [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptions.idl [add] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionOptionsInit.idl [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/public/platform/modules/push_messaging/WebPushSubscription.h [modify] https://crrev.com/8882a829851f9bfe6e1857c9d8b0a7c679d89c00/third_party/WebKit/public/platform/modules/push_messaging/WebPushSubscriptionOptions.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd11513c44ebc8ed0d5da23b9a1b96e17050deea commit dd11513c44ebc8ed0d5da23b9a1b96e17050deea Author: johnme <johnme@chromium.org> Date: Mon Jul 18 11:38:34 2016 Mark PushSubscriptionOptions not in WebView https://codereview.chromium.org/2133673002 added a new PushSubscriptionOptions interface, but forgot to mark it as not exposed in WebView (since the Push API is not supported there). Hence that patch broke WebViewLayoutTest#testWebViewIncludedStableInterfaces. This patch fixes that. BUG= 626627 , 629049 TBR=lizeb@chromium.org,timvolodine@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2159713002 Cr-Commit-Position: refs/heads/master@{#405976} [modify] https://crrev.com/dd11513c44ebc8ed0d5da23b9a1b96e17050deea/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt
Comment 1 by joh...@chromium.org
, Jul 8 2016Summary: Implement PushSubscription.options (was: Expose PushSubscriptionOptions on PushSubscription)