New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 626612 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression

Blocking:
issue 589681



Sign in to add a comment

Regression : Weird overlapping of 'Manage search engines' overlay is seen in chrome://md-settings page.

Reported by mni...@etouch.net, Jul 8 2016

Issue description

Version: 54.0.2791.0 05f35eab096fe52eab3af2c6db191c1285dc5a68-refs/heads/master@{#404283} (32/64-bit)
OS:  Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4)

What steps will reproduce the problem?
1) Launch chrome and navigate to chrome://md-settings/
2) Now scroll down the page and click on 'Manage search engines' to open overlay
3) Now click on 'Menu' icon to open side navigation menu drawer and click on 'Advanced' observe

Actual : Weird overlapping of 'Manage search engines' overlay is seen with 'side navigation menu' drawer
Expected : Weird overlapping of 'Manage search engines' overlay should not be seen with 'side navigation menu' drawer

This is a regression issue broken in 'M-53' and below is the manual regression and Narrow bisect info:
Good build : 53.0.2777.0
Bad build : 53.0.2778.0

Narrow bisect info:
https://chromium.googlesource.com/chromium/src/+log/e95fc1fa03174e0064d73638d9e6ad364ecdb514..a806e74826ea63c1493d850e2bb0e4dbcb7f0456?pretty=fuller&n=50

Suspecting : r401711 from Narrow bisect 

@dschuyler : Could you please help to reassign if your change is not the cause for this change.
 
Actual_video.mp4
1.1 MB View Download
Expected_video.mp4
1.2 MB View Download
Actual_screenshot.png
252 KB View Download
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
just to update, able to reproduce the issue on Win7, Mac OS X 10.11.5 & Ubuntu 14.04 using Chrome Canary # 54.0.2799.0, attached screencast for reference.

dschuyler@ could you please check the issue and update.


Actual_video_canary_54.0.2799.0.mp4
776 KB View Download

Comment 3 by ajha@chromium.org, Jul 21 2016

Labels: -ReleaseBlock-Stable
Removing the Blocker label as the feature is still under development. Please add it back if someone feels otherwise.
Owner: michae...@chromium.org
Blocking: 589681
Labels: -OS-Linux -OS-Windows -OS-Mac Proj-MaterialDesign-WebUI OS-All
Labels: Hotlist-MD-Settings-Navigation
Cc: dschuyler@chromium.org
 Issue 630945  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/037200ffe4f9042614082852fd47fa84e94f905e

commit 037200ffe4f9042614082852fd47fa84e94f905e
Author: michaelpg <michaelpg@chromium.org>
Date: Tue Aug 16 21:54:39 2016

MD Settings: Sections shouldn't overlap toolbar or drawer

Expanding/collapsing sections should draw underneath the cr-toolbar and
app-drawer. Setting the right z-index values ensures this happens.

BUG= 626612 
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2248843002
Cr-Commit-Position: refs/heads/master@{#412350}

[modify] https://crrev.com/037200ffe4f9042614082852fd47fa84e94f905e/chrome/browser/resources/settings/settings_page_css.html
[modify] https://crrev.com/037200ffe4f9042614082852fd47fa84e94f905e/chrome/browser/resources/settings/settings_ui/settings_ui.html

 Issue 642257  has been merged into this issue.
Status: Fixed (was: Assigned)

Sign in to add a comment